[PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Manolis Ragkousis]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

In the sans-free cross-gcc, libitm, libvtv and, libsanitizer configure
scripts will fail with "configure: error: C compiler cannot create
executables". I have attached the build log.

Disabling them fixes it.

If ok I will push to master.

Manolis



[-- Attachment #2: k431s5wp53d2p3bnz5kvx0km58vpy1-gcc-cross-sans-libc-i686-linux-gnu-4.9.3.drv.bz2 --]
[-- Type: application/x-bzip, Size: 389904 bytes --]

[-- Attachment #3: 0001-gnu-cross-gcc-arguments-Disable-libitm-libvtv-and-li.patch --]
[-- Type: text/x-patch, Size: 1132 bytes --]

From be59086da781969e82d0bb9fb9fff851d51faa65 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Tue, 16 Feb 2016 15:06:33 +0200
Subject: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and
 libsanitizer.

* gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add
  "--disable-libitm", "--disable-libvtv" and "--disable-libsanitizer"
  when libc is not present.
---
 gnu/packages/cross-base.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
index 8bd599c..bbc1c48 100644
--- a/gnu/packages/cross-base.scm
+++ b/gnu/packages/cross-base.scm
@@ -120,6 +120,9 @@ may be either a libc package or #f.)"
                                "--disable-libquadmath"
                                "--disable-decimal-float" ;would need libc
                                "--disable-libcilkrts"
+                               "--disable-libitm"
+                               "--disable-libvtv"
+                               "--disable-libsanitizer"
                                )))
 
                  ,(if libc
-- 
2.7.1

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Manolis Ragkousis]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

Hello everyone

This is a follow up to better explain what the problem is with the
sans-libc cross gcc in the (gnu packages cross-base) module.

In the latest master if you try to build gcc-cross-sans-libc with:

./pre-inst-env guix build -e '((@@(gnu packages cross-base) cross-gcc)
"i686-linux-gnu")' -c8

gcc modules libitm, libvtv and libsanitizer fail to build with
"configure: error: C compiler cannot create executables".

This happens because there is no libc present at that point and the
problem was introduced with commit ca7ef4d41854218c which enabled c++.

At that stage no linking can happen so the best solution is to just
disable the modules. It does not affect anything after that.

I am attaching the build.log so anybody can see for himself. :-)

If okay I will push the patch to master.

Manolis

[-- Attachment #2: vgwilvn1nmafdfhd1nlka2qkz0pkx5-gcc-cross-sans-libc-i686-linux-gnu-4.9.3.drv.bz2 --]
[-- Type: application/x-bzip, Size: 390239 bytes --]

[-- Attachment #3: 0001-gnu-cross-gcc-arguments-Disable-libitm-libvtv-and-li.patch --]
[-- Type: text/x-patch, Size: 1132 bytes --]

From be59086da781969e82d0bb9fb9fff851d51faa65 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Tue, 16 Feb 2016 15:06:33 +0200
Subject: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and
 libsanitizer.

* gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add
  "--disable-libitm", "--disable-libvtv" and "--disable-libsanitizer"
  when libc is not present.
---
 gnu/packages/cross-base.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
index 8bd599c..bbc1c48 100644
--- a/gnu/packages/cross-base.scm
+++ b/gnu/packages/cross-base.scm
@@ -120,6 +120,9 @@ may be either a libc package or #f.)"
                                "--disable-libquadmath"
                                "--disable-decimal-float" ;would need libc
                                "--disable-libcilkrts"
+                               "--disable-libitm"
+                               "--disable-libvtv"
+                               "--disable-libsanitizer"
                                )))
 
                  ,(if libc
-- 
2.7.1

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Ricardo Wurmus]

Manolis Ragkousis <manolis837@gmail.com> writes:

> This is a follow up to better explain what the problem is with the
> sans-libc cross gcc in the (gnu packages cross-base) module.
>
> In the latest master if you try to build gcc-cross-sans-libc with:
>
> ./pre-inst-env guix build -e '((@@(gnu packages cross-base) cross-gcc)
> "i686-linux-gnu")' -c8
>
> gcc modules libitm, libvtv and libsanitizer fail to build with
> "configure: error: C compiler cannot create executables".
>
> This happens because there is no libc present at that point and the
> problem was introduced with commit ca7ef4d41854218c which enabled c++.

I find this very odd.  I’m the author of that commit and I did this to
be able to build a C and C++ cross compiler for arm-none-eabi (which I
still haven’t submitted to the ML).  At no point did I see any errors
about libitm, libvtv, or libsanitizer.

My cross-compiler is made with little more than “(cross-gcc
"arm-none-eabi")”, so I wonder why you’d have problems with building a
cross-compiler for “i686-linux-gnu”.

> At that stage no linking can happen so the best solution is to just
> disable the modules. It does not affect anything after that.

I cannot verify this as I’m not familiar with all this (and I cannot
rebuild my cross-compiler at this point).  This doesn’t mean I object to
this change, I just don’t understand why we see it with “i686-linux-gnu”
but not with my “arm-none-eabi” build :-/

Could you please also add some comment above the new flags to concisely
say why they are needed?  That’s just to prevent people like me from
removing the flags in the future because “they don’t seem to do
anything” :)

Thanks!

~~ Ricardo

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[宋文武]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> Manolis Ragkousis <manolis837@gmail.com> writes:
>
>> This is a follow up to better explain what the problem is with the
>> sans-libc cross gcc in the (gnu packages cross-base) module.
>>
>> In the latest master if you try to build gcc-cross-sans-libc with:
>>
>> ./pre-inst-env guix build -e '((@@(gnu packages cross-base) cross-gcc)
>> "i686-linux-gnu")' -c8
>>
>> gcc modules libitm, libvtv and libsanitizer fail to build with
>> "configure: error: C compiler cannot create executables".
>>
>> This happens because there is no libc present at that point and the
>> problem was introduced with commit ca7ef4d41854218c which enabled c++.
>
> I find this very odd.  I’m the author of that commit and I did this to
> be able to build a C and C++ cross compiler for arm-none-eabi (which I
> still haven’t submitted to the ML).  At no point did I see any errors
> about libitm, libvtv, or libsanitizer.
>
On the master, ‘arm-linux-gnueabihf’ also failed.
Look at the end of ‘configure.tgt’ scripts of libitm, libvtv and
libsanitizer, the target is matched with some well-known OS (eg: linux,
gnu, etc.).  So, I think those libraries won’t build at all when you’re
using ‘none’ as OS.

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Ricardo Wurmus]

宋文武 <iyzsong@member.fsf.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> Manolis Ragkousis <manolis837@gmail.com> writes:
>>
>>> This is a follow up to better explain what the problem is with the
>>> sans-libc cross gcc in the (gnu packages cross-base) module.
>>>
>>> In the latest master if you try to build gcc-cross-sans-libc with:
>>>
>>> ./pre-inst-env guix build -e '((@@(gnu packages cross-base) cross-gcc)
>>> "i686-linux-gnu")' -c8
>>>
>>> gcc modules libitm, libvtv and libsanitizer fail to build with
>>> "configure: error: C compiler cannot create executables".
>>>
>>> This happens because there is no libc present at that point and the
>>> problem was introduced with commit ca7ef4d41854218c which enabled c++.
>>
>> I find this very odd.  I’m the author of that commit and I did this to
>> be able to build a C and C++ cross compiler for arm-none-eabi (which I
>> still haven’t submitted to the ML).  At no point did I see any errors
>> about libitm, libvtv, or libsanitizer.
>>
> On the master, ‘arm-linux-gnueabihf’ also failed.
> Look at the end of ‘configure.tgt’ scripts of libitm, libvtv and
> libsanitizer, the target is matched with some well-known OS (eg: linux,
> gnu, etc.).  So, I think those libraries won’t build at all when you’re
> using ‘none’ as OS.

Ah, this makes sense.  Thanks for the clarification.

~~ Ricardo

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Manolis Ragkousis]

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

I updated the patch with an explanation and a link to this discussion.

Manolis

[-- Attachment #2: 0001-gnu-cross-gcc-arguments-Disable-libitm-libvtv-and-li.patch --]
[-- Type: text/x-patch, Size: 1449 bytes --]

From dc8154ef19bc28886f350f42c49fb7995eefcec8 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Tue, 16 Feb 2016 15:06:33 +0200
Subject: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and
 libsanitizer.

* gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add
  "--disable-libitm", "--disable-libvtv" and "--disable-libsanitizer"
  when libc is not present.
---
 gnu/packages/cross-base.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
index 8bd599c..bd7a1e7 100644
--- a/gnu/packages/cross-base.scm
+++ b/gnu/packages/cross-base.scm
@@ -120,6 +120,14 @@ may be either a libc package or #f.)"
                                "--disable-libquadmath"
                                "--disable-decimal-float" ;would need libc
                                "--disable-libcilkrts"
+
+                               ;; When target is any OS other than 'none' these
+                               ;; libraries will fail if there is no libc
+                               ;; present. See
+                               ;; <https://lists.gnu.org/archive/html/guix-devel/2016-02/msg01311.html>
+                               "--disable-libitm"
+                               "--disable-libvtv"
+                               "--disable-libsanitizer"
                                )))
 
                  ,(if libc
-- 
2.7.2

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Ludovic Courtès]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> This is a follow up to better explain what the problem is with the
> sans-libc cross gcc in the (gnu packages cross-base) module.
>
> In the latest master if you try to build gcc-cross-sans-libc with:
>
> ./pre-inst-env guix build -e '((@@(gnu packages cross-base) cross-gcc)
> "i686-linux-gnu")' -c8
>
> gcc modules libitm, libvtv and libsanitizer fail to build with
> "configure: error: C compiler cannot create executables".

What I don’t get is that I have:

--8<---------------cut here---------------start------------->8---
$ git describe 
v0.9.0-2029-g863c4ee
$ ./pre-inst-env guix build -e '((@@ (gnu packages cross-base) cross-gcc) "mips64el-linux-gnu")' -n
The following files would be downloaded:
   /gnu/store/13nnp704cvxh05gxkbpqvjvhvqwf6b24-gcc-cross-sans-libc-mips64el-linux-gnu-4.9.3
   /gnu/store/bgm8y2j42dmviyc51kk2wcgjhvfpmc08-binutils-cross-mips64el-linux-gnu-2.25.1
   /gnu/store/d9rk59ff8zc42726fr2zdr572kb152i6-isl-0.11.1
   /gnu/store/hm1mw6lxdiaxq0370rigbwspj31nn1a8-mpc-1.0.3
   /gnu/store/sbsrma5yd943smdvcr7wnd2x5hd8jm7c-cloog-0.18.0
   /gnu/store/vachrk9j3f8yrh52v1yiwjv40dhaahnh-ld-wrapper-mips64el-linux-gnu-0
$ ./pre-inst-env guix build -e '((@@ (gnu packages cross-base) cross-gcc) "mips64el-linux-gnuabi64")' -n --no-grafts
substitute: updating list of substitutes from 'http://hydra.gnunet.org'... 100.0%
The following files would be downloaded:
   /gnu/store/w97wggnw4vqzknlnvhplfm722spsh66r-gcc-cross-sans-libc-mips64el-linux-gnuabi64-4.9.3
   /gnu/store/54cam4jxh59kv32xawq531h2hz397bia-binutils-cross-mips64el-linux-gnuabi64-2.25.1
   /gnu/store/5b2k4mmfyp3vimjqiq8msk2dsyaj2yg4-ld-wrapper-mips64el-linux-gnuabi64-0
   /gnu/store/d9rk59ff8zc42726fr2zdr572kb152i6-isl-0.11.1
   /gnu/store/hm1mw6lxdiaxq0370rigbwspj31nn1a8-mpc-1.0.3
   /gnu/store/sbsrma5yd943smdvcr7wnd2x5hd8jm7c-cloog-0.18.0
--8<---------------cut here---------------end--------------->8---

So maybe the failure is specific to i686 or something?

(In which case it’s of course still worth fixing.  Just trying to
understand.)

Thanks for the analysis, and apologies for the loooong delay!

Ludo’.

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Manolis Ragkousis]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Hey Ludo,

I have reproduced the problem on the latest master targeting i686-linux
and arm-linux-gnueabihf.

The problem is that those libraries will fail to build when glibc is not
present. Also if target os is none, this problem will not appear because
the libs will not get built at all.

You can reproduce it with ./pre-inst-env guix build -e '((@@(gnu
packages cross-base) cross-gcc) "arm-linux-gnueabihf")'

This does not happen when targeting mips.

I have added an explanation to the patch and a link to this thread.

Manolis

[-- Attachment #2: 0001-gnu-cross-gcc-arguments-Disable-libitm-libvtv-and-li.patch --]
[-- Type: text/x-patch, Size: 1449 bytes --]

From dc8154ef19bc28886f350f42c49fb7995eefcec8 Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Tue, 16 Feb 2016 15:06:33 +0200
Subject: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and
 libsanitizer.

* gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add
  "--disable-libitm", "--disable-libvtv" and "--disable-libsanitizer"
  when libc is not present.
---
 gnu/packages/cross-base.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
index 8bd599c..bd7a1e7 100644
--- a/gnu/packages/cross-base.scm
+++ b/gnu/packages/cross-base.scm
@@ -120,6 +120,14 @@ may be either a libc package or #f.)"
                                "--disable-libquadmath"
                                "--disable-decimal-float" ;would need libc
                                "--disable-libcilkrts"
+
+                               ;; When target is any OS other than 'none' these
+                               ;; libraries will fail if there is no libc
+                               ;; present. See
+                               ;; <https://lists.gnu.org/archive/html/guix-devel/2016-02/msg01311.html>
+                               "--disable-libitm"
+                               "--disable-libvtv"
+                               "--disable-libsanitizer"
                                )))
 
                  ,(if libc
-- 
2.7.2

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]

On Thu, Apr 07, 2016 at 04:07:25PM +0300, Manolis Ragkousis wrote:
> Hey Ludo,
> 
> I have reproduced the problem on the latest master targeting i686-linux
> and arm-linux-gnueabihf.
> 
> The problem is that those libraries will fail to build when glibc is not
> present. Also if target os is none, this problem will not appear because
> the libs will not get built at all.
> 
> You can reproduce it with ./pre-inst-env guix build -e '((@@(gnu
> packages cross-base) cross-gcc) "arm-linux-gnueabihf")'
> 
> This does not happen when targeting mips.
> 
> I have added an explanation to the patch and a link to this thread.
> 
> Manolis

This patch was instrumental in building aarch64 bootstrap tarballs.
Without it, when building the cross-gcc compiler from x86_64 to aarch64
it would fail to compile when trying to build libitm. Searching around
the internet suggested that this was only when building a cross-compiler
that targeted C++ and not only C.

I understand that it's too late to push this to core-updates, but we
should push it to core-updates-next.


> From dc8154ef19bc28886f350f42c49fb7995eefcec8 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Tue, 16 Feb 2016 15:06:33 +0200
> Subject: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and
>  libsanitizer.
> 
> * gnu/packages/cross-base.scm (cross-gcc-arguments)[arguments]: Add
>   "--disable-libitm", "--disable-libvtv" and "--disable-libsanitizer"
>   when libc is not present.
> ---
>  gnu/packages/cross-base.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
> index 8bd599c..bd7a1e7 100644
> --- a/gnu/packages/cross-base.scm
> +++ b/gnu/packages/cross-base.scm
> @@ -120,6 +120,14 @@ may be either a libc package or #f.)"
>                                 "--disable-libquadmath"
>                                 "--disable-decimal-float" ;would need libc
>                                 "--disable-libcilkrts"
> +
> +                               ;; When target is any OS other than 'none' these
> +                               ;; libraries will fail if there is no libc
> +                               ;; present. See
> +                               ;; <https://lists.gnu.org/archive/html/guix-devel/2016-02/msg01311.html>
> +                               "--disable-libitm"
> +                               "--disable-libvtv"
> +                               "--disable-libsanitizer"
>                                 )))
>  
>                   ,(if libc
> -- 
> 2.7.2
> 


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: cross-gcc-arguments: Disable libitm, libvtv and, libsanitizer.

[Ludovic Courtès]

Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Thu, Apr 07, 2016 at 04:07:25PM +0300, Manolis Ragkousis wrote:
>> Hey Ludo,
>> 
>> I have reproduced the problem on the latest master targeting i686-linux
>> and arm-linux-gnueabihf.
>> 
>> The problem is that those libraries will fail to build when glibc is not
>> present. Also if target os is none, this problem will not appear because
>> the libs will not get built at all.
>> 
>> You can reproduce it with ./pre-inst-env guix build -e '((@@(gnu
>> packages cross-base) cross-gcc) "arm-linux-gnueabihf")'
>> 
>> This does not happen when targeting mips.
>> 
>> I have added an explanation to the patch and a link to this thread.
>> 
>> Manolis
>
> This patch was instrumental in building aarch64 bootstrap tarballs.
> Without it, when building the cross-gcc compiler from x86_64 to aarch64
> it would fail to compile when trying to build libitm. Searching around
> the internet suggested that this was only when building a cross-compiler
> that targeted C++ and not only C.
>
> I understand that it's too late to push this to core-updates, but we
> should push it to core-updates-next.

Sorry for the delay again.  Since it touches the cross toolchain and not
the main toolchain (Manolis, could you double-check that this is
correct, by making sure that “./pre-inst-env guix build coreutils -d” is
the same both before and after the patch?), it’s still OK to push to
‘core-updates’.

Manolis: OK to push?

Thanks for the heads-up, Efraim!

Ludo’.