From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCHES] Update orfm and package test requirements. Date: Thu, 14 Jan 2016 08:05:58 +1000 Message-ID: <5696CA46.7030701@uq.edu.au> References: <564FBEA5.6020604@uq.edu.au> <569647AE.8050401@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJTYh-00066t-Rp for guix-devel@gnu.org; Wed, 13 Jan 2016 17:06:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJTYe-0003tU-Lk for guix-devel@gnu.org; Wed, 13 Jan 2016 17:06:27 -0500 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:57811 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJTYe-0003sl-2z for guix-devel@gnu.org; Wed, 13 Jan 2016 17:06:24 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: "guix-devel@gnu.org" On 13/01/16 23:50, Ricardo Wurmus wrote: > Ben Woodcroft writes: > > [..] >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-before 'check 'patch-and-set-version >> + (lambda _ >> + (setenv "VERSION" ,version) >> + #t))))) > That=E2=80=99s an odd phase name; why =E2=80=9Cpatch=E2=80=9D? Is sett= ing the environment > variable the only way to set the version or would a make-flag work here= , > too? (I haven=E2=80=99t checked if the ruby-build-system respects make= -flags.) > > The rest looks good to me. Thanks! Pushed, thanks. The phase name above was a bit crufty so I changed it,=20 but had to go with setenv since the ruby-build-system doesn't support=20 make-flags (or rake-flags). Thanks, ben