From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCHES] Update orfm and package test requirements.
Date: Thu, 14 Jan 2016 08:05:58 +1000 [thread overview]
Message-ID: <5696CA46.7030701@uq.edu.au> (raw)
In-Reply-To: <idjio2xfv0c.fsf@bimsb-sys02.mdc-berlin.net>
On 13/01/16 23:50, Ricardo Wurmus wrote:
> Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
>
>
[..]
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-before 'check 'patch-and-set-version
>> + (lambda _
>> + (setenv "VERSION" ,version)
>> + #t)))))
> That’s an odd phase name; why “patch”? Is setting the environment
> variable the only way to set the version or would a make-flag work here,
> too? (I haven’t checked if the ruby-build-system respects make-flags.)
>
> The rest looks good to me. Thanks!
Pushed, thanks. The phase name above was a bit crufty so I changed it,
but had to go with setenv since the ruby-build-system doesn't support
make-flags (or rake-flags).
Thanks,
ben
prev parent reply other threads:[~2016-01-13 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 0:45 [PATCHES] Update orfm and package test requirements Ben Woodcroft
2015-11-27 13:19 ` Ricardo Wurmus
2016-01-13 12:48 ` Ben Woodcroft
2016-01-13 13:50 ` Ricardo Wurmus
2016-01-13 22:05 ` Ben Woodcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5696CA46.7030701@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).