From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH] Update Ruby to 2.3.0 Date: Mon, 11 Jan 2016 22:52:45 +1000 Message-ID: <5693A59D.3000605@uq.edu.au> References: <87wprqspc3.fsf@gnu.org> <5689C833.3050608@uq.edu.au> <568A4D9E.3030504@uq.edu.au> <87a8ojk6kp.fsf@gnu.org> <568F9AA9.7040605@uq.edu.au> <87wprkggjz.fsf_-_@gnu.org> <56925443.6070608@uq.edu.au> <569254F3.7070400@uq.edu.au> <87lh7xyw5p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIbxx-0002Np-1T for Guix-devel@gnu.org; Mon, 11 Jan 2016 07:52:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIbxt-0001I7-Oo for Guix-devel@gnu.org; Mon, 11 Jan 2016 07:52:56 -0500 In-Reply-To: <87lh7xyw5p.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: Guix-devel On 11/01/16 07:14, Ludovic Court=C3=A8s wrote: > Ben Woodcroft skribis: > >> From 2f26295b5a163cfc5d37332a501dcba5c40fb956 Mon Sep 17 00:00:00 200= 1 >> From: Ben Woodcroft >> Date: Mon, 4 Jan 2016 09:38:42 +1000 >> Subject: [PATCH 5/5] gnu: ruby: Update to 2.3.0. >> >> * gnu/packages/ruby.scm (ruby): Update to 2.3.0. >> [arguments]: Remove bundled libffi. Use parallel tests. >> (ruby-2.2): New variable. > [...] > >> + ;; Remove bundled libffi >> + (delete-file-recursively >> + (string-append "ext/fiddle/libffi-3.2.1")) > I should have mentioned it before, but could you move the removal to a > =E2=80=98snippet=E2=80=99 in the origin? All pushed to core-updates with a snippet and minor formatting changes. >> From 015a0e17be804dd7f68f21cde8a878ff353a4a97 Mon Sep 17 00:00:00 200= 1 >> From: Ben Woodcroft >> Date: Fri, 8 Jan 2016 17:29:39 +1000 >> Subject: [PATCH 3/5] ruby: Abstract out path to GEM_HOME. >> >> Previously paths to the GEM_HOME of certain Ruby packages were >> hard-coded, so packages failed to build when Ruby was updated to 2.3.0. >> >> * guix/build/ruby-build-system.scm (gem-home): New procedure. >> * gnu/packages/ruby.scm (ruby-metaclass, ruby-instantiator, >> ruby-introspection, ruby-mocha, ruby-minitest-tu-shim): Use it. > LGTM. > > However, ultimately, we should pass the Ruby version as a keyword > parameter on the build side or have a build-side procedure akin to > =E2=80=98get-python-version=E2=80=99 in python-build-system.scm (I=E2=80= =99d prefer the former.) > > That way, phases could query the version number of the Ruby that=E2=80=99= s > actually used instead of using the version number of whatever variant > the global =E2=80=98ruby=E2=80=99 variable refers to. This would allow= users to simply > change the =E2=80=9Cruby=E2=80=9D input of a package and have it automa= tically work with > the new package. > > Does that make sense? > > This can always be done after the =E2=80=98core-updates=E2=80=99 merge,= no rush. OK then. I reckon we should provide a procedure to get to the lib/=20 directory as well, based on the upstream name property too. Then we can=20 use it for the require test too. Thanks, ben