From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH] Add Jellyfish.
Date: Sat, 19 Dec 2015 09:25:23 +1000
Message-ID: <567495E3.5010803@uq.edu.au>
References: <idjy4cr6748.fsf@bimsb-sys02.mdc-berlin.net>
	<9507d13e837c22beb6e5a79cce045222@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1aA4P6-0007BF-M2
	for guix-devel@gnu.org; Fri, 18 Dec 2015 18:25:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1aA4P5-0002Pd-Fq
	for guix-devel@gnu.org; Fri, 18 Dec 2015 18:25:40 -0500
In-Reply-To: <9507d13e837c22beb6e5a79cce045222@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>, Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>, guix-devel-bounces+ericbavier=openmailbox.org@gnu.org

Hi Ricardo,

On 19/12/15 04:19, Eric Bavier wrote:
> On 2015-12-18 17:42, Ricardo Wurmus wrote:
>> * gnu/packages/bioinformatics.scm (jellyfish): New variable.
> [...]
>> +    (native-inputs
>> +     `(("bc" ,bc)
>> +       ("time" ,time)
>> +       ("gunzip" ,gzip)))
>
> gzip is an implicit input of gnu-build-system, so could it be left out?
My testing confirms this.

But would it be possible to include the scripting language bindings, 
something along these lines?

+    (arguments
+     `(#:configure-flags '("--enable-ruby-binding"
+                           "--enable-python-binding"
+                           "--enable-perl-binding")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'set-SHELL-variable
+           (lambda _
+             ;; generator_manager.hpp either uses /bin/sh or $SHELL
+             ;; to run tests.
+             (setenv "SHELL" (which "bash"))
+             #t)))))
+    (native-inputs
+     `(("bc" ,bc)
+       ("time" ,time)
+       ("ruby" ,ruby)
+       ("python" ,python-2)
+       ("perl" ,perl)))

Currently the perl tests fail for reasons I don't have time to 
investigate, and perhaps some search paths need to be exported too.

I did find the time to confirm that the most important part of this 
program works though:

sh-4.3# jellyfish jf
                    .......
           ..........      .....
        ....                   ....
       ..     /-+       +---\     ...
       .     /--|       +----\      ...
      ..                              ...
      .                                 .
      ..      +----------------+         .
       .      |. AAGATGGAGCGC .|         ..
       .      |---.        .--/           .
      ..          \--------/     .        .
      .     .            ..     ..        .
      .    ... .....   .....    ..        ..
      .   .. . .   .  ..   .   ....        .
      .  ..  . ..   . .    ..  .  .         .
      . ..   .  .   ...     . ..  ..        .
     ....    . ..   ..      ...    ..       .
    .. .     ...     .      ..      ..      .
    . ..      .      .       .       ...    ..
    ...       .      .      ..         ...   .
    .         ..     .      ..           .....
   ____  ____  ._    __   _  _  ____  ____  ___  _   _
  (_  _)( ___)(  )  (  ) ( \/ )( ___)(_  _)/ __)( )_( )
.-_)(   )__)  )(__  )(__ \  /  )__)  _)(_ \__ \ ) _ (
\____) (____)(____)(____)(__) (__)  (____)(___/(_) (_)