From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Paul Schmidt Subject: Re: [PATCH]: xfce4-power-manager: new variable Date: Fri, 4 Dec 2015 20:02:22 +0100 Message-ID: <5661E33E.6080904@gmx.net> References: <56604C07.2040900@gmx.net> <5660B6E2.3090108@gmx.net> <20151204171614.GB7216@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4vci-0007lw-Ka for guix-devel@gnu.org; Fri, 04 Dec 2015 14:02:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4vcf-0001Qy-B9 for guix-devel@gnu.org; Fri, 04 Dec 2015 14:02:28 -0500 Received: from mout.gmx.net ([212.227.17.22]:64193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4vcf-0001QN-1d for guix-devel@gnu.org; Fri, 04 Dec 2015 14:02:25 -0500 In-Reply-To: <20151204171614.GB7216@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 12/04/2015 06:16 PM, Andreas Enge wrote: > On Thu, Dec 03, 2015 at 10:40:50PM +0100, Florian Paul Schmidt > wrote: >> Removed some inputs (see attached patch). Seems to still build >> and run.. > > I usually work the other way round. I start with empty inputs and > look at the output of the configure phase, then add inputs one by > one. This leads to cleaner packages, I think. > > Notice that it is not enough to make the binary distinction between > building and not building. Sometimes optional inputs are useful to > have (I tend to be maximalist and add as many optional inputs as > possible). Yeah, in the current state the basically the only inputs that remain are those I had to add in the first place to get it to build (the ones I now removed are leftovers from the original xfce4-related package). I guess the native-search-path thing might go away safely, too. Will test and update the patch.. Flo - -- https://fps.io -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWYeM+AAoJEA5f4Coltk8ZJFkH/2XZLjsYYgz4fBsvboxTEwVk DiMb+6pT9pvAkte3nrboeVJn9SVZAogVlSUvhwsDOs3JZC9g52j3u+25kO4whtHU ah59hUxiflpK9wEdQHEinXnv6ej8VDvbbthg9y2L0LCTmm7Ww49JWNqwLEKnFlND YaNrzAsjzvPsFGGL5velCD1V+2ukw99Wqlx+0b0cz6bHbRReYsfQk3e6OTkaDBtQ t4W0pX9jHUZT9/YJmpjid38HACX66QprQTw+3HGcO01VMy8sSJKlFeYIRsvh8xib zH+ynIitAw150K1yFHZoGHGgGFN6XnxuR0LJs2iQihHkS5sCxcn3sbbR1zqqhuw= =8Iat -----END PGP SIGNATURE-----