From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH] gnu: Add python-contextlib2 Date: Wed, 18 Nov 2015 22:55:37 +1000 Message-ID: <564C7549.3070707@uq.edu.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz2HA-0006il-38 for guix-devel@gnu.org; Wed, 18 Nov 2015 07:55:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz2H5-0007fD-2v for guix-devel@gnu.org; Wed, 18 Nov 2015 07:55:51 -0500 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:51425 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz2H4-0007cR-IC for guix-devel@gnu.org; Wed, 18 Nov 2015 07:55:47 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Chris Marusich , "guix-devel@gnu.org" Hi there. On 18/11/15 18:31, Chris Marusich wrote: > Hi, > > I've packaged contextlib2. This is my first submission, so please let > me know if there is anything that should be different about the > changes I've made. Also, if there's anything odd about the way I've > formatted these patches or this email, please let me know so I can > correct it next time. If I'm understanding correctly, the sole purpose of the patch is to make the tests run. In that case, I think it might be simpler to replace the check phase like so? (build-system python-build-system) (arguments `(#:phases (modify-phases %standard-phases (replace 'check (lambda _ (system* "python" "test_contextlib2.py", "-v")))))) Thanks for the contribution. I second Andreas' welcome. ben