unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christina O'Donnell <cdo@mutix.org>
To: Steve George <steve@futurile.net>
Cc: guix-devel <guix-devel@gnu.org>, efraim@flashner.co.il
Subject: Re: Coordinators for patch review session on Tuesday
Date: Wed, 3 Apr 2024 12:00:08 +0100	[thread overview]
Message-ID: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> (raw)
In-Reply-To: <t3tujx6bfoa7w5cdkowilb42s5hsvpaeobu4frti6xg6jzbhpo@6vbh62hr62l2>

Hi Steve,

On 02/04/2024 21:23, Steve George wrote:
> Hi Christina - thanks for coming along today - I hope it was useful.

Yes I did find it helpful. Since I'm the least experienced out of 
everyone there, I just stayed quiet and tried to absorb as much as I could.

It was good to see that not everyone was using Emacs, and I'm going to 
try to start using Efraim's vi script for GTAGS in Guile.

> There's good instructions on the Wiki on how to review patches:
>
> https://libreplanet.org/wiki?title=Group:Guix/PatchReviewSessions2024
>
> I would love feedback on how to improve them!
>
> There's plenty of patches to review, I've been keeping a list of them for the patch review calls:
>
> https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=patch-review-hackers-list;users=guix
>
> And the wiki page references some other reports.
>
> Please pick some patches and have a go - if you want someone else to look at them feel free to ping here or on IRC!

Thank you for writing this up in so much depth! I've reviewed [1] and 
tried to tag it as reviewed-looks-good, though I don't think that has 
gone through. If you or someone else could take a look at it then I'd 
appreciate that. I plan on reviewing some more patches this evening.

Kind regards,
Christina

[1] https://debbugs.gnu.org/cgi-bin/bugreport.cgi?users=guix;bug=65938


  reply	other threads:[~2024-04-03 11:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-31 21:58 Coordinators for patch review session on Tuesday Steve George
2024-04-02 10:09 ` Christina O'Donnell
2024-04-02 20:23   ` Steve George
2024-04-03 11:00     ` Christina O'Donnell [this message]
2024-04-03 23:01       ` Christina O'Donnell
2024-04-04 14:57       ` Steve George
2024-04-04 17:27         ` Christina O'Donnell
2024-04-05  7:54           ` Steve George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org \
    --to=cdo@mutix.org \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=steve@futurile.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).