From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH 2/2] gnu: Add oslo.i18n.
Date: Fri, 04 Sep 2015 22:03:29 +0200
Message-ID: <55E9F911.8040509@gmail.com>
References: <1441148656-303-1-git-send-email-tipecaml@gmail.com>	<1441148656-303-3-git-send-email-tipecaml@gmail.com>
	<87vbbqdkdl.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1ZXxCx-0006bb-OV
	for guix-devel@gnu.org; Fri, 04 Sep 2015 16:03:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1ZXxCu-0001b9-Jp
	for guix-devel@gnu.org; Fri, 04 Sep 2015 16:03:35 -0400
In-Reply-To: <87vbbqdkdl.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On 09/04/2015 10:01 PM, Ludovic Courtès wrote:
> Cyril Roelandt <tipecaml@gmail.com> skribis:
> 
>> * gnu/packages/openstack.scm (python-oslo.i18n, python2-oslo.i18n): New
>>   variables.
> 
> [...]
> 
>> +    (propagated-inputs
>> +      `(("python-babel" ,python-babel)
>> +        ("python-six" ,python-six)))
>> +    (inputs
>> +      `(("python-pbr" ,python-pbr)
>> +        ("python-setuptools" ,python-setuptools)
>> +        ;; Tests
> 
> Shouldn’t python-pbr be propagated?
> 

I think it is only used for the installation phase.

> Also, I’m under the impression that ‘guix import pypi’ adds
> python-setuptools even though it’s usually not required, no?
>

Yeah, setuptools might already be required by pbr, so maybe it is not
necessary to specify it here. I'll have to check.

>> +    (description "Oslo i18n library")
> 
> Please elaborate, and expand “i18n.”
> 

OK.


Cyril.