From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: Re: [PATCH 02/11] gnu: Add oslotest. Date: Thu, 23 Jul 2015 00:13:22 +0200 Message-ID: <55B01582.5050609@gmail.com> References: <1437003151-23838-1-git-send-email-tipecaml@gmail.com> <1437003151-23838-3-git-send-email-tipecaml@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI2GX-0001Lg-VF for guix-devel@gnu.org; Wed, 22 Jul 2015 18:13:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZI2GU-0005Z3-OW for guix-devel@gnu.org; Wed, 22 Jul 2015 18:13:29 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:35537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI2GU-0005Yn-IA for guix-devel@gnu.org; Wed, 22 Jul 2015 18:13:26 -0400 Received: by wibxm9 with SMTP id xm9so182775698wib.0 for ; Wed, 22 Jul 2015 15:13:26 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel On 07/20/2015 06:14 PM, Thompson, David wrote: > On Wed, Jul 15, 2015 at 7:32 PM, Cyril Roelandt wrote: >> * gnu/packages/openstack.scm: New file. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add it here. >> * gnu/packages/python.scm (python-appdirs, python2-appdirs): New variables. > > Could you break this patch so that there is one package per patch? Hum, I'm not sure whether that really makes sense. The main "feature" I want to add is the package for oslotest, so it seemed natural to add its dependencies in the same patch, especially since there is only one. Plus, this would make this patch series *huge*. Do we really want that? > Also, all of the Python packages in openstack.scm look like they > really belong in python.scm. Could you move them? > Well, in the end, we could have everything from PyPI in python.scm. OpenStack is a huge project, so I thought it would make sense to have its packages in their own file. WDYT? Thanks for the review, Cyril.