From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Benc Subject: Re: [PATCH] gnu: Add most debian patches to nvi. Date: Thu, 22 Jan 2015 17:39:31 +0100 Message-ID: <54C127C3.9070705@gmail.com> References: <54BFBAED.3090502@gmail.com> <54BFBB39.5030200@gmail.com> <873874w508.fsf@gnu.org> <54BFC4FF.5030006@gmail.com> <87r3umby1w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEKn7-0008Db-22 for guix-devel@gnu.org; Thu, 22 Jan 2015 11:39:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEKn2-0004zh-Ll for guix-devel@gnu.org; Thu, 22 Jan 2015 11:39:32 -0500 In-Reply-To: <87r3umby1w.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= Cc: guix-devel@gnu.org On 01/22/2015 05:05 PM, Ludovic Courtès wrote: > Marek Benc skribis: > >> On 01/21/2015 04:03 PM, Ludovic Courtès wrote: >>> I agree with Andreas: there are 20 patches, and that level of patching >>> goes beyond our mission, IMO. >>> >>> I would rather leave it as is if it’s usable, or remove it, or point to >>> a new upstream if there is one. >> In that case, I think at least two of the patches should be allowed to >> get in, the ones about the Berkely db library, since it's spewing out >> errors without them. (but the editor itself works) > You mean there are run-time errors without nvi-db4.patch? What kind? I mistyped, it's only warnings, the editor seems to work okay. In particular, the warnings look like this: BDB0635 DB_CREATE must be specified to create databases. BDB0511 page sizes must be a power-of-2 > The second patch is about page sizes apparently. Do you know what the > deal is? nvi seems to store the data of files in Berkely DB database objects, and when setting up a database for a file, it determines a page size to fit the file into 15 pages or less, using a page size of at least 1K and at most 10K. The way it does the calculation, I quote: psize = ((sb.st_size / 15) + 1023) / 1024; if (psize > 10) psize = 10; if (psize == 0) psize = 1; psize *= 1024; makes psize hold a variable that's a multiple of 1024, but not necessarilya power of two (for example, 3072). This didn't use to be a problem before, but nowadays, BDB requires pages to be powers of two, and so the modified code, I quote: psize = ((sb.st_size / 15) + 1023) / 1024; if (psize >= 8) psize=8<<10; else if (psize >= 4) psize=4<<10; else if (psize >= 2) psize=2<<10; else psize=1<<10; psize *= 1024; fixes that problem. > Two/three patches would be OK, but we need to have an understanding of > why we’re carrying these particular patches. Sure, I understand. > > Thank you! > > Ludo’. Marek