From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH] gnu: Add pyparsing.
Date: Wed, 26 Nov 2014 17:40:07 +0100
Message-ID: <54760267.8070203@gmail.com>
References: <CAKrPhPN_RqK2ViC_d8mudL3TuRRXS0DUrMgSmUmDidW8zt+tOw@mail.gmail.com>	<87a93ftcv2.fsf@gmail.com>
	<CAKrPhPOEKgnUKgq8xgjiefFaASDZBM+k8SfqhbQFt1eo3Zd=hQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57399)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1Xtfda-0002eD-7d
	for guix-devel@gnu.org; Wed, 26 Nov 2014 11:40:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1XtfdT-00009Y-Co
	for guix-devel@gnu.org; Wed, 26 Nov 2014 11:40:18 -0500
Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:59445)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1XtfdT-00008b-6B
	for guix-devel@gnu.org; Wed, 26 Nov 2014 11:40:11 -0500
Received: by mail-wg0-f50.google.com with SMTP id k14so4226357wgh.9
	for <guix-devel@gnu.org>; Wed, 26 Nov 2014 08:40:10 -0800 (PST)
Received: from [192.168.0.10] (tal33-3-82-233-82-24.fbx.proxad.net.
	[82.233.82.24])
	by mx.google.com with ESMTPSA id kv6sm7038412wjb.9.2014.11.26.08.40.07
	for <guix-devel@gnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Wed, 26 Nov 2014 08:40:08 -0800 (PST)
In-Reply-To: <CAKrPhPOEKgnUKgq8xgjiefFaASDZBM+k8SfqhbQFt1eo3Zd=hQ@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: guix-devel@gnu.org

On 11/25/2014 06:51 PM, Federico Beffa wrote:
> Cyril Roelandt <tipecaml@gmail.com> writes:
> 
>>
>> Maybe you could add the PyPI mirror here.
>>
> 
> I'm not sure I understand. Do you mean replace or really add? A second
> uri field? Could you give an example? The sourceforge download site is
> the one mentioned on the homepage.

Yes. The "uri" field can be a list (see libpng for instance). It would
be nice to have two reliable mirrors here.

> 
>>
>> There is a "unitTests.py" that can be run manually, if I'm not mistaken.
>> Maybe you could replace the check phase ?
>>
> 
> I do not think so.  I do not see any reference to tests in the README
> and other source files and I can't find a file called "unitTests.py".

Oh, that might just be in the SVN repository, then.

> 
>>
>> I trust you on the doc thing :) Is it something that could somehow be
>> part of the python build system?
>>
> 
> I'm not a python expert :-) From the few packages that I prepared
> lately, I have the impression that each python library does something
> different with the documentation.

Sad but true.

> 
>>
>> Do not start the synopsis by "a". You may want to run "guix lint" on
>> your package to find such issues.
>>
> 
> Ooops, forgot to run that.
> 
> Thanks for the review,

Thanks for the package!

Cyril.