From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] Add libtheora package Date: Mon, 14 Oct 2013 14:37:18 -0400 Message-ID: <525C39DE.7020304@worcester.edu> References: <525B2ADB.1000501@worcester.edu> <20131014092332.GA11904@debian.eduroam.u-bordeaux.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090005050003050000070909" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVn1B-0002yI-Cy for guix-devel@gnu.org; Mon, 14 Oct 2013 14:37:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVn14-0001Wp-FA for guix-devel@gnu.org; Mon, 14 Oct 2013 14:37:25 -0400 Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:49753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVn14-0001Vh-3W for guix-devel@gnu.org; Mon, 14 Oct 2013 14:37:18 -0400 Received: by mail-qe0-f54.google.com with SMTP id 1so5605894qec.13 for ; Mon, 14 Oct 2013 11:37:16 -0700 (PDT) In-Reply-To: <20131014092332.GA11904@debian.eduroam.u-bordeaux.fr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org This is a multi-part message in MIME format. --------------090005050003050000070909 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 10/14/2013 05:23 AM, Andreas Enge wrote: > On Sun, Oct 13, 2013 at 07:20:59PM -0400, David Thompson wrote: >> How does it look? > > It compiles well and looks good, congratulations! One point, though: > If you do > cd /nix/store/f06apny3g77kjk0wxzhmgl4b3ya77f0b-libtheora-1.1.1/lib/pkgconfig/ > grep Requires *.pc > you only see ogg, not vorbis. > So I think you can move libvorbis from propagated-inputs into regular inputs. > > At a later point, you might wish to add libsdl as an input (I think you were > working on it already.) > > Andreas > Thanks for the feedback. Here's an updated patch. --------------090005050003050000070909 Content-Type: text/x-patch; name="0001-Add-libtheora-package.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Add-libtheora-package.patch" >From 8b6a37847c8375acabc4c477c773ae768cece29f Mon Sep 17 00:00:00 2001 From: David Thompson Date: Sun, 13 Oct 2013 19:17:27 -0400 Subject: [PATCH] Add libtheora package. --- gnu/packages/oggvorbis.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/oggvorbis.scm b/gnu/packages/oggvorbis.scm index 589828b..00dfc01 100644 --- a/gnu/packages/oggvorbis.scm +++ b/gnu/packages/oggvorbis.scm @@ -80,6 +80,29 @@ polyphonic) audio and music at fixed and variable bitrates from 16 to "See COPYING in the distribution.")) (home-page "http://xiph.org/vorbis/"))) +(define-public libtheora + (package + (name "libtheora") + (version "1.1.1") + (source (origin + (method url-fetch) + (uri (string-append "http://downloads.xiph.org/releases/theora/libtheora-" + version ".tar.xz")) + (sha256 + (base32 + "0q8wark9ribij57dciym5vdikg2464p8q2mgqvfb78ksjh4s8vgk")))) + (build-system gnu-build-system) + (inputs `(("libvorbis" ,libvorbis))) + (propagated-inputs `(("libogg" ,libogg))) + (synopsis "A library implementing the theora video format") + (description + "The libtheora library implements the ogg theora video format, +a fully open, non-proprietary, patent-and-royalty-free, general-purpose +compressed video format.") + (license (license:bsd-style "file://COPYING" + "See COPYING in the distribution.")) + (home-page "http://xiph.org/theora/"))) + (define-public speex (package (name "speex") -- 1.8.4.rc3 --------------090005050003050000070909--