From mboxrd@z Thu Jan 1 00:00:00 1970 From: amirouche@hypermove.net Subject: Re: [PATCH] Add st Date: Wed, 10 Jun 2015 08:28:56 +0200 Message-ID: <501d27da45fc0ce3ba1b29a3787d72df@hypermove.net> References: <7d59986edfeafbf10eeaaada41acee14@hypermove.net> <960301908817217a6148629f683a3f34@hypermove.net> <20150609142210.GA5037@debian> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_786d56c76665ea0b1a61a6be0553cbf8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2ZVX-0003Om-CY for guix-devel@gnu.org; Wed, 10 Jun 2015 02:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2ZVT-0001Mg-BC for guix-devel@gnu.org; Wed, 10 Jun 2015 02:29:03 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:38899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2ZVT-0001MS-1P for guix-devel@gnu.org; Wed, 10 Jun 2015 02:28:59 -0400 In-Reply-To: <20150609142210.GA5037@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org --=_786d56c76665ea0b1a61a6be0553cbf8 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2015-06-09 16:22, Andreas Enge wrote: > Hello, > > thanks for the submission! Just a partial review: > > On Tue, Jun 09, 2015 at 03:07:55PM +0200, amirouche@hypermove.net > wrote: >> + ("font-liberation5" ,font-liberation))) > > Typo? Drop "5" > >> + (description >> + "Xterm is bloated and unmaintainable. It has over 65K lines of >> code and > > Please write a more neutral description. Something like > "St implements a simple and light-weight terminal emulator. It > implements > 256 colors, most VT10X escape sequences, utf8, X11 copy/paste, > antialiased fonts (using fontconfig), fallback fonts, resizing, > and line drawing." > It is nicer to write what a programme does well than to complain about > what others do poorly. Agreed. I created a new patch with the changes you requested and I've run: ./pre-inst-env guix lint st. --=_786d56c76665ea0b1a61a6be0553cbf8 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-add-st.patch Content-Disposition: attachment; filename=0001-gnu-add-st.patch; size=3676 RnJvbSAyNGUzNzRjZDk5YWRiOGVmYzFkNmE5YzViYTBkN2NmYjFmNzE4MjhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBhbXozIDxhbWlyb3VjaGVAaHlwZXJtb3ZlLm5ldD4KRGF0ZTog U3VuLCA3IEp1biAyMDE1IDE5OjA0OjI4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBhZGQg c3QuCgoqIGdudS9wYWNrYWdlcy9kd20uc2NtIChzdCk6IE5ldyB2YXJpYWJsZS4KKiBnbnUvcGFj a2FnZXMvcGF0Y2hlcy9zdC0wLjUtZG8tbm90LWluc3RhbGwtdGVybWluZm8ucGF0Y2g6IE5ldyBm aWxlLgotLS0KIGdudS9wYWNrYWdlcy9kd20uc2NtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgNTAgKysrKysrKysrKysrKysrKysrKysrLQogLi4uL3BhdGNoZXMvc3QtMC41LWRvLW5v dC1pbnN0YWxsLXRlcm1pbmZvLnBhdGNoICAgfCAxMyArKysrKysKIDIgZmlsZXMgY2hhbmdlZCwg NjIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdudS9w YWNrYWdlcy9wYXRjaGVzL3N0LTAuNS1kby1ub3QtaW5zdGFsbC10ZXJtaW5mby5wYXRjaAoKZGlm ZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9kd20uc2NtIGIvZ251L3BhY2thZ2VzL2R3bS5zY20KaW5k ZXggOThmYTEyMi4uOGNlMDc4YiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2R3bS5zY20KKysr IGIvZ251L3BhY2thZ2VzL2R3bS5zY20KQEAgLTIyLDcgKzIyLDExIEBACiAgICM6dXNlLW1vZHVs ZSAoZ3VpeCBkb3dubG9hZCkKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBnbnUp CiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzKQotICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyB4b3JnKSkKKyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgeG9yZykKKyAgIzp1c2Ut bW9kdWxlIChnbnUgcGFja2FnZXMgZm9udHMpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2Vz IG5jdXJzZXMpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBrZy1jb25maWcpCisgICM6 dXNlLW1vZHVsZSAoKGdudSBwYWNrYWdlcyBmb250dXRpbHMpICM6cHJlZml4IGZvbnQtdXRpbHM6 KSkKIAogKGRlZmluZS1wdWJsaWMgZHdtCiAgIChwYWNrYWdlCkBAIC0xMzksMyArMTQzLDQ3IEBA IG51bWJlcnMgb2YgdXNlci1kZWZpbmVkIG1lbnUgaXRlbXMgZWZmaWNpZW50bHkuIikKICAgICAo ZGVzY3JpcHRpb24KICAgICAgIlNpbXBsZSBYIHNlc3Npb24gbG9jayB3aXRoIHRyaXZpYWwgZmVl ZGJhY2sgb24gcGFzc3dvcmQgZW50cnkuIikKICAgICAobGljZW5zZSB4MTEpKSkKKworCisoZGVm aW5lLXB1YmxpYyBzdAorICAocGFja2FnZQorICAgIChuYW1lICJzdCIpCisgICAgKHZlcnNpb24g IjAuNSIpCisgICAgKHNvdXJjZQorICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0 Y2gpCisgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAiaHR0cDovL2RsLnN1Y2tsZXNzLm9yZy9z dC9zdC0iCisgICAgICAgICAgICAgICAgICAgICAgICAgICB2ZXJzaW9uICIudGFyLmd6IikpCisg ICAgICAgKHBhdGNoZXMgKGxpc3QgKHNlYXJjaC1wYXRjaCAic3QtMC41LWRvLW5vdC1pbnN0YWxs LXRlcm1pbmZvLnBhdGNoIikpKQorICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMgorICAg ICAgICAgIjBrbnhwemFhODZwcHJuZzZoYWs4aHg4YncyMnl3MjJycHoxZmZ4anBjdnFsejN4ZHYw NWYiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1l bnRzCisgICAgICcoIzp0ZXN0cz8gI2YgOyBubyB0ZXN0cworICAgICAgICM6bWFrZS1mbGFncyAo bGlzdCAiQ0M9Z2NjIgorICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAi UFJFRklYPSIgJW91dHB1dCkpCisgICAgICAgIzpwaGFzZXMKKyAgICAgICAoYWxpc3QtZGVsZXRl ICdjb25maWd1cmUgJXN0YW5kYXJkLXBoYXNlcykpKQorICAgIChpbnB1dHMKKyAgICAgYCgoImxp YngxMSIgLGxpYngxMSkKKyAgICAgICAoImxpYnhmdCIgLGxpYnhmdCkKKyAgICAgICAoImxpYnhj b21wb3NpdGUiICxsaWJ4Y29tcG9zaXRlKQorICAgICAgICgiY29tcG9zaXRlcHJvdG8iICxjb21w b3NpdGVwcm90bykKKyAgICAgICAoImxpYnhleHQiICxsaWJ4ZXh0KQorICAgICAgICgieGV4dHBy b3RvIiAseGV4dHByb3RvKQorICAgICAgICgibGlieHJlbmRlciIgLGxpYnhyZW5kZXIpCisgICAg ICAgKCJmb250Y29uZmlnIiAsZm9udC11dGlsczpmb250Y29uZmlnKQorICAgICAgICgiZnJlZXR5 cGUiICxmb250LXV0aWxzOmZyZWV0eXBlKQorICAgICAgICgiZm9udC1saWJlcmF0aW9uIiAsZm9u dC1saWJlcmF0aW9uKSkpCisgICAgKG5hdGl2ZS1pbnB1dHMgYCgoInBrZy1jb25maWciICxwa2ct Y29uZmlnKQorICAgICAgICAgICAgICAgICAgICAgKCJuY3Vyc2VzIiAsbmN1cnNlcykpKQorICAg IChob21lLXBhZ2UgImh0dHA6Ly9zdC5zdWNrbGVzcy5vcmcvIikKKyAgICAoc3lub3BzaXMgIlNp bXBsZSB0ZXJtaW5hbCBlbXVsYXRvciIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJYdGVybSBp cyBibG9hdGVkIGFuZCB1bm1haW50YWluYWJsZS4gIEl0IGhhcyBvdmVyIDY1SyBsaW5lcyBvZiBj b2RlIGFuZAorICAgICAgZW11bGF0ZXMgb2JzY3VyZSBhbmQgb2Jzb2xldGUgdGVybWluYWxzIHlv dSB3aWxsIG5ldmVyIG5lZWQuICBUaGUgcG9wdWxhcgorICAgICAgYWx0ZXJuYXRpdmUsIHJ4dnQg aGFzIG9ubHkgMzJLIGxpbmVzIG9mIGNvZGUuICBUaGlzIGlzIGp1c3QgdG9vIG11Y2ggZm9yCisg ICAgICBzb21ldGhpbmcgYXMgc2ltcGxlIGFzIGEgdGVybWluYWwgZW11bGF0b3I7IGl04oCZcyB5 ZXQgYW5vdGhlciBleGFtcGxlIG9mCisgICAgICBjb2RlIGNvbXBsZXhpdHkuICBzdCBmaXggdGhh dC4iKQorICAgIChsaWNlbnNlIHgxMSkpKQpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3BhdGNo ZXMvc3QtMC41LWRvLW5vdC1pbnN0YWxsLXRlcm1pbmZvLnBhdGNoIGIvZ251L3BhY2thZ2VzL3Bh dGNoZXMvc3QtMC41LWRvLW5vdC1pbnN0YWxsLXRlcm1pbmZvLnBhdGNoCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLjA4OWM0MjMKLS0tIC9kZXYvbnVsbAorKysgYi9nbnUvcGFj a2FnZXMvcGF0Y2hlcy9zdC0wLjUtZG8tbm90LWluc3RhbGwtdGVybWluZm8ucGF0Y2gKQEAgLTAs MCArMSwxMyBAQAorZGlmZiAtLWdpdCBhL01ha2VmaWxlIGIvTWFrZWZpbGUKK2luZGV4IDYxNThh YjIuLjkzY2I2ODQgMTAwNjQ0CistLS0gYS9NYWtlZmlsZQorKysrIGIvTWFrZWZpbGUKK0BAIC00 OCw4ICs0OCw2IEBAIGluc3RhbGw6IGFsbAorIAlAbWtkaXIgLXAgJHtERVNURElSfSR7TUFOUFJF RklYfS9tYW4xCisgCUBzZWQgInMvVkVSU0lPTi8ke1ZFUlNJT059L2ciIDwgc3QuMSA+ICR7REVT VERJUn0ke01BTlBSRUZJWH0vbWFuMS9zdC4xCisgCUBjaG1vZCA2NDQgJHtERVNURElSfSR7TUFO UFJFRklYfS9tYW4xL3N0LjEKKy0JQGVjaG8gUGxlYXNlIHNlZSB0aGUgUkVBRE1FIGZpbGUgcmVn YXJkaW5nIHRoZSB0ZXJtaW5mbyBlbnRyeSBvZiBzdC4KKy0JQHRpYyAtcyBzdC5pbmZvCisgCisg dW5pbnN0YWxsOgorIAlAZWNobyByZW1vdmluZyBleGVjdXRhYmxlIGZpbGUgZnJvbSAke0RFU1RE SVJ9JHtQUkVGSVh9L2JpbgotLSAKMi4yLjEKCg== --=_786d56c76665ea0b1a61a6be0553cbf8--