From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH] gnu: Add dlib. Date: Wed, 17 Aug 2016 15:01:24 +1000 Message-ID: <4e2f9e6e-e232-9f49-7c25-92a11d3d848a@uq.edu.au> References: <87twengmbh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87a8gexyrz.fsf@gmail.com> <87oa4ugsi4.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160815201528.GA23963@jasmine> <87a8gd22ug.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160815222840.GA10735@jasmine> <4752bc68-5466-6c26-a7b4-e53aec400ff5@uq.edu.au> <8760r10z7n.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160816204736.GA25753@jasmine> <993034f9-ceae-525f-01b9-0b8af7a5aafe@uq.edu.au> <20160816234507.GA24224@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZsyv-0002Qx-ES for guix-devel@gnu.org; Wed, 17 Aug 2016 01:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZsys-0004HC-Ah for guix-devel@gnu.org; Wed, 17 Aug 2016 01:01:37 -0400 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:44035 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZsyr-0004H5-Me for guix-devel@gnu.org; Wed, 17 Aug 2016 01:01:34 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel , Alex Kost On 17/08/16 13:24, Ben Woodcroft wrote: > > > On 17/08/16 09:45, Leo Famulari wrote: >> On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote: >>> >>> On 17/08/16 06:47, Leo Famulari wrote: >>>> On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: >>>>> I initially made this package on a foreign distro without "lapack" in >>>>> inputs and have verified that dropping LAPACK makes the tests pass. >>>>> >>>>> I also found some other optional dependencies after digging around >>>>> the >>>>> source, as well as a recommendation to disable/enable asserts: >>>>> >>>>> http://dlib.net/dlib/config.h.html >>>>> >>>>> Ben, Leo: Can you try the following patch and see if that works >>>>> for you? >>>> Yes, this patch builds for me. >>> Me too, although it appeared non-deterministic. I'm afraid I haven't >>> time to >>> see if this patch is suitable to push just now. Leo? >> How did it appear non-deterministic to you? > Just based on guix build --check: > > guix build: error: build failed: derivation > `/gnu/store/sxybcxw64q1ajzq6dysal75ffgq6238i-dlib-19.1.drv' may not be > deterministic: output > `/gnu/store/il57dcii4pzii11zlixjjxxxw699bg5x-dlib-19.1' differs > > I'm actually not sure, why does it say "may not be deterministic"? If > it builds twice and the second version is different, doesn't that mean > it is definitely not deterministic by counter-example, unless there > has been some leakage into the build container? > > I also tried building it with #parallel-build? #f and #parallel-tests? > #f. It worked in the first round but failed the second. I wasn't clear here. This was with lapack uncommented out. Subsequently I tested with both these flags #f and lapack commented out, then it was deterministic with --rounds=2. Let me know if you want any further testing done.