From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 55Z8N/Ova2ILeQAAbAwnHQ (envelope-from ) for ; Fri, 29 Apr 2022 11:29:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yPmANfOva2JJewEAG6o9tA (envelope-from ) for ; Fri, 29 Apr 2022 11:29:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A575A1E1E7 for ; Fri, 29 Apr 2022 11:29:23 +0200 (CEST) Received: from localhost ([::1]:59660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkMwE-0001ob-FV for larch@yhetil.org; Fri, 29 Apr 2022 05:29:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkMua-0000GK-Ft for guix-devel@gnu.org; Fri, 29 Apr 2022 05:27:40 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:60692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkMuX-0005Lb-OK for guix-devel@gnu.org; Fri, 29 Apr 2022 05:27:39 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id QZTZ270064UW6Th01ZTZx1; Fri, 29 Apr 2022 11:27:33 +0200 Message-ID: <43be80d161b85330aebab5da7de527c1e4670557.camel@telenet.be> Subject: Re: The case for moving raw binaries From: Maxime Devos To: Liliana Marie Prikler , guix-devel@gnu.org Date: Fri, 29 Apr 2022 11:27:27 +0200 In-Reply-To: References: <615054d08116af35720a08a6fdb836e84cf0e873.camel@gmail.com> <65282c9d3d91b215499ab792604e11d0127e5215.camel@telenet.be> <228ccb21e58b37a659568787af29adaa69d39c2e.camel@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-n4gDKh5ac0Q/hUiFqWIw" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1651224453; bh=SAFZ1PEGGiWgBJPeGceCZUl+N0LJWJPH1qtDZF1aBuk=; h=Subject:From:To:Date:In-Reply-To:References; b=S6kKKn8TMZaT8xA4MEGhKXr/wUXj/HDmpwB0bW/rYuzKvGOEkjpTrLVUO6LTVpYLA +C4GYzxGMvrzBUjYNTbxNGncEoEEZ3X1NN57UueSqp39hnRyjUQ03WbXuyWbqY24kE L10bcP/7ZCF/65PIzemkhS/8/NbAZyGhrFeWQa1dnxiz+M2EmeDYJBQ6EiZMGcAkn5 LtOwOkSBOzMOVDirEDFWgBFdMHkUhm8OXg04jKgjrlqGmobyhL//9+d4H6l0gywKxZ JZjseONVPNWWZaBctwj3ihuPwCecCz56/uc5TlptfX7cr2jOfK03GzeX9aMnsddg6J 0D9WC9OqPyKdg== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651224563; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SAFZ1PEGGiWgBJPeGceCZUl+N0LJWJPH1qtDZF1aBuk=; b=m4B8+YMfBCFEUYuBKx2rpq0D+cCi85uIz0kjU5/aZcaiTJop5b42/sCFikkXPdA5DiR8UX 85K3HDNw9VEok888B8WOenZGGaVXuR1E9Qn+C+F/p6/mkcWYp0TbWabr2BoNVYy+ffZw4h XGWtOD6Jfjb0LfLEGJV9bmE+c9CO1i6RZ3hbYfDhAr8zZT74ymIxJs6zcwled9Oi2cGYvG Dl59+HaQNwFnQajftFGAvix3c7gNHfgZrS06oko5NojAsfQ6UxNwF8LMdszXAeb0sVNCe/ o7W6xH2SVtREF2qiR75V5opJDgL6Dz+YkI1VxANdp+D4qFQShf96fUUStrtDzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651224563; a=rsa-sha256; cv=none; b=DEV8br0trxbuqlhqXPv32ySM1X44n8wNmD9VhbnbpQ56cD9uZKdaW0fRDFdDx3rpKauPNi 9Z7NrolVAM21loULfxR98F8gb6p4l5Bn6Lm0uLj5OnwEQqikzqeA60AxFlGfTxLQHhhEkX YCYgIlwjsSuZH975PRJXTRjIlom9h7rqLZqi7utkFA1BRzdl/L5wFs/R6ppqlG+kt9y7mR eA9H7YUr+At+B6IJj0jPZktE1DGeKNULEtem1zP7fZ41bzUTEH50hy0nskmULVF1Sn5CkE pOuHTDPhHi5EHR/Z8UQtsYxF+THhYXCPs8JF6DoJuO/OCwsJcpzSybN1bxbGKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r22 header.b=S6kKKn8T; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.20 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r22 header.b=S6kKKn8T; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A575A1E1E7 X-Spam-Score: -6.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: mzBn0ky13yJR --=-n4gDKh5ac0Q/hUiFqWIw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler schreef op vr 29-04-2022 om 06:13 [+0200]: > The extra wrapping isn't cancelled though?=C2=A0 You just append the > definition of $Y to the the already existing definitions, but you don't > move the wrapper to $RAWBIN_DIR, because the actual binary already > exists there. As I understood it, the suggestion was to cancel wrapping if there's already things in $RAWBIN_DIR. > In other words, you have after wrap: > - bin/foo ~> rawbin/foo > and after wrap-again > - bin/foo ~> rawbin/foo > where ~> is the wrapping relation. >=20 > Currently, you have after one wrap > - bin/foo ~> bin/.foo-real > after two > - bin/foo ~> bin/.foo-real > - bin/.foo-real ~> bin/..foo-real-real > after three > - bin/foo ~> bin/.foo-real > - bin/.foo-real ~> bin/..foo-real-real > - bin/..foo-real-real ~> bin/...foo-real-real-real > and so on. >=20 > Is this clearer now? I thought that (if already-wrapped? ;; PROG is already a wrapper: add the new "export VAR=3DVALUE" ;; lines just before the last line. [...]) in 'wrap-program' would avoid creating ..foo-real-real? Also, doesn't 'wrap-program' refuse to wrap .foo-real: (when (wrapped-program? prog) (error (string-append prog " is a wrapper. Refusing to wrap."))) so ..foo-real-real shouldn't be created in the first place? Do you have a concrete example in which ..foo-real-real happens? That said, the proposed new behaviour seems reasonable to me -- "pidof emacs" would then actually find Emacs. Greetings, Maxime. --=-n4gDKh5ac0Q/hUiFqWIw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmuvfxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7h38AP9EKo5X/E8Ad1e3sAmaI5IVYgaY rYygtG/fTa4TVfJoYAD/RUFqn5n+Q2JPUo1fA4LSwXLjIQ63U0sKjCd6ikXizwc= =2zYM -----END PGP SIGNATURE----- --=-n4gDKh5ac0Q/hUiFqWIw--