unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, guix-devel@gnu.org
Subject: Re: The case for moving raw binaries
Date: Fri, 29 Apr 2022 11:27:27 +0200	[thread overview]
Message-ID: <43be80d161b85330aebab5da7de527c1e4670557.camel@telenet.be> (raw)
In-Reply-To: <d342833f5f1fdf9f5940ae7f5449ad25d6db2612.camel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

Liliana Marie Prikler schreef op vr 29-04-2022 om 06:13 [+0200]:
> The extra wrapping isn't cancelled though?  You just append the
> definition of $Y to the the already existing definitions, but you don't
> move the wrapper to $RAWBIN_DIR, because the actual binary already
> exists there.

As I understood it, the suggestion was to cancel wrapping if there's
already things in $RAWBIN_DIR.

> In other words, you have after wrap:
> - bin/foo ~> rawbin/foo
> and after wrap-again
> - bin/foo ~> rawbin/foo
> where ~> is the wrapping relation.
> 
> Currently, you have after one wrap
> - bin/foo ~> bin/.foo-real
> after two
> - bin/foo ~> bin/.foo-real
> - bin/.foo-real ~> bin/..foo-real-real
> after three
> - bin/foo ~> bin/.foo-real
> - bin/.foo-real ~> bin/..foo-real-real
> - bin/..foo-real-real ~> bin/...foo-real-real-real
> and so on.
> 
> Is this clearer now?

I thought that

  (if already-wrapped?
      ;; PROG is already a wrapper: add the new "export VAR=VALUE"
      ;; lines just before the last line.
      [...])

in 'wrap-program' would avoid creating ..foo-real-real?

Also, doesn't 'wrap-program' refuse to wrap .foo-real:

  (when (wrapped-program? prog)
    (error (string-append prog " is a wrapper. Refusing to wrap.")))

so ..foo-real-real shouldn't be created in the first place?
Do you have a concrete example in which ..foo-real-real happens?

That said, the proposed new behaviour seems reasonable to me -- "pidof
emacs" would then actually find Emacs.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-04-29  9:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 16:37 The case for moving raw binaries Liliana Marie Prikler
2022-04-28 16:50 ` Maxime Devos
2022-04-28 16:55 ` Maxime Devos
2022-04-28 17:27   ` Liliana Marie Prikler
2022-04-28 19:57     ` Maxime Devos
2022-04-28 22:52       ` raingloom
2022-04-29  9:39         ` Maxime Devos
2022-04-29  4:13       ` Liliana Marie Prikler
2022-04-29  9:27         ` Maxime Devos [this message]
2022-04-29 16:59           ` Liliana Marie Prikler
2022-07-29 21:20             ` Philip McGrath
2022-07-30  6:11               ` Liliana Marie Prikler
2022-08-04  8:54                 ` Ludovic Courtès
2022-08-04 16:53                   ` Liliana Marie Prikler
2022-04-29  9:18 ` zimoun
2022-05-23 15:10 ` Ludovic Courtès
2022-05-23 16:03   ` Maxime Devos
2022-05-23 16:37   ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43be80d161b85330aebab5da7de527c1e4670557.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=guix-devel@gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).