From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH] gnu: Add git-review.
Date: Thu, 8 Sep 2016 22:28:37 +1000
Message-ID: <439770f1-4691-45ac-348e-9e41bc126e0d@uq.edu.au>
References: <20160908070630.18458-1-clement@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bhyRq-0008E7-OW
	for guix-devel@gnu.org; Thu, 08 Sep 2016 08:28:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bhyRn-00010F-0c
	for guix-devel@gnu.org; Thu, 08 Sep 2016 08:28:54 -0400
Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:42463
	helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bhyRm-000101-DR
	for guix-devel@gnu.org; Thu, 08 Sep 2016 08:28:50 -0400
In-Reply-To: <20160908070630.18458-1-clement@lassieur.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Cl=c3=a9ment_Lassieur?= <clement@lassieur.org>, guix-devel@gnu.org

Hi there, thanks for the patch. I do not have any experience with Gerrit=20
but some comments below:


On 08/09/16 17:06, Cl=C3=A9ment Lassieur wrote:
> [..]
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://pypi.python.org/packages/source/g/git-review/git=
-review-"
> +             version ".tar.gz"))

Rather: (uri (pypi-uri "git-review" version))

> +       (sha256
> +        (base32
> +         "07d1jn9ryff5j5ic6qj5pbk10m1ccmpllj0wyalrcms1q9yhlzh8"))))
> +    (build-system python-build-system)
> +    (arguments `(#:tests? #f)) ; tests require a running Gerrit server
> +    (native-inputs
> +     `(("python-pbr" ,python-pbr)))
> +    (inputs
> +     `(("python-requests" ,python-requests)
> +       ("git" ,git)))

I think including git simply as an input is problematic because=20
git-review calls git via 'subprocess', as evidenced by

$ ./pre-inst-env guix environment -C --ad-hoc git-review
$ git-review
[..]
   File=20
"/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/s=
ubprocess.py",=20
line 1457, in _execute_child
     raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'git'

So, I think we need to patch the source code to call the full path to=20
git, or otherwise wrap the 'git-review' executable.

> +    (home-page "http://docs.openstack.org/infra/git-review/")
> +    (synopsis "Command-line tool for Gerrit")
> +    (description
> +     "Git-review is a command-line tool that helps submitting Git bran=
ches to
> +Gerrit for review, or fetching existing ones.")
> +    (license asl2.0)))
Otherwise seems OK to me. Can you test with environment -C -N?
ben