From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Castillo <castilma@uni-bremen.de>
Subject: Re: [WIP][PATCH] profiles: info-dir-file: Don't consider unwanted
	manifest entries
Date: Fri, 15 Dec 2017 16:40:33 +0100
Message-ID: <430063d5-8e7f-739a-74f4-5b9fddf01c7f@uni-bremen.de>
References: <87ind8ja9h.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <castilma@uni-bremen.de>) id 1ePs6S-0008E8-Au
	for guix-devel@gnu.org; Fri, 15 Dec 2017 10:40:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <castilma@uni-bremen.de>) id 1ePs6N-0007Qe-Cc
	for guix-devel@gnu.org; Fri, 15 Dec 2017 10:40:48 -0500
Received: from gabriel-vm-2.zfn.uni-bremen.de ([134.102.50.10]:54970
	helo=smtp.uni-bremen.de)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <castilma@uni-bremen.de>)
	id 1ePs6N-0007EZ-2V
	for guix-devel@gnu.org; Fri, 15 Dec 2017 10:40:43 -0500
In-Reply-To: <87ind8ja9h.fsf@member.fsf.org>
Content-Language: en-US
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?UTF-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>, guix-devel@gnu.org

Hi,

in the second patch file:
> +  ;; We only need to build the 'dir' file for inputs that does
containing info
> +  ;; manuals.
s/containing/contain

On 15.12.2017 16:12, =E5=AE=8B=E6=96=87=E6=AD=A6 wrote:> Hello!
>
> Currently we run profile hooks for all manifest inputs, so if you
> install a new package to your profile, all profile hooks will be run
> again, even if the new package doesn't provide info manuals, man pages,
> etc.  Ideally only interested hooks need to be run, eg: if the new
> package has info manuals, then the 'info-dir-file' hook will run.

One would need to filter man-pages too, right?
+ (define interested
+    (eval-gexp
+     #~(filter
+        (lambda (input)
+          (or (file-exists? (string-append input "/share/info"))
+              (file-exists? (string-append input "/share/man"))))
+        '#$(manifest-inputs manifest))))

>
> I get it works somehow, but breaks the '--dry-run' functionality which =
I
> have no idea how to preserve...
>
>
>
>
>
> Needing help and directions, thanks!
>

I can barely write scheme. I can't help much, sorry.

Martin

--=20
GPG: 7FDE 7190 2F73 2C50 236E  403D CC13 48F1 E644 08EC