unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Martin Castillo <castilma@uni-bremen.de>
To: 宋文武 <iyzsong@member.fsf.org>, guix-devel@gnu.org
Subject: Re: [WIP][PATCH] profiles: info-dir-file: Don't consider unwanted manifest entries
Date: Fri, 15 Dec 2017 16:40:33 +0100	[thread overview]
Message-ID: <430063d5-8e7f-739a-74f4-5b9fddf01c7f@uni-bremen.de> (raw)
In-Reply-To: <87ind8ja9h.fsf@member.fsf.org>

Hi,

in the second patch file:
> +  ;; We only need to build the 'dir' file for inputs that does
containing info
> +  ;; manuals.
s/containing/contain

On 15.12.2017 16:12, 宋文武 wrote:> Hello!
>
> Currently we run profile hooks for all manifest inputs, so if you
> install a new package to your profile, all profile hooks will be run
> again, even if the new package doesn't provide info manuals, man pages,
> etc.  Ideally only interested hooks need to be run, eg: if the new
> package has info manuals, then the 'info-dir-file' hook will run.

One would need to filter man-pages too, right?
+ (define interested
+    (eval-gexp
+     #~(filter
+        (lambda (input)
+          (or (file-exists? (string-append input "/share/info"))
+              (file-exists? (string-append input "/share/man"))))
+        '#$(manifest-inputs manifest))))

>
> I get it works somehow, but breaks the '--dry-run' functionality which I
> have no idea how to preserve...
>
>
>
>
>
> Needing help and directions, thanks!
>

I can barely write scheme. I can't help much, sorry.

Martin

-- 
GPG: 7FDE 7190 2F73 2C50 236E  403D CC13 48F1 E644 08EC

  reply	other threads:[~2017-12-15 15:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 15:12 [WIP][PATCH] profiles: info-dir-file: Don't consider unwanted manifest entries 宋文武
2017-12-15 15:40 ` Martin Castillo [this message]
2017-12-22 11:21   ` 宋文武
2017-12-18  9:28 ` Ludovic Courtès
2018-01-01 10:37   ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=430063d5-8e7f-739a-74f4-5b9fddf01c7f@uni-bremen.de \
    --to=castilma@uni-bremen.de \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).