From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +JxkAffH7F9SEQAA0tVLHw (envelope-from ) for ; Wed, 30 Dec 2020 18:33:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cAnQOPbH7F9FUQAAB5/wlQ (envelope-from ) for ; Wed, 30 Dec 2020 18:33:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E3CF940276 for ; Wed, 30 Dec 2020 18:33:26 +0000 (UTC) Received: from localhost ([::1]:59834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kugHl-0002i2-FT for larch@yhetil.org; Wed, 30 Dec 2020 13:33:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kugHP-0002ht-IT for guix-devel@gnu.org; Wed, 30 Dec 2020 13:33:03 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:30020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kugHM-0001kL-61 for guix-devel@gnu.org; Wed, 30 Dec 2020 13:33:02 -0500 Received: from nijino.local (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4D5fzS6zdfz1LBRx; Wed, 30 Dec 2020 19:32:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4D5fzS6zdfz1LBRx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1609353173; bh=DnkglAH5mihSG02KLpJPGeH1atzfPytwQnCt+t2PIPY=; h=Subject:From:To:Cc:Date:In-Reply-To:From; b=Vl7N6c/guZwXvpj9x932+EyzFCi9XgCzVMJhR2i4VPWi/ciCFbbAamFYQIN+OLTJ4 D81x5TvOlXJTsEPljr9KztTSUjRHnodAS4qIuXHhsBbSOcwV5pU7RgQzWJKUjfeP42 GblU1C8VkWgF8shhDP5dvWgkQfl+v6P6alvbi4kw= Message-ID: <424245f9f30e2418942a8eec27019864294550cd.camel@student.tugraz.at> Subject: [RFC] Package of Nomacs From: Leo Prikler To: rovanion.luckey@gmail.com Date: Wed, 30 Dec 2020 19:32:52 +0100 In-Reply-To: CAAaf0CCYv10Hr6caP_TCHUOoRS=BODVGsPc=eunNY4hs=W9-qQ@mail.gmail.com Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.03 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tugraz.at header.s=mailrelay header.b=Vl7N6c/g; dmarc=pass (policy=none) header.from=student.tugraz.at; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 7E3CF940276 X-Spam-Score: -3.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: BrWMNce8on2/ Hi rovanion, > (define-module (nomacs) The nomacs package should probably go to gnu/packages/image- viewers.scm. > (source (origin > (method url-fetch) > (uri (string-append " > https://codeload.github.com/nomacs/nomacs/tar.gz/" version)) > (sha256 > "0z113mfxxdy3wafh0g1xxxwsc5qg0n42r4345c6rxvr6h02fkixv"))) Use git-fetch instead and don't recurse into submodules. You will likely encounter some errors, because it doesn't seem as though nomacs expects you to have its inputs properly packages. *sigh* > `(#:configure-flags (list "-DENABLE_TRANSLATIONS=true" > "-DUSE_SYSTEM_QUAZIP=true" > (string-append "../nomacs-" ,version > "/ImageLounge")) Instead of adding the path to the source directory, try `(cd "ImageLounge")` in a phase after 'unpack. > (inputs `(("python" ,python-wrapper) > ("qtbase" ,qtbase) > ("qtlinguist" ,qttools) > ("qtsvg" ,qtsvg) > ("exiv2" ,exiv2) > ("libtiff" ,libtiff) > ("opencv" ,opencv) > ("libraw" ,libraw) > ("quazip" ,quazip))) Try to sort them alphabetically, also don't put too much effort into making the tails align. > (description "Nomacs is a free, open source image viewer, which > supports multiple platforms. You can use it for viewing all common > image formats including RAW and psd images. > > Nomacs features semi-transparent widgets that display additional > information such as thumbnails, metadata or histogram. It is able to > browse images in zip or MS Office files which can be extracted to a > directory. Metadata stored with the image can be displayed and you > can add notes to images. A thumbnail preview of the current folder is > included as well as a file explorer panel which allows switching > between folders. Within a directory you can apply a file filter, so > that only images are displayed whose filenames have a certain string > or match a regular expression. Activating the cache allows for > instantly switching between images. > > Nomacs includes image manipulation methods for adjusting brightness, > contrast, saturation, hue, gamma, exposure. It has a pseudo color > function which allows creating false color images. A unique feature > of Nomacs is the synchronization of multiple instances. With this > feature you can easily compare images by zooming and/or panning at > the exactly same position or even by overlaying them with different > opacity. > Nomacs is licensed under the GNU General Public License v3 and > available for Windows, Linux, FreeBSD, Mac, and OS/2.") fill-column is at 78. Also try to shorten this text and use double spaces (" ") between sentences. > (license gpl3) It is actually gpl3+ according to license/README.md. > One thing that's missing is the plugins that are developed in a > separate git repository [0] and not included in the source tarballs > of the main repository [1]. Ideas on how to make them available in > the `plugins` directory during build time are welcome. A trick that's often used in Guix is (inputs `(("extra-source-package" ,(origin ...))) [other inputs]) You can then (copy-recursively (assoc-ref inputs "extra-source- package") destination) in a phase between 'unpack and 'configure. Regards, Leo