From: julien lepiller <julien@lepiller.eu>
To: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add lmms
Date: Thu, 23 Feb 2017 10:15:47 +0100 [thread overview]
Message-ID: <412b9673cde38582067020f679ca9e70@lepiller.eu> (raw)
In-Reply-To: <cf9e6dcd20e31382439f5d8bc7e12341@openmailbox.org>
Le 2017-02-23 00:18, Rodger Fox a écrit :
> Here is another package. I think I got the commit message right this
> time. Let me know if I missed anything.
Hi!
I wanted to try this software for while now, so you're great :)
I added some comments on your patch below:
> From 8e2757bee584f4686e02da512662fb512b05c037 Mon Sep 17 00:00:00 2001
> From: Rodger Fox <thylakoid@openmailbox.org>
> Date: Wed, 22 Feb 2017 15:08:30 -0800
> Subject: [PATCH] gnu: Add lmms. * gnu/packages/music.scm (lmms): New
> variable.
The message is correct, but it lacks returns between "Add lmms." and "*
gnu/packages". Have a look at git log for some examples.
> + (sha256
> + (base32
> + "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"))))
There's a tab in the indentation, please use spaces.
> + (build-system cmake-build-system)
> + (arguments `(#:tests? #f ; No tests to run.
> + #:validate-runpath? #f))
There's a tab here too, and it should rather look like this:
(arguments
`(#:tests? #f
#:validate-runpath? #f))
Why do you need to disable runpath validation?
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
Indentation is off by one (inputs should be aligned with native-inputs).
> + (description "LMMS is a digital audio workstation. It includes
> tools for sequencing melodies and beats and for mixing and arranging
> songs. It includes instruments based on audio samples and various soft
> sythesizers. It can receive input from a MIDI keyboard.")
This line is way too long, please break it. Also please use two spaces
between sentences.
> + (license license:gpl2+)))
> --
> 2.11.1
Ok, this is my first review, I tried to get it right but I probably
forgot something (I still can't get my own patches right on the first
try :p). Running "guix lint lmms" would have saved you the last comment
;). I can't try it now, but I'll test your patch (or an updated version)
this evening.
next prev parent reply other threads:[~2017-02-23 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 23:18 [PATCH] gnu: Add lmms Rodger Fox
2017-02-23 9:15 ` julien lepiller [this message]
2017-02-23 11:30 ` ng0
[not found] <mailman.54228.1487857637.22740.guix-devel@gnu.org>
2017-02-23 16:38 ` Rodger Fox
-- strict thread matches above, loose matches on Subject: below --
2017-02-23 18:13 Rodger Fox
2017-02-24 10:56 ` Julien Lepiller
2017-03-09 4:47 Rodger Fox
2017-03-15 22:03 ` Leo Famulari
2017-03-17 5:54 ` Rodger Fox
2017-03-21 19:20 ` Leo Famulari
2017-03-21 19:39 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412b9673cde38582067020f679ca9e70@lepiller.eu \
--to=julien@lepiller.eu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).