unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add php-hello-world.
@ 2016-12-08 17:45 Hartmut Goebel
  2016-12-08 17:47 ` Hartmut Goebel
  2016-12-08 17:52 ` [WIP 0/2] php-fpm service - assistance appreciated Hartmut Goebel
  0 siblings, 2 replies; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-08 17:45 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/php.scm (php-hello-world): New variable.
---
 gnu/packages/php.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 9ccbede..f860f88 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Julien Lepiller <julien@lepiller.eu>
 ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -48,6 +49,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system trivial)
   #:use-module ((guix licenses) #:prefix license:))
 
 ;; This fixes PHP bugs 73155 and 73159. Remove when gd
@@ -332,3 +334,38 @@ systems, web content management systems and web frameworks." )
               license:lgpl2.1+                              ; ext/bcmath/libbcmath
               license:bsd-2                                 ; ext/fileinfo/libmagic
               license:expat))))                             ; ext/date/lib
+
+(define-public php-hello-world
+  (package
+    (name "php-hello-world")
+    (version "0.1")
+    (source #f)
+    (build-system trivial-build-system)
+    (arguments
+     `(#:modules ((guix build utils))
+       #:builder
+       (begin
+         (use-modules (guix build utils))
+         (let* ((out       (assoc-ref %outputs "out"))
+                (php       (assoc-ref %build-inputs "php"))
+                (index.php (string-append out "/index.php")))
+           (mkdir-p out)
+           (call-with-output-file index.php
+             (lambda (p)
+               (format p "<html>
+ <head><title>PHP test page: Hello, Guix!</title></head>
+ <body>
+ <?php echo '<h1>Hello, Guix!</h1>'; ?>
+ <p>Today is: <?php echo date('Y-m-d'); ?></p>
+ </body>
+</html>~%")))
+           (chmod index.php #o555)))))
+    (inputs
+     `(("php" ,php)))
+    (synopsis "Hello, PHP world: An example PHP package")
+    (description
+     "PHP Hello World creates a simple HTML page saying \"Hello, Guix!\" and
+the current date.  It serves as an example to be used in Guix PHP packages or
+services.")
+    (home-page "http://php.net/manual/en/tutorial.firstpage.php")
+    (license license:gpl3+)))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-08 17:45 [PATCH] gnu: Add php-hello-world Hartmut Goebel
@ 2016-12-08 17:47 ` Hartmut Goebel
  2016-12-21 16:38   ` Ludovic Courtès
  2016-12-08 17:52 ` [WIP 0/2] php-fpm service - assistance appreciated Hartmut Goebel
  1 sibling, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-08 17:47 UTC (permalink / raw)
  To: guix-devel

Am 08.12.2016 um 18:45 schrieb Hartmut Goebel:
> * gnu/packages/php.scm (php-hello-world): New variable.

This is useful for testing setups and providing examples.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [WIP 0/2] php-fpm service - assistance appreciated
  2016-12-08 17:45 [PATCH] gnu: Add php-hello-world Hartmut Goebel
  2016-12-08 17:47 ` Hartmut Goebel
@ 2016-12-08 17:52 ` Hartmut Goebel
  2016-12-08 17:52   ` [WIP 1/2] services: Add php-fpm service Hartmut Goebel
  2016-12-08 17:52   ` [WIP 2/2] gnu: Add "PHP FPM" OS config example Hartmut Goebel
  1 sibling, 2 replies; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-08 17:52 UTC (permalink / raw)
  To: guix-devel

This is a draft for a PHP FastCGI service behind nginx.

There are some issues I could not solve:

In the service definition:

* Configuration requires two files. How can I pass both to php-fpm-activation?

* How to refer to the systems timezone settings in a configuration?
  (see php-ini -> date.timezone)

* How to make a configuration parameter default to the value passed to another
  parameter (e.g. upload-max-filesize should default to the value given for
  post-max-size).

In the sample system configuration:

* How to pass the nginx and php package directories to "string-append"
  (see http://lists.gnu.org/archive/html/help-guix/2016-12/msg00023.html)

Hartmut Goebel (3):
  services: Add php-fpm service.
  gnu: Add "PHP FPM" OS config example.

-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [WIP 1/2] services: Add php-fpm service.
  2016-12-08 17:52 ` [WIP 0/2] php-fpm service - assistance appreciated Hartmut Goebel
@ 2016-12-08 17:52   ` Hartmut Goebel
  2016-12-08 17:52   ` [WIP 2/2] gnu: Add "PHP FPM" OS config example Hartmut Goebel
  1 sibling, 0 replies; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-08 17:52 UTC (permalink / raw)
  To: guix-devel

* gnu/services/php.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk         |   1 +
 gnu/services/php.scm | 568 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 569 insertions(+)
 create mode 100644 gnu/services/php.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index eec0e01..a42f6cd 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -413,6 +413,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/services/mcron.scm			\
   %D%/services/networking.scm			\
   %D%/services/nfs.scm			\
+  %D%/services/php.scm				\
   %D%/services/shepherd.scm			\
   %D%/services/herd.scm				\
   %D%/services/sddm.scm				\
diff --git a/gnu/services/php.scm b/gnu/services/php.scm
new file mode 100644
index 0000000..e45b54f
--- /dev/null
+++ b/gnu/services/php.scm
@@ -0,0 +1,568 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+;;;
+;;; Some of the help text was taken from the default php-fpm.conf files.
+
+(define-module (gnu services php)
+  #:use-module (gnu services)
+  #:use-module (gnu services base)
+  #:use-module (gnu services configuration)
+  #:use-module (gnu services shepherd)
+  #:use-module (gnu system shadow)
+  #:use-module (gnu packages php)
+  #:use-module (guix records)
+  #:use-module (guix packages)
+  #:use-module (guix gexp)
+  #:use-module (ice-9 match)
+  #:use-module (ice-9 regex) ;; for uglify-field-name
+  #:export (php-fpm-service
+            php-ini
+            php-fpm-configuration
+            php-fpm-pool))
+
+(define (uglify-field-name field-name)
+  (let ((str (symbol->string field-name)))
+    (if (string-suffix? "?" str)
+        (substring str 0 (1- (string-length str)))
+        (regexp-substitute/global #f "-"  str 'pre "_" 'post))))
+(define (serialize-field field-name val)
+  (format #t "~a = ~a\n" (uglify-field-name field-name) val))
+
+(define (serialize-string field-name val)
+  (serialize-field field-name val))
+
+(define (serialize-space-separated-string-list field-name val)
+  (serialize-field field-name (string-join val " ")))
+
+(define (serialize-boolean field-name val)
+  (serialize-string field-name (if val "on" "off")))
+
+(define (non-negative-integer? val)
+  (and (exact-integer? val) (not (negative? val))))
+(define (serialize-non-negative-integer field-name val)
+  (serialize-field field-name val))
+
+(define (optional-string? val)
+  (or (and (boolean? val) (not val)) (string? val)))
+(define (serialize-optional-string field-name val)
+  (when (not (boolean? val))
+        (serialize-field field-name val)))
+
+(define (section? val) #t)
+(define (serialize-section field-name val)
+  (format #t "\n[~a]\n" val))
+
+(define (production? val)
+  (boolean? val))
+(define (serialize-production field-name val)
+  (serialize-boolean 'display-errors (not val))
+  (serialize-boolean 'display-startup-errors (not val))
+  (serialize-boolean 'track-errors (not val))
+  (serialize-string  'error-reporting
+                     (if val "E_ALL & ~E_DEPRECATED & ~E_STRICT" 
+                             "E_ALL")))
+
+(define (pools-list? val)
+  (and (list? val) (and-map php-fpm-pool? val)))
+(define (serialize-pools-list field-name val)
+  (for-each (lambda (val) (serialize-php-fpm-pool field-name val)) val))
+
+(define (serialize-php-fpm-pool field-name val)
+  (format #t "\n\n; Start a new pool.")
+  (serialize-configuration val php-fpm-pool-fields))
+
+;;; ---- php.ini ---
+
+(define-configuration php-ini
+  (php
+   (package php)
+   "The php package to use.")
+
+  (PHP (section "PHP") "The global options section")
+
+  (production
+   (production #t)
+   "This variable determines if the @file{php.ini} configuration
+will be configured towards 'production' systems (don't display
+errors), or 'development' systems (display all errors).")
+
+ (max-execution-time
+  (non-negative-integer 30)
+  "Specify default maximum execution time, in seconds.")
+
+ (max-input-time
+  (non-negative-integer 60)
+  "Specify default maximum input time, in seconds.")
+
+ (memory-limit 
+  (string "128M")
+  "Specify maximum memory limit for PHP processes, in megabytes.")
+
+ (post-max-size 
+  (string "8M")
+  "Specify maximum size of the POST data, in megabytes.")
+
+ (file-uploads 
+  (boolean #t)
+  "Enable or disable file uploading in PHP applications.")
+
+ (upload-max-filesize 
+  (string "8M") ;; TODO default to what has been passed to post-max-size
+  "Specify maximum size of uploaded files, in megabytes.")
+
+ (max-file-uploads 
+  (non-negative-integer 20)
+  "Specify maximum number of files uploaded at once.")
+
+ (default-charset 
+   (string "UTF-8")
+   "Specify default charset used in PHP environment.")
+
+ (allow-url-fopen 
+  (boolean #f)
+  "Enable or disable access to remote URLs in PHP applications.")
+
+ ;; CGI
+ (CGI (section "CGI") "The CGI section")
+
+ (cgi.fix-pathinfo
+  (boolean #f)
+  "Enable or disable 'cgi.fix_pathinfo' option in PHP.  This is highly
+dependent on the used webserver (nginx should have the option disabled,
+apache2 needs it to be enabled).")
+
+ ;; Date
+ (Date (section "Date") "The Date section")
+
+ (date.timezone 
+  (string "Etc/UTC")  ;; TODO: Take from system timezone
+  "Configure the PHP timezone."))
+
+;;; ---- php-fpm.conf ----
+
+(define-configuration php-fpm-configuration
+  ;; All relative paths in this configuration file are relative to PHP's
+  ;; install prefix.
+  (global (section "global") "The global options section")
+
+  ;;(pid "/var/run/php/php-fpm.pid") configured on command line
+
+  (error-log
+   (string "/var/log/php-fpm.log")
+   "Path to the 'error.log' file which is used by PHP-FPM to log
+error messages.  If it's set to 'syslog', error logs are sent to the
+local log daemon.")
+
+  (syslog.ident
+   (string "php-fpm")
+   "When 'syslog' logging is enabled, specify the program identification
+string used by PHP-FPM.  This should be one word string, without spaces.")
+
+  (syslog.facility
+   (string "daemon")
+   "When 'syslog' logging is enabled, specify the 'syslog' facility to use.")
+
+  (log-level
+   (string "notice")
+   "When 'syslog' logging is enabled, specify the log level used by PHP-FPM.")
+
+  (emergency-restart-threshold
+   (non-negative-integer 0)
+   "Specify number of PHP-FPM child processes that exit with errors
+during a given interval (see below) that will trigger an automatic
+restart of the master PHP-FPM process.")
+
+  (emergency-restart-interval
+   (non-negative-integer 0)
+   "Specify the interval which is used to determine
+emergency-restart-threshold.")
+
+  (process-control-timeout
+   (non-negative-integer 0)
+   "Specify maximum wait time the master PHP-FPM process waits for a reaction
+on the signals sent to the child processes.")
+
+  (process.max 
+   (non-negative-integer 128)
+   "Maximum number of PHP-FPM child processes.")
+
+  ;; not yet implemented
+  ;; ("process.priority"  "-19")
+  ;; ("daemonize  "yes"
+  ;; ("rlimit_files"  "1024")
+  ;; (rlimit_core  0")
+  ;; ("events.mechanism"  "epoll")
+  ;; ("systemd_interval"  "10")
+
+  (pools
+   (pools-list (error "At least one pool is required."))
+   "Pools defined by this service."))
+
+;;; ---- pool-configuration ----
+
+(define-configuration php-fpm-pool
+  (name
+   (section (error "pool name is required"))
+   "Name for this pool.")
+
+  ;; TODO: prefix (think about whether we want it or not)
+
+  (user
+   (string "$pool")
+   ;; TODO: Rethink: The username of the user that owns the site files.
+   "The user to run the processes.")
+  (group
+   (string "$pool") ;; TODO: check what happens if empty
+   "Unix group of processes.  If the group is not set, the default user's group
+will be used.")
+
+  (listen
+   (string "/var/run/php-fpm-$pool.sock")
+    "The address on which to accept FastCGI requests.
+Valid syntaxes are:
+  'ip.add.re.ss:port'    - to listen on a TCP socket to a specific IPv4
+                            address on a specific port;
+  '[ip:6:addr:ess]:port' - to listen on a TCP socket to a specific IPv6
+                            address on a specific port;
+  'port'                 - to listen on a TCP socket to all addresses
+                           (IPv6 and IPv4-mapped) on a specific port;
+  '/path/to/unix/socket' - to listen on a unix socket.")
+
+  (listen.owner
+   (string "nginx")
+   "The system user that will be the owner of the PHP-FPM socket.  This should
+be the username of the webserver account, so that it can use the socket to
+communicate with the PHP-FPM process.  This account needs to exist before the
+PHP-FPM process is started (the 'nginx' account is created by default on
+GuixSD systems when using the nginx-service).")
+
+  (listen.group
+   (string "nginx")
+   "The system group that will be the primary group of the PHP-FPM socket.
+This should be the group that the webserver belongs to, so that it can use the
+socket to communicate with the PHP-FPM process.  This group needs to exist
+before the PHP-FPM process is started (the 'nginx' group is created by default
+on GuixSD systems when using the nginx-service).")
+
+  (listen.mode
+   (string "0660")
+   "The default permissions applied to the PHP-FPM pool sockets.")
+
+  ;; TODO:
+  ;; When POSIX Access Control Lists are supported you can set them using
+  ;; these options, value is a comma separated list of user/group names.
+  ;; When set, listen.owner and listen.group are ignored
+  ;(listen.acl-users  '())
+  ;(listen.acl-groups '())
+
+  ;; TODO: listen.allowed-clients = 127.0.0.1
+  ;; TODO: listen.backlog = -1
+  ;; TODO: process.priority = -19
+
+  (pm ;; TODO: nicer name: process-manager
+   (string "ondemand")
+   "Select the default way the PHP-FPM master process will manage pool child
+processes.  Possible values: 'static', 'dynamic' or 'ondemand'.")
+
+  (pm.max-children  ;; TODO: nicer name
+   (non-negative-integer 75) ;; TODO: processor-vcpus
+   "Maximum number of child processes to be created when pm is set to
+'static' and the maximum number of child processes when pm is set to
+'dynamic' or 'ondemand'.")
+
+  (pm.start-servers  ;; TODO: nicer name
+   (non-negative-integer 10) ;; TODO: processor-vcpus
+   "The number of pool child processes created at startup, used by the
+'dynamic' management mode.")
+
+  (pm.min-spare-servers   ;; TODO: nicer name
+   (non-negative-integer 5)
+   "Number of minimum idle spare servers that should be kept around,
+used by the 'dynamic' management mode.")
+
+  (pm.max-spare-servers    ;; TODO: nicer name
+   (non-negative-integer 20) ;; TODO: default to pm.max-children
+   "Number of maximum idle spare servers that should be kept around,
+used by the 'dynamic' management mode.")
+
+  (pm.process-idle-timeout ;; TODO: nicer name
+   (string "10s")
+   "Timeout in seconds for the PHP-FPM pool child processes, used by
+the 'ondemand' management mode.")
+
+  (pm.max-requests ;; TODO: nicer name
+   (non-negative-integer 500)
+   "Maximum number of requests after which PHP-FPM pool child
+processes will be respawned.")
+
+  (pm.status-path   ;; TODO: nicer name
+   ;; FIXME: should be unset by default for security reasons
+   (optional-string "/php_status")
+   "Enable or disable pool status page in all PHP-FPM pools.  If this value is
+not set (#f), no URI will be recognized as a status page.  The value must
+start with a leading slash (/).  You might need to configure the webserver to
+allow access to this page as well.  The value can be anything, but it may not
+be a good idea to use the .php extension or it may conflict with a real PHP
+file.")
+
+  (ping.path   ;; TODO: nicer name
+   ;; FIXME: should be unset by default for security reasons
+   (optional-string "/php_ping")
+   "The ping URI to call the monitoring page of FPM.  If this value is not set,
+no URI will be recognized as a ping page.  This could be used to test
+from outside that FPM is alive and responding, or to - create a graph
+of FPM availability (rrd or such); - remove a server from a group if
+it is not responding (load balancing); - trigger alerts for the
+operating team (24/7).
+
+The value must start with a leading slash (/).  The value can be
+anything, but it may not be a good idea to use the .php extension or
+it may conflict with a real PHP file.")
+
+  (ping.response  ;; TODO: nicer name
+   (string "pong")
+   "A string that defines the expected response of the 'ping' request.")
+
+  (access.log
+   (optional-string "/var/log/php-fpm/$pool_access.log")
+    "The access log file for this PHP-FPM pool .  Set to #f to disable
+logging.")
+
+  (access.format ;; TODO: should be privacy enhanced
+   (string "%R - %u %t \"%m %r%Q%q\" %s %f %{mili}d %{kilo}M %C%%")
+   "The access log format.")
+
+  (slowlog
+   (string "/var/log/php-fpm/$pool_slow.log")
+   "The log file for slow requests.  Note: slowlog is mandatory if
+request_slowlog_timeout is set.")
+
+  (request-slowlog-timeout
+   (string "0")
+   "The timeout for serving a single request after which a PHP backtrace will
+be dumped to the 'slowlog' file.  A value of '0s' means 'off'.  Available
+units: s(econds)(default), m(inutes), h(ours), or d(ays)")
+
+  (request-terminate-timeout
+   (string "0")
+   "The timeout for serving a single request after which the worker
+process will be killed.  This option should be used when the
+'max-execution-time' ini option does not stop script execution for
+some reason.  A value of '0' means 'off'.  Available units:
+s(econds)(default), m(inutes), h(ours), or d(ays)")
+
+  (rlimit-files
+   (non-negative-integer 1024) ; TODO: Check; what if the default is set to 0?
+  "Maximum number of opened file descriptors.")
+  
+  (rlimit-core
+   (non-negative-integer 0) ; TODO: Check; what if the default is set to 0?
+   ;; TODO: Possible Values: 'unlimited' or an integer greater or equal to 0
+   "Specify maximum size of the 'core' files.")
+
+  (chroot
+   (optional-string #f)
+   "Chroot to this directory at the start.  This value must be defined as an
+absolute path.  When this value is not set, chroot is not used.
+Note: you can prefix with '$prefix' to chroot to the pool prefix or one
+of its subdirectories.  If the pool prefix is not set, the global prefix
+will be used instead.
+Note: chrooting is a great security feature and should be used whenever
+      possible.  However, all PHP paths will be relative to the chroot
+      (error_log, sessions.save_path, ...).")
+
+  (chdir
+   (string "/")
+   "Chdir to this directory at the start.")
+
+  (catch-workers-output
+   (boolean #f)
+   "Redirect worker stdout and stderr into main error log.  If not set, stdout
+and stderr will be redirected to /dev/null according to FastCGI specs.  Note:
+on highloaded environement, this can cause some delay in the page process
+time (several ms).")
+
+   (clear-env
+    (boolean #t)
+    "Clear environment in FPM workers. Prevents arbitrary environment
+variables from reaching FPM worker processes by clearing the environment in
+workers before env vars specified in this pool configuration are added.
+Setting to #f will make all environment variables available to PHP code
+via getenv(), $_ENV and $_SERVER.")
+
+  (security.limit-extensions
+   (space-separated-string-list '(".php"))
+   "Limits the extensions of the main script FPM will allow to parse.
+This can prevent configuration mistakes on the web server side.  You
+should only limit FPM to .php extensions to prevent malicious users to
+use other extensions to exectute php code.  Note: set an empty list to
+allow all extensions.")
+
+  ;; TODO: environment:
+  ;; These values are taken from the nginx example configuration:
+  ;; ; Pass environment variables
+  ;; env[HOSTNAME] = $HOSTNAME
+  ;; env[PATH] = /usr/local/bin:/usr/bin:/bin
+  ;; env[TMP] = /tmp
+  ;; env[TMPDIR] = /tmp
+  ;; env[TEMP] = /tmp
+
+  ;; host-specific php ini settings here (from the nginx example configuration)
+  ;; php_admin_value[open_basedir] = /var/www/DOMAINNAME/htdocs:/tmp
+
+  ;; TODO: php_flag[ key ] =  value
+  ;; TODO: php_value[ key ] =  value
+  ;; TODO: php_admin_flag[ key ] =  value
+  ;; TODO: php_admin_value[ key ] =  value
+)
+
+;;; --- obaque configs ---
+
+(define-configuration opaque-php-ini
+  (php
+   (package php)
+   "The php package to use.")
+
+  (string
+   (string (configuration-missing-field 'opaque-php-ini 'string))
+   "The contents of the @code{php.ini} to use."))
+
+(define-configuration opaque-php-fpm-configuration
+  (string
+   (string (configuration-missing-field 'opaque-fpm 'string))
+   "The contents of the @code{php-fpm.conf} to use."))
+
+(define-configuration opaque-php-fpm-pool
+  (name
+   (section (configuration-missing-field 'opaque-php-fpm-pool 'name))
+   "The FPM pool name.")
+  (string
+   (string (configuration-missing-field 'opaque-php-fpm-pool 'string))
+   "The contents of the @code{pool} to use."))
+
+;;; --- service definition ---
+
+(define %php-fpm-activation
+  ;; Activation gexp.
+  #~(begin
+      (use-modules (guix build utils))
+      (define (mkdir-p/perms directory owner perms)
+        (mkdir-p directory)
+        (chown directory (passwd:uid owner) (passwd:gid owner))
+        (chmod directory perms))
+      (let ((root (getpwnam "root")))
+        (mkdir-p/perms "/etc/php/fpm" root #o755)
+        (mkdir-p/perms "/var/log/php-fpm" root #o700)
+        )
+      ;; TODO: Check configuration file syntax.
+      ;; How can both the php-ini-file and the fpm-config-file be passed here?
+      ;; (system* (string-append #$php-pkg "/sbin/php-fpm")
+      ;;          "--test"
+      ;;          "--php-ini" #$php-ini-file
+      ;;          "--fpm-config" #$fpm-config-file)
+      ))
+
+(define (php-fpm-shepherd-service configs)
+  "Return a list of <shepherd-service> for PHP-INI and FPM-CONFIG."
+  (let* ((php-ini (car configs))
+         (fpm-config (car (cdr configs)))
+         (fpm-config-str
+          (cond
+           ((opaque-php-fpm-configuration? fpm-config)
+            (opaque-php-fpm-configuration-string fpm-config))
+           (else
+            (with-output-to-string
+              (lambda ()
+                (serialize-configuration fpm-config
+                                         php-fpm-configuration-fields))))))
+         (php-ini-str
+          (cond
+           ((opaque-php-ini? php-ini)
+            (opaque-php-ini-string php-ini))
+           (else
+            (with-output-to-string
+              (lambda ()
+                (serialize-configuration php-ini
+                                         php-ini-fields))))))
+         (fpm-config-file (plain-file "php-fpm.conf" fpm-config-str))
+         (php-ini-file (plain-file "php.ini" php-ini-str))
+         (php-pkg (if (opaque-php-ini? php-ini)
+                      (opaque-php-ini-php php-ini)
+                      (php-ini-php php-ini))))
+    (list (shepherd-service
+           (documentation "Run the PHP-FPM server.")
+           (provision '(php-fpm))
+           (requirement '(networking))
+           (start #~(make-forkexec-constructor
+                     (list (string-append #$php-pkg "/sbin/php-fpm")
+                           "--php-ini" #$php-ini-file
+ 			   "--pid" "/var/run/php-fpm.pid"
+                           "--fpm-config" #$fpm-config-file)
+                     ;; Wait for the PID file.
+                     #:pid-file "/var/run/php-fpm.pid"))
+           (stop #~(make-kill-destructor))))))
+
+
+(define php-fpm-service-type
+  (service-type (name 'php-fpm)
+                (extensions
+                 (list (service-extension shepherd-root-service-type
+                                          php-fpm-shepherd-service)
+                       ;; TODO: Collect the user ids from the pools
+                       ;;       How can this be done?
+                       ;;(service-extension account-service-type
+                       ;;                   (const %php-accounts))
+                       (service-extension activation-service-type
+                                          (const %php-fpm-activation))))))
+
+(define* (php-fpm-service #:key (config (php-fpm-configuration))
+                          (php-ini (php-ini)))
+  (validate-configuration php-ini
+                          (if (opaque-php-ini? php-ini)
+                              opaque-php-ini-fields
+                              php-ini-fields))
+  (validate-configuration config
+                          (if (opaque-php-fpm-configuration? config)
+                              opaque-php-fpm-configuration-fields
+                              php-fpm-configuration-fields))
+  (service php-fpm-service-type (list php-ini config)))
+
+
+;; --testt --fpm-config /tmp/fpm.conf
+
+;; /tmp/fpm.conf
+;; ;;[global]
+;; pid = /run/php-fpm.pid
+;; error_log = /tmp/php-fpm.log
+;;
+;; [www]
+;; include = /tmp/pool-defaults.conf
+;; ;pm.status_path = False
+;; user = hartmut
+;; pm.max_children = 7
+;; catch_workers_output = On
+;;
+;; ----
+;; /tmp/pool-defaults.conf
+;;
+;; pm = dynamic
+;; pm.max_children = 10
+;; pm.min_spare_servers = 1
+;; pm.max_spare_servers = 5
+;;
+;; listen = /tmp/fpm/$pool.sock
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [WIP 2/2] gnu: Add "PHP FPM" OS config example.
  2016-12-08 17:52 ` [WIP 0/2] php-fpm service - assistance appreciated Hartmut Goebel
  2016-12-08 17:52   ` [WIP 1/2] services: Add php-fpm service Hartmut Goebel
@ 2016-12-08 17:52   ` Hartmut Goebel
  1 sibling, 0 replies; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-08 17:52 UTC (permalink / raw)
  To: guix-devel

* gnu/system/examples/php-fpm.tmpl: New file.
* Makefile.am (EXAMPLES): Add it.
* doc/locak.mk (OS_CONFIG_EXAMPLES_TEXI): Add doc/os-config-php-fpm.texi.
* gnu/system/install.scm (/etc/configuration-files)[directory]: Add
  php-fpm.tmpl.
---
 Makefile.am                      |   3 +-
 doc/local.mk                     |   3 +-
 gnu/system/examples/php-fpm.tmpl | 115 +++++++++++++++++++++++++++++++++++++++
 gnu/system/install.scm           |   6 +-
 4 files changed, 123 insertions(+), 4 deletions(-)
 create mode 100644 gnu/system/examples/php-fpm.tmpl

diff --git a/Makefile.am b/Makefile.am
index 0e3ddac..f39c80b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -189,7 +189,8 @@ KCONFIGS =					\
 EXAMPLES =					\
   gnu/system/examples/bare-bones.tmpl		\
   gnu/system/examples/desktop.tmpl		\
-  gnu/system/examples/lightweight-desktop.tmpl
+  gnu/system/examples/lightweight-desktop.tmpl	\
+  gnu/system/examples/php-fpm.tmpl
 
 GOBJECTS = $(MODULES:%.scm=%.go) guix/config.go $(dist_noinst_DATA:%.scm=%.go)
 
diff --git a/doc/local.mk b/doc/local.mk
index 64bd2a5..f8b702e 100644
--- a/doc/local.mk
+++ b/doc/local.mk
@@ -48,7 +48,8 @@ EXTRA_DIST +=					\
 OS_CONFIG_EXAMPLES_TEXI =			\
   %D%/os-config-bare-bones.texi			\
   %D%/os-config-desktop.texi			\
-  %D%/os-config-lightweight-desktop.texi
+  %D%/os-config-lightweight-desktop.texi	\
+  %D%/os-config-php-fpm.texi
 
 # Bundle this file so that makeinfo finds it in out-of-source-tree builds.
 BUILT_SOURCES        += $(OS_CONFIG_EXAMPLES_TEXI)
diff --git a/gnu/system/examples/php-fpm.tmpl b/gnu/system/examples/php-fpm.tmpl
new file mode 100644
index 0000000..fb5143e
--- /dev/null
+++ b/gnu/system/examples/php-fpm.tmpl
@@ -0,0 +1,115 @@
+;; -*- mode: scheme -*-
+;;
+;; This is an operating system configuration template for a basic php-fpm
+;; server. It will serve a single page on http://localhost/
+
+(use-modules (gnu))
+(use-service-modules networking php web)
+(use-package-modules admin)
+(use-package-modules php) ; for php-hello-world, an example php application
+
+(define NGINX
+  ;; FIXME: should be (string-append nginx "/"))
+  "/gnu/store/np656cjgc87rv18klcr2vwxk6g0kjhbz-nginx-1.11.6")
+(define PHP-HELLO-WORLD
+  ;; FIXME: should be (string-append php-hello-world "/"))
+  "/gnu/store/9wqzxfs2xgr4ic1iwq124dq7cfqg1yi9-php-hello-world-0.1")
+
+;; TODO: Use nginx configuration mechanisms when they are finished
+(define (CONFIG nginx php-hello-world)
+  (string-append "
+user nginx www;
+pid /var/run/nginx/pid;
+error_log /var/log/nginx/error.log info;
+
+http {
+    client_body_temp_path /var/run/nginx/client_body_temp;
+    proxy_temp_path /var/run/nginx/proxy_temp;
+    fastcgi_temp_path /var/run/nginx/fastcgi_temp;
+    uwsgi_temp_path /var/run/nginx/uwsgi_temp;
+    scgi_temp_path /var/run/nginx/scgi_temp;
+    access_log /var/log/nginx/access.log;
+    error_log /var/log/nginx/error.log info;
+
+    server_tokens off;
+
+    include " nginx "/share/nginx/conf/fastcgi.conf;
+
+    server {
+      listen 80;
+      server_name _;
+      root " php-hello-world "/;
+      index index.php;
+
+      # Per server logging
+      access_log  /var/log/nginx/www.access.log;
+      error_log  /var/log/nginx/www.error.log notice;
+
+      location / {
+          try_files   $uri $uri/ /index.php;
+      }
+      # serve static files directly
+      location ~* ^.+.(jpg|jpeg|gif|css|png|js|ico|html|xml|txt)$ {
+          access_log        off;
+          expires           max;
+      }
+
+      location ~ \\.php$ {
+          try_files $uri =404;
+          fastcgi_pass unix:/var/run/php-fpm-www.sock;
+          fastcgi_index index.php;
+       }
+    }
+}
+"))
+
+(define CONFIG (CONFIG NGINX PHP-HELLO-WORLD))
+
+
+(operating-system
+  (host-name "phempton")
+  (timezone "Europe/Berlin")
+  (locale "en_US.UTF-8")
+  (kernel-arguments '("vga=791")) ; 1024x768 pixel
+
+  ;; Assuming /dev/sdX is the target hard disk, and "my-root" is
+  ;; the label of the target root file system.
+  (bootloader (grub-configuration (device "/dev/sdX")))
+  (file-systems (cons (file-system
+                        (device "my-root")
+                        (title 'label)
+                        (mount-point "/")
+                        (type "ext4"))
+                      %base-file-systems))
+
+  ;; Globally-installed packages.
+  (packages (cons*
+             php-hello-world ; an example php application
+             %base-packages))
+
+  ;; We need to add a user and a group for each pool (defaults are the pool
+  ;; name). TODO: This should be done automatically, based on the pool
+  ;; configuration given below.
+  (groups (cons
+           (user-group (name "www"))
+           %base-groups))
+  (users (cons
+          (user-account
+           (name "www")
+           (group "www")
+           (home-directory "/var/empty")
+           (shell (file-append shadow "/sbin/nologin")))
+          %base-user-accounts))
+
+  (services (cons*
+             (dhcp-client-service)
+             (console-keymap-service "de")
+             (nginx-service
+                #:config-file (plain-file "nginx.conf" CONFIG))
+             (php-fpm-service
+              #:config
+              (php-fpm-configuration
+               (pools (list
+                       (php-fpm-pool
+                        (name "www"))))))
+             %base-services)))
diff --git a/gnu/system/install.scm b/gnu/system/install.scm
index dfa003f..8c95944 100644
--- a/gnu/system/install.scm
+++ b/gnu/system/install.scm
@@ -224,10 +224,12 @@ the user's target storage device rather than on the RAM disk."
                                                                target)))
                                    '(#$(file "bare-bones.tmpl")
                                      #$(file "desktop.tmpl")
-                                     #$(file "lightweight-desktop.tmpl"))
+                                     #$(file "lightweight-desktop.tmpl")
+                                     #$(file "php-fpm.tmpl"))
                                    '("bare-bones.scm"
                                      "desktop.scm"
-                                     "lightweight-desktop.scm"))
+                                     "lightweight-desktop.scm"
+                                     "php-fpm.scm"))
                          #t))))
 
   `(("configuration" ,directory)))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-08 17:47 ` Hartmut Goebel
@ 2016-12-21 16:38   ` Ludovic Courtès
  2016-12-22 17:43     ` Hartmut Goebel
  0 siblings, 1 reply; 12+ messages in thread
From: Ludovic Courtès @ 2016-12-21 16:38 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hi Hartmut!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 08.12.2016 um 18:45 schrieb Hartmut Goebel:
>> * gnu/packages/php.scm (php-hello-world): New variable.
>
> This is useful for testing setups and providing examples.

I agree… but does it belong in a home-made package?

For other tools we provide what upstream provides.  For example, Qt
comes with examples, which we provide in the ‘qt’ package (IIRC).

I think it would be best to stick to that policy.  WDYT?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-21 16:38   ` Ludovic Courtès
@ 2016-12-22 17:43     ` Hartmut Goebel
  2016-12-29 17:44       ` Ludovic Courtès
  0 siblings, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-22 17:43 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Am 21.12.2016 um 17:38 schrieb Ludovic Courtès:
> For other tools we provide what upstream provides.  For example, Qt
> comes with examples, which we provide in the ‘qt’ package (IIRC).

The php source package does not provide any example. I also searched the
internet for some hello-world-package, but did not find one.

If you know of one, feel free to replace this one.

If you dislike "home-made" packages so much, I can set up a
"php-hello-world" project at github. But what should be the benefit?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-22 17:43     ` Hartmut Goebel
@ 2016-12-29 17:44       ` Ludovic Courtès
  2016-12-29 19:20         ` Hartmut Goebel
  0 siblings, 1 reply; 12+ messages in thread
From: Ludovic Courtès @ 2016-12-29 17:44 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hi Hartmut!

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 21.12.2016 um 17:38 schrieb Ludovic Courtès:
>> For other tools we provide what upstream provides.  For example, Qt
>> comes with examples, which we provide in the ‘qt’ package (IIRC).
>
> The php source package does not provide any example. I also searched the
> internet for some hello-world-package, but did not find one.
>
> If you know of one, feel free to replace this one.
>
> If you dislike "home-made" packages so much, I can set up a
> "php-hello-world" project at github. But what should be the benefit?

Given the popularity of PHP, I would expect tutorials and examples to
abound already, no?

You can of course roll your own and Guix could distribute it, that’s
fine.  I’m just surprised we even have to do that in the first place.

Thoughts?

Ludo’.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-29 17:44       ` Ludovic Courtès
@ 2016-12-29 19:20         ` Hartmut Goebel
  2016-12-31 11:16           ` Ludovic Courtès
  0 siblings, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-29 19:20 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Am 29.12.2016 um 18:44 schrieb Ludovic Courtès:
> Given the popularity of PHP, I would expect tutorials and examples to
> abound already, no?
>
> You can of course roll your own and Guix could distribute it, that’s
> fine.  I’m just surprised we even have to do that in the first place.

I was surprised, too. Otherwise I'd not write a own package.

But I see no benefit of putting a project to github, just do not have a
"home grown" package at guix. IMHO implementing this is just a waste of
time.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-29 19:20         ` Hartmut Goebel
@ 2016-12-31 11:16           ` Ludovic Courtès
  2016-12-31 12:12             ` Hartmut Goebel
  0 siblings, 1 reply; 12+ messages in thread
From: Ludovic Courtès @ 2016-12-31 11:16 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hello,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 29.12.2016 um 18:44 schrieb Ludovic Courtès:
>> Given the popularity of PHP, I would expect tutorials and examples to
>> abound already, no?
>>
>> You can of course roll your own and Guix could distribute it, that’s
>> fine.  I’m just surprised we even have to do that in the first place.
>
> I was surprised, too. Otherwise I'd not write a own package.
>
> But I see no benefit of putting a project to github, just do not have a
> "home grown" package at guix. IMHO implementing this is just a waste of
> time.

I can understand why you’d feel this way, it’s just a few lines of code
after all.  However, as a distro, I think we should refrain from
providing packages unrelated to Guix/Guile that have no upstream.

Ludo’.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-31 11:16           ` Ludovic Courtès
@ 2016-12-31 12:12             ` Hartmut Goebel
  2017-01-04 22:38               ` Ludovic Courtès
  0 siblings, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-12-31 12:12 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Am 31.12.2016 um 12:16 schrieb Ludovic Courtès:
> after all.  However, as a distro, I think we should refrain from
> providing packages unrelated to Guix/Guile that have no upstream.

So this package will not happen, since *I* will not spend my time to
create such a project. As a consequences, there will be not "php-fpm" OS
example.

I already spent quite some time on this topic, so this is quite
disencouraging. :-(

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: Add php-hello-world.
  2016-12-31 12:12             ` Hartmut Goebel
@ 2017-01-04 22:38               ` Ludovic Courtès
  0 siblings, 0 replies; 12+ messages in thread
From: Ludovic Courtès @ 2017-01-04 22:38 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 31.12.2016 um 12:16 schrieb Ludovic Courtès:
>> after all.  However, as a distro, I think we should refrain from
>> providing packages unrelated to Guix/Guile that have no upstream.
>
> So this package will not happen, since *I* will not spend my time to
> create such a project. As a consequences, there will be not "php-fpm" OS
> example.

Now I just realize you posted php-fpm for review on Dec. 8 and nobody
replied.  Please feel entitled to ping people if you don’t get feedback
after a week or so.  Otherwise, without bad faith from anyone, it just
falls into the cracks.

Clearly I had no idea there was a connection between the “php-fpm”
service and php-hello-world.

> I already spent quite some time on this topic, so this is quite
> disencouraging. :-(

Please don’t be discouraged.  I (and others) spend this amount of time
on a dozen of topics in parallel, as you might have seen from the
mailing list.

Cheers,
Ludo’.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2017-01-04 22:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-08 17:45 [PATCH] gnu: Add php-hello-world Hartmut Goebel
2016-12-08 17:47 ` Hartmut Goebel
2016-12-21 16:38   ` Ludovic Courtès
2016-12-22 17:43     ` Hartmut Goebel
2016-12-29 17:44       ` Ludovic Courtès
2016-12-29 19:20         ` Hartmut Goebel
2016-12-31 11:16           ` Ludovic Courtès
2016-12-31 12:12             ` Hartmut Goebel
2017-01-04 22:38               ` Ludovic Courtès
2016-12-08 17:52 ` [WIP 0/2] php-fpm service - assistance appreciated Hartmut Goebel
2016-12-08 17:52   ` [WIP 1/2] services: Add php-fpm service Hartmut Goebel
2016-12-08 17:52   ` [WIP 2/2] gnu: Add "PHP FPM" OS config example Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).