From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?q?amirouche=40hypermove=2Enet?= Subject: =?utf-8?q?Re=3A?= Web interface pushed Date: Mon, 30 Jul 2018 09:38:53 +0200 Message-ID: <3afd-5b5ec080-1-6a567300@3565601> References: <87r2jlbsq3.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_=-_OpenGroupware_org_NGMime-15101-1532936333.263241-0------" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fk2li-0004jr-2K for guix-devel@gnu.org; Mon, 30 Jul 2018 03:39:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fk2ld-00007n-4u for guix-devel@gnu.org; Mon, 30 Jul 2018 03:39:02 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:51665) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fk2lc-00006q-S1 for guix-devel@gnu.org; Mon, 30 Jul 2018 03:38:57 -0400 In-Reply-To: <87r2jlbsq3.fsf@lassieur.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?q?Cl=C3=A9ment_Lassieur?= Cc: Guix-devel , Tatiana Sholokhova ------=_=-_OpenGroupware_org_NGMime-15101-1532936333.263241-0------ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Length: 1350 Hi On Monday, July 30, 2018 00:08 CEST, Cl=C3=A9ment Lassieur wrote: =C2=A0Hi Tatiana, So, I did the pagination review and I pushed your work tonight. :-) I added checks to avoid crashes when the table is empty (FIRST and LAST= expect non-empty lists). I modified a few minor things too: - the commit message, so that it matches our convention - the indentation - I removed code comments, trailing '\' in SQL queries, useless newlines, useless exports - I renamed a few things (e.g. thing-list with things, %pagesize with %page-size) - I replaced (+ 1 x) with (1+ x) - I used string-join to avoid long strings - I used FIRST instead of CAR when used with LAST (for more consistency= , but it's the exact same thing) - I replaced FIRST and LAST with BUILD-ID and BUILD-STOPTIME, so to mak= e it more furure-proof and easier to understand - I used a format string for RESPOND-HTML (to avoid "\"\"") - I finally opted for a non-parameter %page-size (yes, I changed my min= d :-), I just didn't see any reason to use one) - I removed ('page (string->number param)) from REQUEST-PARAMETERS (I think it was useless) - I added a missing copyright header And that's all! Thanks for this work, it'll be very useful. Don't hesitate send new patches to improve it! Best regards, Cl=C3=A9ment =C2=A0How can I test? =C2=A0 ------=_=-_OpenGroupware_org_NGMime-15101-1532936333.263241-0------ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Length: 1698 Hi
On Monday, July 30, 2018 00:08 CEST, Cl=C3=A9ment Lassieu= r <clement@lassieur.org> wrote:
 
Hi Tatiana,

So, I d= id the pagination review and I pushed your work tonight. :-)

I added checks to avoid crashes when the table is empty (FIRST and LAS= T
expect non-empty lists).

I modified a few minor thing= s too:

- the commit message, so that it matches our conventi= on
- the indentation
- I removed code comments, trailing '\' = in SQL queries, useless
newlines, useless exports
- I renamed= a few things (e.g. thing-list with things, %pagesize with
%page-s= ize)
- I replaced (+ 1 x) with (1+ x)
- I used string-join to= avoid long strings
- I used FIRST instead of CAR when used with L= AST (for more consistency,
but it's the exact same thing)
- I= replaced FIRST and LAST with BUILD-ID and BUILD-STOPTIME, so to makeit more furure-proof and easier to understand
- I used a forma= t string for RESPOND-HTML (to avoid "\"\"")
- I finally opted for = a non-parameter %page-size (yes, I changed my mind
:-), I just did= n't see any reason to use one)
- I removed ('page (string->numb= er param)) from REQUEST-PARAMETERS (I
think it was useless)
-= I added a missing copyright header

And that's all!
Thanks for this work, it'll be very useful. Don't hesitate send new<= br />patches to improve it!

Best regards,
Cl=C3=A9ment<= br /> 
How can I test?


  ------=_=-_OpenGroupware_org_NGMime-15101-1532936333.263241-0--------