From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id TLLxLii5gGAe5AAAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 01:45:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OB+jKCi5gGCmGAAAB5/wlQ (envelope-from ) for ; Wed, 21 Apr 2021 23:45:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D0AE22336 for ; Thu, 22 Apr 2021 01:45:44 +0200 (CEST) Received: from localhost ([::1]:57132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZMXN-0006PS-QA for larch@yhetil.org; Wed, 21 Apr 2021 19:45:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZMX6-0006PF-7T for guix-devel@gnu.org; Wed, 21 Apr 2021 19:45:24 -0400 Received: from knopi.disroot.org ([178.21.23.139]:34862) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZMX3-0000nb-Pv for guix-devel@gnu.org; Wed, 21 Apr 2021 19:45:24 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 359C450CC6; Thu, 22 Apr 2021 01:45:18 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id 8_TbpYqJT9ii; Thu, 22 Apr 2021 01:45:16 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1619048710; bh=WoPi6gmqT06kIXvDV1kgY32tTaA5kGQxib8CUe7HS2c=; h=Date:From:Subject:To:Cc:In-Reply-To:References; b=TLzGHvPfBQuupw9wHYzWJB6gaOnG9C9apbqi6xgv+8sPoiy+zVoU1VMccicujJtED +2WzeseeKxWxWMtJ2rF37jG12+SGgQHkM5B6Wl1wWzGz/TQXLajscy9tN7p9Yz/vrd lqHkcPRgP79I11x+Fg5kcIdzI9fyLEAqkuc5g3B6Jw/cV1qzhDRzdBiH4VMCa4UFnF QAr0oLthYTSjB3BRUzZhNHP81OG+u0nnGy6AlgmrTXWb4pF0XhKOCeKpehvXLiOtFU S0qTGyhmO+lRmjbjCVPxzecO+WIx+XmmaMgIHvzP0dQ0cIjNVDVNiHkMvWH41Yne+j wWNW3iWtOMnrw== Date: Wed, 21 Apr 2021 23:45:10 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Raghav Gururajan" Message-ID: <3a6e8b4f8a73fefbcd853f11c2340d86@disroot.org> Subject: Re: A "cosmetic changes" commit that removes security fixes To: guix-devel@gnu.org Cc: "Mark H Weaver" , "Tobias Geerinckx-Rice" , "=?utf-8?B?TMOpbyBMZSAgQm91dGVy?=" , leo.prikler@student.tugraz.at, leo@famulari.name In-Reply-To: <878s5b5lc5.fsf@nckx> References: <878s5b5lc5.fsf@nckx> <877dkv2vi5.fsf@netris.org> <874kfz2uvl.fsf@netris.org> Received-SPF: pass client-ip=178.21.23.139; envelope-from=raghavgururajan@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619048744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=WoPi6gmqT06kIXvDV1kgY32tTaA5kGQxib8CUe7HS2c=; b=mKYsbKfE8WyorfuOccyk3vr0ZQQkN085Y+f97hMVcuMq+n/TjQYlYo8kKmhd0Bdahk/Fp3 1EfzQ9R9pjMgKr8ncNNlcKXEDES7UI5oEJC+WZ45pz7I14i1N40E8yALxuzMSbLvZYBuM9 bJeEsMdiy9MhrbtBVp/8nnVd4mR4uukMo1++mJHY2N6lyScshp3BQl3gQKB2Cat9/gHWIM be0rSoT+gLSpytPXRfS63DAmRepEBlkX+BA8axhUyZUg8nGkHQMthjQdxZSixMoqcLFDgP GjhwRzHCYJKRpN07J03aYmPZOPLyZihKnjUY8dfSVC78sRKRE6ALOqoLmNZ07w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619048744; a=rsa-sha256; cv=none; b=q1aBYDQ0dd7xHUpjmBFKzSGZxqp+ap6JjulrZOuEZUtw2HEACAJ76AQhg48+/wjh5Zq1C1 kuydECUL2XUuF8Hf72eGFMv0qHAVkg6VVK7KNtV7vsmuyGJNMsCKj1xW4zJFvGurt8zPtZ E5ppCZSDSD8ho/NCdwukHzNlVaDkAMLjqAoCD3Q9ScaaZ/sMJ0sghq4swGiphe2tbo4hbk Nkc5qMt2gunxDQECEN17wMdIMJLUDsh3Tzb5ThuRHrQHbkd/0Dd4PyX2yUJCX6nVXOsdnE LqAnInWx/cKkx9ubI28VGht8CAHT5RD6BVihFysDsPzxRJ3MGetiDKkGao11Eg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=disroot.org header.s=mail header.b=TLzGHvPf; dmarc=pass (policy=quarantine) header.from=disroot.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.14 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=disroot.org header.s=mail header.b=TLzGHvPf; dmarc=pass (policy=quarantine) header.from=disroot.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6D0AE22336 X-Spam-Score: -1.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: bw2Q5sR88nsC Hi All!=0A=0ASorry, I just saw this email and noticed its thread via web.= I wasn't subscribed.=0A=0A> Raghav, can you explain why you created that= commit? What's the =0A> context & the goal? Why is it on current wip-gno= me? What do you =0A> expect to happen to it?=0A=0AThe commit is not new. = I cherry-picked from core-updates (993de472ed3dfe90e1c4110b6b910c1f74d243= ff), which was pushed as a part of #42958.=0A=0A>> "Signed-off-by: L=C3= =A9o Le Bouter "=0A> =0A> What does this line mean? = Please explain in some detail.=0A=0AThe cherry-pick preserves the commit = message.=0A=0AP.S.=0A=0APlease note that I stopped making cosmetic change= s long ago. I explicitly mentioned in #42958, during review, that there a= re two *old* 'cosmetic changes' (glib and cairo) which I had to preserve = so that I don't have to rework the succeeding patches. Please refer this = message (https://issues.guix.gnu.org/42958#63).=0A=0ARegards,=0ARG.