From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CGrEMvRcNGQbfAAASxT56A (envelope-from ) for ; Mon, 10 Apr 2023 21:01:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UOzcMfRcNGSoPgEAG6o9tA (envelope-from ) for ; Mon, 10 Apr 2023 21:01:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 812BF86B7 for ; Mon, 10 Apr 2023 21:01:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plwkl-0006u9-E0; Mon, 10 Apr 2023 15:00:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plwkk-0006u1-Re for guix-devel@gnu.org; Mon, 10 Apr 2023 15:00:34 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plwki-0003YD-RY for guix-devel@gnu.org; Mon, 10 Apr 2023 15:00:34 -0400 Date: Mon, 10 Apr 2023 19:00:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1681153230; x=1681412430; bh=SfD5meTS9zLPgxJEgfjf0cNSrv/8v8/gZcwSRydhwwI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=noPciHscfyhjCxJfB5SJ3Fe5FoHU07Eb0R3ALrL4FZXxB9F/4l/auBtLshFpzASVt ZPqtZwYwTdKemq+rdgPIrIwtNWbpHa5bsyaQ1lsOPM4xE2E0RD8eTSHkWotKyVhqqV tlMFNX+IpvdnddlIpx8oV2pVjWbePRzBUDVp/R8xrrkdkbM52ml2BKa8FZFsHLOHeX 2DXtgQs68YWYwzIhwPt7c0p4hARNnFMiCKL7V9q1qgxLHgsktbNUPl534TpiZYyGlk VPGwNI8EuRi6hvk44THA3Fgw+kVmuGkZ3drv8kw9H4O1QrTQPE6gr/tEi+RDEOa0wJ t2gIO3Vv96o3A== To: guix-devel From: Kaelyn Cc: Andreas Enge Subject: Re: Fix for librsvg 2.40 on core-updates Message-ID: <3G2SRZ_f9rzNiQAesyuxAAhrGm7Ef57_iNytT5bLm6VZ8h0P2dy3Y3oZd70-zZ0x4O_URcwBbpQhdtow3k9iBzlmXpkKcyD_LKdvTOz4r38=@protonmail.com> In-Reply-To: <4d68e4l1D7epKiEbdZefULMDUj6WUrxFmgrCghEBvl8fe6nggOmIuGdZy3-_63OUeePRvJLKQtn2Jug2Mh-K4Rx0i3aVixEvjVMGH0h4ceU=@protonmail.com> References: <-yuU5lP0atxOfIH2n0tY_JcRohzhb2HtmCj8owCxLEvkaOKSIx8nebEwIarFeEZ0Tab2HOVv_zNjWsa9fFNy8Rs7QU0RWPHIvl0FHKrSPlY=@protonmail.com> <4d68e4l1D7epKiEbdZefULMDUj6WUrxFmgrCghEBvl8fe6nggOmIuGdZy3-_63OUeePRvJLKQtn2Jug2Mh-K4Rx0i3aVixEvjVMGH0h4ceU=@protonmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=kaelyn.alexi@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681153268; a=rsa-sha256; cv=none; b=Bsq2aaWDQPpFQc4dH6MZj/O7uXFotpDks8tf+wMEdNMKRA2FsrIGFyxUOdt8n3P29cvcH+ 0mH2mfxPUW9G7nZrMLtR6FBJ7RgiDbjpw+0Dd4kEI2i85NKw29p8WQIv7ZCXz1hrjodm0w XvsTk2+VvuItQnkUfz+cgknEZU4LjgfuA2OlG2J3pguoKyVqJJbBvUhtaq5Axx30dM6ebF eAPSzIAT1NYFZ4pdjtl918lUrYXnFvHFOf3rJErkyAKtG7eUCG947WYKIPDu7qxCMMPmFM 7xl75IGvhS5cWp2ifULf7ekvL1qVKINVlV6+JDypvizuDSx7oL9E7fGZ+6wDig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=noPciHsc; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681153268; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=SfD5meTS9zLPgxJEgfjf0cNSrv/8v8/gZcwSRydhwwI=; b=kvwhKpH/ExHsFDkKnLug1hgF2UtiOJsRQBJbqXUfPxVmGIEidi5IFpjmsIU+2+FLO1rlLH W4mLf/U2Snq3Q4CPoi9Ceclb9rfAAXD9sPvWq4JLyfB043d7CUAaUWjbNw3VqsUnAiMEMc utT2GHhqenRI8cfDFfCkJbKXPVw8AzEsc6evzPJcFecNbQ4bX12D0gOJXnjklCeuZtXJG0 ioCtHGI1BbyaVKW3t4/fdsYw+6xQ4E28QuLHotz33ISaTt53NKqURPn+10ld04f5Khrf8s vIxPqZKLyWVUGeq5zlfCGBrYx+Oini3nrg2pVMFZmNnYnvX7eX0Sr1xLaz4QLw== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=noPciHsc; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -7.95 X-Spam-Score: -7.95 X-Migadu-Queue-Id: 812BF86B7 X-TUID: JlA1G2gQPBvZ ------- Original Message ------- On Saturday, April 8th, 2023 at 3:55 PM, Kaelyn wrote: >=20 > ------- Original Message ------- > On Saturday, April 8th, 2023 at 9:52 AM, Andreas Enge andreas@enge.fr wro= te: >=20 >=20 >=20 > > Hello, > >=20 > > Am Fri, Apr 07, 2023 at 04:53:15PM +0000 schrieb Kaelyn: > >=20 > > > On core-updates, librsvg-2.40 fails to compile due to a single failin= g test (I've confirmed the failure on x86_64 and i686, though the package i= s only used/needed on non-x86_64 systems for gtk+ and others; it also affec= ts wine and wine-staging on x86_64 as they are 32-bit packages). I was able= to track down the test failure to a text rendering difference between Pang= o 1.48 and 1.50, which led to the text being one pixel line higher between = the reference and output images. On Monday I submitted https://issues.guix.= gnu.org/62646 which adds a phase to librsvg-2.40 to adjust the output Y coo= rdinate of the SVG transformation matrix by one for the failing test so tha= t it passes with Pango 1.50. > >=20 > > thanks a lot, I added a copyright line for you and pushed. >=20 >=20 > Thank you! (I often forget the copyright line, so thanks for that as well= .) >=20 > > Wine still fails to build due to autogen not building on i686: > > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts -DPKG= DATADIR=3D\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/sha= re/autogen\" -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -We= rror -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow -Wstrict-pr= ototypes -Wwrite-strings -Wstrict-aliasing=3D3 -Wextra -Wno-cast-qual -g -O= 2 -Wno-format-contains-nul -fno-strict-aliasing -c libopts.c -fPIC -DPIC -o= .libs/libopts_la-libopts.o > > In file included from libopts.c:48: > > usage.c: In function =E2=80=98prt_extd_usage.isra=E2=80=99: > > usage.c:736:38: error: =E2=80=98s =E2=80=99 directive output may be tru= ncated writing 2 bytes into a region of size between 0 and 9 [-Werror=3Dfor= mat-truncation=3D] > > 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); > > | ^~~~~~~ > > usage.c:736:9: note: =E2=80=98snprintf=E2=80=99 output between 9 and 18= bytes into a destination of size 12 > > 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >=20 > > Just in case you wish to continue investigating :) >=20 >=20 > I probably will. :) My goal has been to build my home and system profiles= from core-updates, including wine64-staging. I just mailed https://issues.guix.gnu.org/62758 to add a snippet to fix the= build error. I used a similar approach as the existing snippet for fixing = a format overflow error. (I also forgot to set the subject prefix to "PATCH= core-updates" on the git send-mail command line.). =20 Cheers, Kaelyn