From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Vollmert Subject: Re: Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Date: Tue, 6 Aug 2019 09:04:39 +0200 Message-ID: <3C8EAC60-7073-4528-BC5D-548A018F08D8@vllmrt.net> References: <87muh2ckdn.fsf@ngyro.com> <21D6742C-75C4-47A0-9F1A-0C911C24E3DA@vllmrt.net> <87mugmq5ll.fsf@ngyro.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38674) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hutWd-0002C9-UX for guix-devel@gnu.org; Tue, 06 Aug 2019 03:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hutWc-0006ml-Sf for guix-devel@gnu.org; Tue, 06 Aug 2019 03:04:51 -0400 Received: from mx1.mailbox.org ([2001:67c:2050:104:0:1:25:1]:35666) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hutWc-0006lE-Mp for guix-devel@gnu.org; Tue, 06 Aug 2019 03:04:50 -0400 In-Reply-To: <87mugmq5ll.fsf@ngyro.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Timothy Sample Cc: guix-devel@gnu.org, 36807@debbugs.gnu.org Hi Timothy, > On 6. Aug 2019, at 06:29, Timothy Sample wrote: >=20 >> #36663: adding elm compiler dependencies (just a few extra ghc >> packages) >=20 > These commits seem to be in the wrong order. I think I can untangle > them, though. >=20 >> #36692: GHC version 8.6.5 (just as a package for now, not used to = build >> anything) >=20 > I made some bigger changes here. Mostly, I made use of > =E2=80=9Csubstitute-keyword-arguments=E2=80=9D to reuse more code from = =E2=80=9Cghc-8.4=E2=80=9D. >=20 > Why do you use =E2=80=9Cpatch=E2=80=9D instead of =E2=80=9Csubstitute*=E2= =80=9D to disable the failing > tests? I see from your previous patches that you used to do it with > =E2=80=9Csubstitute*=E2=80=9D. It would be ok to go back to the old state. I moved to a patch over the process of getting the build to pass, which involved skipping more = tests. That said, substitute has several downsides compared to patches: - patch is easier to read - patch doesn=E2=80=99t fail silently >> no ticket: Skip tests for three Haskell packages that fail on i686 = only >> (and seem harmless): ghc-trifecta, ghc-yaml, = ghc-libmpd-haskell. >=20 > This seems reasonable to me, though I suppose it would be better to = only > skip them when building for i686. It looks like we only do this > rarely (e.g., the =E2=80=9Cicu4c=E2=80=9D package), so maybe it=E2=80=99= s not a big deal. I=E2=80=99ll keep that in mind for next time I run into a similar issue. > Is there any more info about =E2=80=9Cghc-trifecta=E2=80=9D? The = other two have nice > comments that tell me that upstream is aware of the problem, and that = it > might be fixed in the future. That one is a rather opaque build failure kind of thing related to = doctests: They fail to build on i686: =20 doctests: ByteCodeLink.lookupCE During interactive linking, GHCi couldn't find the following symbol: = lenszm4zi16zi1zmJLUwQ4zzqmnaKkc25AByaCJ_ControlziLensziTH_makeClassy_closu= re This may be due to you not asking GHCi to load extra object files, archives or DLLs needed by your current session. Restart GHCi, = specifying the missing library using the -L/path/to/object/dir and = -lmissinglibname flags, or simply by naming the relevant files on the GHCi command = line. Alternatively, this link failure might indicate a bug in GHCi. If you suspect the latter, please send a bug report to: glasgow-haskell-bugs@haskell.org =20 Test suite doctests: FAIL I spent a bit of time digging, then gave up. Thanks for the review. Robert