From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Marius Bakke <mbakke@fastmail.com>,
"guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH 2/3] gnu: Add python-pyxb.
Date: Tue, 20 Sep 2016 16:34:15 +1000 [thread overview]
Message-ID: <39d81c47-a96d-1f1c-ad1d-a80e7b7f109d@uq.edu.au> (raw)
In-Reply-To: <3bd16b58-b3d1-d47c-2433-c3a721681463@uq.edu.au>
Oops, forgot to cc the list.
On 20/09/16 16:02, Ben Woodcroft wrote:
> Hi Marius,
>
> Thanks for the patches.
>
> On 17/09/16 20:10, Marius Bakke wrote:
>> [..]
>> + (add-after 'unpack 'fix-tests
>> + (lambda _
>> + ;; See https://github.com/pabigot/pyxb/issues/26 ...
>> + (delete-file "tests/trac/test-trac-0091.py")
>
> The fix for that test failing seems straightforward enough, might be
> better to include as a patch so those tests are run.
> https://github.com/pabigot/pyxb/commit/d4bdd5a1c712cd70f96264ae13b55d015cbf3335
>
>
>> + ;; ...and https://github.com/pabigot/pyxb/pull/58 .
>> + (substitute* "tests/utils/test-utility.py"
>> + (("__NoExt_re = re.compile.*$")
>> + "__NoExt_re = re.compile('(^|\\%s)[^\\.]+$' %
>> os.sep)\n"))
>
> Good catch there. It would be preferable to add this change as a patch
> as well, because it is more likely to apply correctly (not that it
> won't here), and also because when it is no longer needed after this
> package gets updated the patch will fail to apply alerting the updater
> to the fact it should be removed. As a bonus, my experience is that
> working with patches easier than using substitute* so require less
> builds before getting to a happy package.
>
> I have not actually built these packages, but they look fine
> otherwise. Would you mind sending an updated patch for pyxb, and then
> I'll probably apply all three (assuming I find nothing else, which I
> don't anticipate).
>
> Thanks,
> ben
next prev parent reply other threads:[~2016-09-20 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 10:10 [PATCH 0/3] gnu: python2-pbcore: Update to 1.2.10 Marius Bakke
2016-09-17 10:10 ` [PATCH 1/3] gnu: python-pysam: Update to 0.9.1.4 Marius Bakke
2016-09-17 10:10 ` [PATCH 2/3] gnu: Add python-pyxb Marius Bakke
[not found] ` <3bd16b58-b3d1-d47c-2433-c3a721681463@uq.edu.au>
2016-09-20 6:34 ` Ben Woodcroft [this message]
2016-09-20 7:06 ` Ben Woodcroft
2016-09-21 21:14 ` Marius Bakke
2016-09-22 0:46 ` Ben Woodcroft
2016-09-22 15:15 ` Marius Bakke
2016-09-23 1:28 ` Ben Woodcroft
2016-09-23 15:56 ` Marius Bakke
2016-09-23 16:06 ` Marius Bakke
2016-09-24 0:23 ` Ben Woodcroft
2016-09-24 3:15 ` Marius Bakke
2016-09-26 11:15 ` Ben Woodcroft
2016-09-26 18:32 ` Marius Bakke
2016-09-27 11:01 ` Ben Woodcroft
2016-09-30 20:12 ` Ludovic Courtès
2016-09-17 10:10 ` [PATCH 3/3] gnu: python2-pbcore: Update to 1.2.10 Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d81c47-a96d-1f1c-ad1d-a80e7b7f109d@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).