From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8F77CnJ5oWV1KAAAkFu2QA (envelope-from ) for ; Fri, 12 Jan 2024 18:40:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CKKlBXJ5oWWrUwEA62LTzQ (envelope-from ) for ; Fri, 12 Jan 2024 18:40:02 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EHwM8o3G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705081202; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gdpoXm3B65QNzROzW3Of+34nv2Z1XeQPuajjNP2KzX8=; b=TQ1r5x1aNKpEP2c9mSb1nlvvcZht0GAU9zIeBFf4z60mMhkPb1vt6qhXXxmj4wdMuXLmUZ oinY95iLDEhk+nCQw7DbppYMXA19FFsXBKAnkaEnaA8qOaUcFQQpIwid66RnOqRU/2AZMX Hb5j1K4StAeTt0b6Rj5nPsQV2cprBiXIDP4ycHIZKZUgUMafoEnPud+D/oM89AvBRiVdgT PLuu+ChDScec6PYQ4JLmKG4ft9MNXArQOtPQUjYN2RJhCjTGQ9sQrD/Kzj6vx3mnx+k6b1 aggYp9OYahu4jqKVRusjFk5yiiGzYdni9oF/17aRB2ZLjICVWVbMoa241iTOSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705081202; a=rsa-sha256; cv=none; b=UzYXdtONw1qyxolZuO+5RpDAFVpYzsVPpRR41q+0BnR06YboxT2eo/ikR0QfVAzMW2f0ph RHEaNKxoEK3aN6DtMjB3jlvm0+xjMpcksnL2xh65xaGfzYo3wbl7oAXoew+fKY0XxKSaTu 66t8QS5o4VrizSomsDgEMux+UEFs2hh+fD2uQ6N4mPPY4G4AP91KYmphWD92X8hI7/GPsh vvF6PMRtX4yBzOGgLcrewJegUfGLS/Kk0K7pBdNsjsbzW9u2HKeCDYrGQaai0sH0Y+Jozw q3sLYgcqObhRiKmaIVHjUKnHgA+CW0sGbOpMfnU4ejMqXBM3F7tL8/XaoHNhOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EHwM8o3G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 026226A809 for ; Fri, 12 Jan 2024 18:40:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOLV5-0004fR-2A; Fri, 12 Jan 2024 12:39:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOLV3-0004ex-6N for guix-devel@gnu.org; Fri, 12 Jan 2024 12:39:21 -0500 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOLUu-0007Fx-Nj; Fri, 12 Jan 2024 12:39:14 -0500 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-55783b7b47aso6928896a12.0; Fri, 12 Jan 2024 09:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705081149; x=1705685949; darn=gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=gdpoXm3B65QNzROzW3Of+34nv2Z1XeQPuajjNP2KzX8=; b=EHwM8o3GoDCl9G0DZ7HtkxvxmmJjuiEKlsrODsNPQ5TDX68VSys7YggLkn9KSrZufM JLtQrLreseRItG0sOpFs49wl2pHpu50Wb7IrTbg7I3PsbQlc8PcYtzzHEHgmKVlsAj+R ZHIqkOGvwe/m5SCVSJbww1X7o/eTEF4Lu/l/QCD0gMZvFn/f/WyvmjiPc/esudtw2DOy 4Da4IJm5wwOMrItsMc0CYDVjMViqjFkx/2n0KF07jUwzoOWiAM12OmPokPEtH1hcNhL4 ADPylcMEZISq2RzaYQjrjU4uVHc9ZhkOm7Vy/du/m0Xc1tj1YAvXUtZyQBibDfp+z2rS WALQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705081149; x=1705685949; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gdpoXm3B65QNzROzW3Of+34nv2Z1XeQPuajjNP2KzX8=; b=TtEMWG7Hn/6VNzru0ltbGVc/Y7vBfAlc/7EeWPl7GHLFJhnJTv2Q3Sx7oUql5QJuN+ +VDpERlwldefjVVCh5fJngQ2GuO81+ZttraGW88Bia5grle2wt8Pw3Znamr4ibxbyO0M hjFpNECbIDLyT30OAhbX3q9yy8/g2cDeN9YNdeCCBGQqUuP3lC/j0uKNTzbqcOt/8tG9 ozWEsteUmvkyq+lvSsjat04csZ97GgwGSVJLJg9cF7bsgsv3aySbJfi9pv/xIbwTZD8O QlOnSCD8AnyEUP8t6d2UAWyzFrwCtOgwFAOvRvDRxltxVmOYGmAvWNudPa/a9DaAMHOd DLXw== X-Gm-Message-State: AOJu0YxZXNAaohGxB5DNOfCNqcXekKK+e9vklcVeyuWYjgnYyZdQMp+M DfjDlNZDvvg43BQd8ASU/w0= X-Google-Smtp-Source: AGHT+IFPDZP/aZA3rVIwkgT+Npscx5S6KL0Qi879UBOmEZl1if3d64WMu/fdemCdaMo3bINRRY/l4A== X-Received: by 2002:aa7:d547:0:b0:558:7656:8b07 with SMTP id u7-20020aa7d547000000b0055876568b07mr848455edr.49.1705081149117; Fri, 12 Jan 2024 09:39:09 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i30-20020a50871e000000b00557dc13185esm2094225edb.49.2024.01.12.09.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 09:39:08 -0800 (PST) Message-ID: <37da112158ce2ecd4505742c573af37e74c271cf.camel@gmail.com> Subject: Re: $EDITOR and =?UTF-8?Q?=E2=80=9Cguix?= =?UTF-8?Q?_edit=E2=80=9D?= From: Liliana Marie Prikler To: Simon Tournier , Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: Guix Devel Date: Fri, 12 Jan 2024 18:39:07 +0100 In-Reply-To: <87r0imyjvp.fsf@gmail.com> References: <86wmv0o5gi.fsf@gmail.com> <416a6472edf6d2123c47ea5b555bedd005f6ac6f.camel@gmail.com> <87r0kpu3d9.fsf@gnu.org> <246521d6a06ee6954372278b8507c346fcc068cb.camel@gmail.com> <86h6lg3gq0.fsf@gmail.com> <87r0imyjvp.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::541; envelope-from=liliana.prikler@gmail.com; helo=mail-ed1-x541.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.02 X-Spam-Score: -9.02 X-Migadu-Queue-Id: 026226A809 X-TUID: J1q8lkjeP5Rp Am Freitag, dem 12.01.2024 um 10:35 +0100 schrieb Simon Tournier: > Hi, >=20 > On Mon, 20 Nov 2023 at 20:33, Liliana Marie Prikler > wrote: >=20 > > > =C2=A02. Do we put this code in some etc/vscode-wrapper that user can > > > =C2=A0install?=C2=A0 (or that we could automatically installl) Or may= be > > > revamp it=C2=A0for calling this code via some shell function? > >=20 > > With VSCode et al. not being Guix packages, I see little point in > > providing these wrappers through Guix itself. >=20 > I do not want to address here where to keep VSCode support and > instead I would like to address $EDITOR which does not follow the > good ol=E2=80=99 fashion. >=20 > Well, I see how to write specific Scheme wrapper around $EDITOR; as I > did in [1]. >=20 > Or, I see how to tweak guix/scripts/edit.scm for running specific > launcher depending on $EDITOR. >=20 > Liliana, could you provide a proof-of-concept about =C2=AB the shell-esqu= e > "${LINE}" and "${FILE}" that would get replaced by Scheme code > looking for those strings =C2=BB?=C2=A0 Because I do not see what you mea= n. (let* ((editor (getenv "GUIX_EDITOR")) (editor (string-replace-substring editor "${FILE}" the-file)) (editor (string-replace-substring editor "${LINE}" the-line))) editor) with the-file and the-line being placeholders for the actual variable names. You could obviously do smarter things with gash, but let's not go there at the moment. > Cheers, > simon >=20 > 1: > https://gitlab.com/zimoun/advanced-packages-2023/-/blob/main/vscode-wrapp= er?ref_type=3Dheads >=20 > PS: >=20 > About VSCode.=C2=A0 Somehow, it is a chicken-or-the-eggs problem.=C2=A0 = =E2=80=9CWe=E2=80=9C > cannot complain with lengthy threads about the lack of contributor > diversity, or that many Guix tools are Emacs-centric, etc. and in the > same time say no because VSCode is not packaged in Guix proper. >=20 > We like it or not =E2=80=93 I do not like it and do not use it! =E2=80=93= for sure, > VSCode is currently one of the most used editor around.=C2=A0 Being > friendly with VSCode users would help to have more contributions from > them. Speaking of diversity, how well does your wrapper work for Atom? Or Kate? IMHO, going out of our way to specifically support VSCode would break not one, but at least two of our core principles, whereas offering an option that you can plug any $EDITOR into would not only be the technically, but also morally superior choice. =20 Cheers