From: Maxime Devos <maximedevos@telenet.be>
To: guix-devel@gnu.org
Cc: Martin Becze <mjbecze@riseup.net>
Subject: Removing #:skip-build? from the crate importer?
Date: Thu, 31 Mar 2022 13:55:06 +0200 [thread overview]
Message-ID: <32ae0e474e295fa7f7052abd1bbb8053d2fddf16.camel@telenet.be> (raw)
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
Hi guix,
Often, when new rust package definitions are submitted at guix-
patches@, I see #:skip-build? #false. Apparently it's added by default
in (guix import cargo), with some exceptions. However, ‘(guix)Rust
Crates’ states:
Care should be taken to ensure the correct version of dependencies
are used; to this end we try to refrain from skipping the tests or
using ‘#:skip-build?’ when possible. Of course this is not always
possible [...]
so I respond by asking to remove #:skip-build?.
As such, WDYT of removing #:skip-build? #false from (guix import
crate)? FWIW, this was added in commit
269c1db41bd82f93c7ae5c62a4969a423e556183 to (guix import crate)?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next reply other threads:[~2022-03-31 12:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 11:55 Maxime Devos [this message]
2022-03-31 19:47 ` Removing #:skip-build? from the crate importer? Hartmut Goebel
2022-03-31 20:06 ` Compiling rust things without cargo (super WIP POC) Maxime Devos
2022-04-01 6:58 ` Brendan Tildesley
2022-04-01 9:10 ` Ludovic Courtès
2022-04-01 10:05 ` Maxime Devos
2022-04-01 10:08 ` Maxime Devos
2022-04-02 15:01 ` Hartmut Goebel
2022-04-02 9:29 ` Maxime Devos
2022-04-05 12:08 ` Ludovic Courtès
2022-04-02 15:18 ` Building hexyl (a rust app) without cargo, with antioxidant-build-system Maxime Devos
2022-04-05 16:10 ` Maxime Devos
2022-04-06 15:49 ` Hartmut Goebel
2022-04-06 16:06 ` Maxime Devos
2022-05-30 8:23 ` Efraim Flashner
2022-05-30 13:37 ` raingloom
2022-05-30 15:15 ` Maxime Devos
2022-04-02 15:19 ` Compiling rust things without cargo (super WIP POC) Hartmut Goebel
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 19:07 Removing #:skip-build? from the crate importer? Liliana Marie Prikler
2022-03-31 19:14 ` Maxime Devos
2022-04-02 9:45 ` Hartmut Goebel
2022-04-02 10:53 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ae0e474e295fa7f7052abd1bbb8053d2fddf16.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guix-devel@gnu.org \
--cc=mjbecze@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).