From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wKTAIN6A3mKOGgEAbAwnHQ (envelope-from ) for ; Mon, 25 Jul 2022 13:39:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qCCzH96A3mImzQAAG6o9tA (envelope-from ) for ; Mon, 25 Jul 2022 13:39:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 405C11AE20 for ; Mon, 25 Jul 2022 13:39:10 +0200 (CEST) Received: from localhost ([::1]:53354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFwQX-0006kd-2O for larch@yhetil.org; Mon, 25 Jul 2022 07:39:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFwPy-0006kU-Ol for guix-devel@gnu.org; Mon, 25 Jul 2022 07:38:35 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:34504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFwPw-0006re-KL for guix-devel@gnu.org; Mon, 25 Jul 2022 07:38:34 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 4cd362c5; Mon, 25 Jul 2022 11:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=GrdIHYu0JJ4/ MfnC8upjVJyt6E0TKkL297h2TUAFvIQ=; b=DPS+0SoOsMwt/4Mtph6DtHlmYe2e 7n2XMUBOR7GXKQ5o4DbqdKZ6IQ+Ez3ransj/r8jktMqGgi+UK8OMjmE7FbxU5nio tJTgNAZmx7ljEcBAANPpfoUN2ewPLguhA5REI1x+Use72AviIYLYBnbAO+JpGKPR FIrUDYajvtIvP3GBI7rqdW6axcOeBO3oTqbyi7EHsdKLlAlcBBvbdghtDrlwpXSH a9AdJcsW/Iyd0vJIHYsUZaM1CnsRDlr41atFuPdFRFMwOMBHlO48seZcUrGh0FlK gOKdToKZXwSNtgqF2sSzCGP7yAfAbpCf7CoRM3o9RQG0Y4BDDYrcguuW+g== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id cf512f73 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 25 Jul 2022 11:37:21 +0000 (UTC) Date: Mon, 25 Jul 2022 13:37:15 +0200 From: Julien Lepiller To: Maxime Devos , guix-devel@gnu.org Subject: =?US-ASCII?Q?Re=3A_A_proposal_of_a_consistent_set_of_clear_rules_an?= =?US-ASCII?Q?d_guidelines_involving_snippets=2C_phases_and_patches=2E?= User-Agent: K-9 Mail for Android In-Reply-To: References: <291DF0C6-5C59-4F04-8959-E770841BF448@lepiller.eu> Message-ID: <322A57BF-F064-4D1E-9258-86B2EB02C75A@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----PCNOEO765WOWG7CBMN84LMQL3AJF2N Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658749150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=GrdIHYu0JJ4/MfnC8upjVJyt6E0TKkL297h2TUAFvIQ=; b=WuZ1cEhu5ybKLS22tuvVww+v/77P3Q3TV9/zTTnq0OqX5jeBDIWtn88ASX7ZmI7gsn+N0h Gl6Vm/tJutVaNUAqmE2nJerh4lkrjWI3iCfpZ9YwoIcWD+n+2gBBeS/xtweU8V/key9+Ds rK3DX+hq6CtkN0Jc3Sb+GVvpJ+ON6B+CwyMHkCUj4EbdSA7ZYjhiuPQz1pA+/2cYMS5BIn FPLEUHc18OSHyurZkw4DYbFHP/IJBg8jdrbPnvZDDjrGxTO14wpQ1dlXU2UqBMo0hmfyhH 5C7VOgcxD13Gd822hGJ0VvKjevMy4bj23+Z5+zObvZAn3mB6iDbHiYmgDzx3yw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658749150; a=rsa-sha256; cv=none; b=gXGDlZtymkDm5qHQWvx25+QoelTSU0o3mSPMoYGwxhJKORopY6cPLedQBl0KPce9CETafU Ciohoqctcu4wIqfukDMh6vw3QLJv7F/RagLp6h7cxPGw5KYPD70qwavsHEmclw+CA3qFcf FXP4K3oxiUFHyT6Hfof8j0JrL6L2ENdh4KFjavDdEo3K6GZgroNYllI49Kf3wWR8VYdXmW qY/v7gNrKjainHIP/OE7818Hlb68UHJxeiSveomUWkFoXEQa3lNzMD0pwGpc445YOhUt7Z qnKw1s5KIs0L6BCnO/2BK2hziXbxyo4SlIEuhTYpuj/6y8WMbiDm/+olD+0kdw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lepiller.eu header.s=dkim header.b=DPS+0SoO; dmarc=pass (policy=none) header.from=lepiller.eu; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.23 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lepiller.eu header.s=dkim header.b=DPS+0SoO; dmarc=pass (policy=none) header.from=lepiller.eu; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 405C11AE20 X-Spam-Score: -6.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: wOIV8xCgFE36 ------PCNOEO765WOWG7CBMN84LMQL3AJF2N Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I agree that we should better document that policy=2E I think we could go f= urther, but it's ok to document the common denominator first=2E To me, the = structure you suggest is not great, but I don't have issues with the conten= t=2E Le 25 juillet 2022 13:18:28 GMT+02:00, Maxime Devos a =C3=A9crit=C2=A0: > >On 25-07-2022 07:21, Julien Lepiller wrote: >> I don't like the wording at all=2E You're mixing too many things togeth= er=2E >Feel free to try to separate the things, but going previous discussions, = many tings are important, and they appear all to be inseparable=2E >>=20 >> I think it would be better to first document the guiding principles (eg= =2E the goal that there are no non-free software in Guix, going for the sim= plest thing, etc) and then derive rules for specific cases, based on these = principles: >>=20 >> How do I remove non-free software? -> snippet because =E2=80=A6 >>=20 >> How do I remove bundled libraries? -> snippet or phase because =E2=80= =A6 >>=20 >> How do I fix a build issue? -> patch or snippet if this affects buildin= g from source, can also be a phase if the result of --sources can still bui= ld >>=20 >> A test issue? >>=20 >> =E2=80=A6 >>=20 >> This leaves some cases up to interpretation, but that's probably not so= different from "it's not an absolute rule"=2E It's also much clearer and q= uicker to figure out in which case you are=2E If not documented as a case, = you can fall back to the general principles=2E > >TBC, is the issue here the structure of the section, or some individual r= ules? In the former case, I could try rewriting it a bit to follow your pro= posed structure=2E > >Greetings, >Maxime=2E ------PCNOEO765WOWG7CBMN84LMQL3AJF2N Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I agree that we should better document that policy= =2E I think we could go further, but it's ok to document the common denomin= ator first=2E To me, the structure you suggest is not great, but I don't ha= ve issues with the content=2E

Le 25 juill= et 2022 13:18:28 GMT+02:00, Maxime Devos <maximedevos@telenet=2Ebe> a= =C3=A9crit=C2=A0:

On 25-07-2022 07:21, Julien Lepille=
r wrote:
I don't like t=
he wording at all=2E You're mixing too many things together=2E
Feel free to try to separate the things, but going previous discussions=
, many tings are important, and they appear all to be inseparable=2E

I think it would be bette=
r to first document the guiding principles (eg=2E the goal that there are n=
o non-free software in Guix, going for the simplest thing, etc) and then de=
rive rules for specific cases, based on these principles:

How do I r=
emove non-free software? -> snippet because =E2=80=A6

How do I re=
move bundled libraries? -> snippet or phase because =E2=80=A6

How=
 do I fix a build issue? -> patch or snippet if this affects building fr=
om source, can also be a phase if the result of --sources can still build
A test issue?

=E2=80=A6

This leaves some cases up to in=
terpretation, but that's probably not so different from "it's not an absolu=
te rule"=2E It's also much clearer and quicker to figure out in which case =
you are=2E If not documented as a case, you can fall back to the general pr=
inciples=2E

TBC, is the issue here the structure of the=
 section, or some individual rules? In the former case, I could try rewriti=
ng it a bit to follow your proposed structure=2E

Greetings,
Maxim=
e=2E
------PCNOEO765WOWG7CBMN84LMQL3AJF2N--