From: Maxime Devos <maximedevos@telenet.be>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Arun Isaac <arunisaac@systemreboot.net>, Guix Devel <guix-devel@gnu.org>
Subject: Re: Move switch-symlinks to (guix build utils)
Date: Fri, 03 Jun 2022 19:09:02 +0200 [thread overview]
Message-ID: <2c194c3b2f192ba49caaf585703f95b6c6bcb7d9.camel@telenet.be> (raw)
In-Reply-To: <8735glk8gs.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
Ludovic Courtès schreef op vr 03-06-2022 om 18:38 [+0200]:
> That’s EACCES?
It's EEXIST.
> > If we move it to (guix build utils), I'd prefer the bug to be addressed first.
>
> Yes, better be cautious before “setting it in stone”. Do you have a fix
> in mind?
Maybe replace
(symlink target pivot)
by (symlink/remove-old target pivot)
where
(define (symlink/remove-old target link)
"Make a symbolic link named LINK pointing to TARGET.
If LINK already exists, it will be removed first.
This is not an atomic operation."
(catch 'system-error
(lambda ()
(symlink target link))
(lambda stuff
(if (= (system-error-errno stuff) EEXIST)
(begin
;; remove old link and retry
(delete-file link)
(symlink/remove-old link target))
(apply throw stuff)))))
?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-06-03 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:34 Move switch-symlinks to (guix build utils) Arun Isaac
2022-06-01 12:09 ` Maxime Devos
2022-06-02 15:06 ` Arun Isaac
2022-06-02 15:13 ` Maxime Devos
2022-06-03 16:38 ` Ludovic Courtès
2022-06-03 17:09 ` Maxime Devos [this message]
2022-06-03 19:30 ` Ludovic Courtès
2022-06-03 19:30 ` Ludovic Courtès
2022-06-03 23:55 ` bokr
2022-06-04 10:17 ` Maxime Devos
2022-06-06 11:27 ` Arun Isaac
2022-06-06 12:20 ` Maxime Devos
2022-06-08 20:12 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c194c3b2f192ba49caaf585703f95b6c6bcb7d9.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=arunisaac@systemreboot.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).