unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* gnome-characters
@ 2019-11-17  0:50 Raghav Gururajan
  2019-11-17  1:32 ` gnome-characters sirgazil
  0 siblings, 1 reply; 2+ messages in thread
From: Raghav Gururajan @ 2019-11-17  0:50 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 365 bytes --]

Hello Guix!

So I was able to successfully package 'gnome-characters'. The following
is the package definition. I have attacted the package definition
(gnome-characters.scm) with this email.

This is the first time for me with packaging. Can anyone help me how to
move forward from here, to integrate this with guix upstream?

Thank you!

Regards,
RG.

[-- Attachment #1.2: gnome-characters.scm --]
[-- Type: text/x-scheme, Size: 1069 bytes --]

(use-modules
	(guix packages)
	(guix download)
	(guix build-system meson)
	(guix licenses)
	(gnu packages libunistring)
	(gnu packages pkg-config)
	(gnu packages gnome)
	(gnu packages gtk)
	(gnu packages gettext)
	(gnu packages glib))

(package
	(name "gnome-characters")
	(version "3.30.0")
	(source
		(origin
			(method url-fetch)
			(uri
				(string-append "https://download.gnome.org/sources/gnome-characters/3.30/gnome-characters-3.30.0.tar.xz"))
			(sha256
				(base32 "08cwz39iwgsyyb2wqhb8vfbmh1cwfkgfiy7adp08w7rwqi99x3dp"))))

	(build-system meson-build-system)

	(inputs
		`(
			("libunistring", libunistring)
			("pkg-config", pkg-config)
			("gjs", gjs)
			("gtk+", gtk+)
			("gettext", gettext-minimal)
			("glib:bin", glib "bin")
			("gtk+:bin", gtk+ "bin")))

	(synopsis "GNOME Characters")

	(description "Characters is a simple utility application to find and insert unusual characters. It allows you to quickly find the character you are looking for by searching for keywords.")

	(home-page "https://wiki.gnome.org/Apps/Characters")

	(license gpl2))

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: gnome-characters
  2019-11-17  0:50 gnome-characters Raghav Gururajan
@ 2019-11-17  1:32 ` sirgazil
  0 siblings, 0 replies; 2+ messages in thread
From: sirgazil @ 2019-11-17  1:32 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: guix-devel

---- On Sat, 16 Nov 2019 19:50:12 -0500 Raghav Gururajan <raghavgururajan@disroot.org> wrote ----

 > Hello Guix! 
 >  
 > So I was able to successfully package 'gnome-characters'. The following 
 > is the package definition. I have attacted the package definition 
 > (gnome-characters.scm) with this email. 
 >  
 > This is the first time for me with packaging. Can anyone help me how to 
 > move forward from here, to integrate this with guix upstream? 

Maybe it could help to read the Contributing section in GNU Guix Reference Manual (https://guix.gnu.org/manual/en/html_node/Contributing.html#Contributing). You will find packaging guidelines and information about submitting patches to add your package. I haven't submitted any package myself yet, but I would start there, and ask here in case of doubts.

Some things I noticed in your package definition:

• Indentation probably does not follow the coding style of Guix.
• Is the value for "home-page" correct? Maybe it should be https://wiki.gnome.org/Design/Apps/CharacterMap instead?
• In origin's uri there seems to be an unnecessary use of "string-append", as you are only passing one string (not appending two or more).



---
https://sirgazil.bitbucket.io/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-17  1:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-17  0:50 gnome-characters Raghav Gururajan
2019-11-17  1:32 ` gnome-characters sirgazil

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).