From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kOqdMqFqIWAbdgAA0tVLHw (envelope-from ) for ; Mon, 08 Feb 2021 16:45:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UPaZLqFqIWDJPgAA1q6Kng (envelope-from ) for ; Mon, 08 Feb 2021 16:45:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89D079401DF for ; Mon, 8 Feb 2021 16:45:21 +0000 (UTC) Received: from localhost ([::1]:37898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l99f6-0007cO-I5 for larch@yhetil.org; Mon, 08 Feb 2021 11:45:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l92xs-0000bK-OX for guix-devel@gnu.org; Mon, 08 Feb 2021 04:36:18 -0500 Received: from michel.telenet-ops.be ([2a02:1800:110:4::f00:18]:57544) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l92xR-0008Fi-Ea for guix-devel@gnu.org; Mon, 08 Feb 2021 04:36:04 -0500 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id SZbg2400u0mfAB406Zbgr0; Mon, 08 Feb 2021 10:35:41 +0100 Message-ID: <269e9382c2ded165554b18e07fb7ab4005dfa805.camel@telenet.be> Subject: Re: ZFS on Guix From: Maxime Devos To: raid5atemyhomework Date: Mon, 08 Feb 2021 10:35:40 +0100 In-Reply-To: References: =?us-ascii?Q?<=5F1CLe9QSGsoMlu5WxBMXm4CbFLM=5FM9iRG1XQF9GDsK0GP208jpngdymfix4tAfoLP94mhMTt-Tx6OP2xN=5Fn78Jhx5KQzkiqPpIci=5F44C9OI=3D@protonmail.com> _<5DEAAAD8-1D08-4489-9AEC-675618F8E388@zancanaro.id.au> _ _ _ _<07kwAFNpjhGFe7ArkjjAtRhr564wvMPGhHFyjGb=5FXdmmPNddKTmT9Swky1NbbUxHBC4xw3p-m=5F3JyW16Ql9J7PLyk6UdhCsA2cdkHehdti8=3D@protonmail.com> _ _ _ ?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-fhGljEMaFI/TLCHcFCpy" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1612776941; bh=ODxXDqe/X0GIwojMqAlIjSE8TIhTpwHheSVIduQ52m0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=cc+oog7CSkzMtKnYAlnIhkMrqv8q+HLUNWPPlxUfB75t0ttESHwOii3hCO9ovNmsM WCECfD2OvVDRiQQDmmQAHEoYhj+YEYJ53S3EdGG48m9PnsBNdWhor3AX0NB13SCbtr GFuG+22SXGHUXiSbHCMe7hX4XPkkQUSynAt5vqi5up2yJN9uEWzFtJrLYO993Ig9DG 9Yu47SfzRiwWmO91HPQ2BxcmnLB5r+7mv0XAcDOiegHnb9uujL8COQj0CmhSvhHX4P R3OIQxGK0fT4qQJTsNLH9B0OKSk8BomBgpqf/w54OuW6ES+e21J6yMkiYmVc0yCvxf zKDUFSgDzgSdw== Received-SPF: pass client-ip=2a02:1800:110:4::f00:18; envelope-from=maximedevos@telenet.be; helo=michel.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAD_ENC_HEADER=0.001, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.16 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=cc+oog7C; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 89D079401DF X-Spam-Score: -5.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: dZK6k8tEDk/l --=-fhGljEMaFI/TLCHcFCpy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2021-02-08 at 09:32 +0000, raid5atemyhomework wrote: > > * the shepherd services defined in `configuration.scm` > > seem one-shot services to me, so maybe add '(one-shot? #t)'. >=20 > I was wary of making the `zfs-scan` one-shot, since there is a dependent = service on top of it. Not to mention restarting `zfs-scan` could be useful= if for example you were doing hotswapping of devices. Maybe. >=20 >=20 > > * in the 'stop' of zfs-automount, the code changes the working > > directory. As it isn't restored afterwards, this doesn't seem > > kosher to me. Or maybe this isn't an issue at all. >=20 > The code is modeled after `file-system-shepherd-service` procedure in `gn= u/services/base.scm`, which includes a `(chdir "/")` as well with the comme= nt "Make sure PID 1 doesn't keep TARGET busy.". Since this also does files= ystem mounting/unmounting, I judged it best to imitate the existing filesys= tem mounting/unmounting service. Ok, seems reasonable to me! --=-fhGljEMaFI/TLCHcFCpy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYCEF7BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iOeAQCsmqu0KATg0fwnoOp8MYfEDLMk gELevwGKd2bkpHJjnAD/T5Qzsx+FjfQ6ksJcFrMmY9JZQeBGgaBnCiGWRK3rmg8= =VVDc -----END PGP SIGNATURE----- --=-fhGljEMaFI/TLCHcFCpy--