From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8GkNICKMcGFtHgAAgWs5BA (envelope-from ) for ; Wed, 20 Oct 2021 23:37:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eAW8GyKMcGGSbwAA1q6Kng (envelope-from ) for ; Wed, 20 Oct 2021 21:37:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 28BF929D00 for ; Wed, 20 Oct 2021 23:37:38 +0200 (CEST) Received: from localhost ([::1]:48048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdJHF-0004k7-7c for larch@yhetil.org; Wed, 20 Oct 2021 17:37:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdJH0-0004jk-KS for guix-devel@gnu.org; Wed, 20 Oct 2021 17:37:22 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:50784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdJGx-0003Nk-OE; Wed, 20 Oct 2021 17:37:21 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 084FCBD5; Wed, 20 Oct 2021 23:37:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1634765832; x=1636580233; bh=eo1jj4yjqlX0i4FT0MzaZgRrTx6UIXwybId NvhaC6U8=; b=pLa+UTIhUTyVUwFzE3lM64n3IbrRxD4jiw/ya1Yrayjvj3xZ9Dg hafSvmq0JF+EPlpTCe98yxQqYNFDHXfjLWOZ2VVU/Y8miWimetNy4PLvG0VZMEJW FJv7U5fpkjJKOVO2jzgR/mw8LbTKprApeUTJmGwsmxZv9UV/5Lzbg9+gHYfv4f+9 MpcQaQ7mHbajM76C9GOTAqOfnPstb/mAZc80O9ubeH7Lxa133YrMX1j7ZhrV/J10 U3F6K8mqmifoqJtfBm6zsFXF/u/LpPYva3VjVYjA1l4cU6mfLYrpZBiGeoQHY8Wq neKidhMi3B9y3dAWnrOVjQoTf3NJGX5SicMPuhVY3SoyF1KAfxFzOkCbc43yHVL8 9nSa7V+sVsIxKh+2yhIFDOZ70lUeSTMahZUsHyCKxo/hP9JILqW9La+uAMUrXbKW ZSaseMwz0fk1kJpZSVw42EWv9gCAiY+paxHfUqKRsADHySAQvqhMluxhzB/B018i yjzd19v2kQzCKHuTak3G1gNDUyrgRNsWB4KZx63uPwaPaAMFbd6jFnmYnszWDgY2 fq/GmE7weGHbYhFHRslmZmJNDAA6I3u6I3m1no3jlaa49FP55BYxo8HwXudeqw5E n5/mT9drtcD+4pBbxuWE+UOwMCVhjhN/W1QyWDxodSjUmQF5giXFXctw= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XcvFy7_rlyyQ; Wed, 20 Oct 2021 23:37:12 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by mx.kolabnow.com (Postfix) with ESMTPS id B5E69BB2; Wed, 20 Oct 2021 23:37:12 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 1D7EE48E0; Wed, 20 Oct 2021 23:37:11 +0200 (CEST) From: Thiago Jung Bauermann To: zimoun , guix-devel@gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: Incentives for review Date: Wed, 20 Oct 2021 18:37:06 -0300 Message-ID: <2525618.Ivme1NzmDS@popigai> In-Reply-To: <87mtn56mzg.fsf_-_@inria.fr> References: <874k9if7am.fsf@inria.fr> <86k0i9drh5.fsf@gmail.com> <87mtn56mzg.fsf_-_@inria.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=95.128.36.41; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634765858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=eo1jj4yjqlX0i4FT0MzaZgRrTx6UIXwybIdNvhaC6U8=; b=UBWGWP8fmQdh3RtC/UosLketSHKdIdVUkoNZpO0gv5dc5o7tKx2T9n9czJvaiJIVgx/Fhd 5qWhSc1JuYF6Mha1aF48KIykNrCW7QLi3R6OFQxY4Qvyg2PHCsd9osfIZiFz0SEoXBkD4K IqKn7Cb/jipnAGbuTfIgA1by5N8cv40lqEneaboZ+MYETD7hzHgkidy5qCOwr+TL976B06 uNHzg416ammlHAy+sAi4qW6CI04sAeQldlyfZPdwyDU36lCbFIRjz70Tcf+M0tn+f55GTZ mFkRoqDovNE41qcHJz3aIiDs0dkV1QlQy+gaRFODrpuw5Lo56J25/2Wyb06SkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634765858; a=rsa-sha256; cv=none; b=ZCBMbNi62zYmzBwezpZQexdTqkRSm+6NwRH3OWovKNR7rwvzvSkQxpb/D97pl3kNyPhIKb It68Lgo+QQxupoktayUNr8hX7vJXsERdHma5Gc6HAov5Kx54F8cunB5KYmStQfytJWZ43t K9+H3XzHCNEU+iu6bxSPesU39E+THPlQbB7lIY9c2aXO9N8U5/QslKZXWyPPwjNU10SEPi BIuAqItkq/cydWZHIZoTvQ+LL22E2qLnTvxUQsZuSUCnB4alCK7BtA5f9JikVSelNFnbA6 EojUPgtFIw3jTo8NDbxk6myHOaUz7uzzLnyVHuR8ZznEme9l77k6DSG0hO2GgQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=pLa+UTIh; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.53 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=pLa+UTIh; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 28BF929D00 X-Spam-Score: -3.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: zqGL8EulyB+7 Hello, Em ter=C3=A7a-feira, 19 de outubro de 2021, =C3=A0s 12:41:23 -03, Ludovic C= ourt=C3=A8s=20 escreveu: > zimoun skribis: > > On Tue, 19 Oct 2021 at 14:56, Ludovic Court=C3=A8s=20 wrote: > [...] >=20 > I would like to see us committers do more review work. But I also view > things from a different angle: everyone contributes in their own way, > and each contribution is a gift. We can insist on community > expectations (reviewing other people=E2=80=99s work), but we should also = welcome > contributions as they come. Thank you for viewing it from that angle. On a personal note, I=E2=80=99m a= ware=20 that my ratio of patches reviewed / patches posted approaches zero and this= =20 makes me a bit uncomfortable every time I type `git send-email`. Sometimes I try to review patches, but it=E2=80=99s not a very productive e= ndeavour=20 for a few reasons: 1. In many cases, I don=E2=80=99t see anything wrong with the patch I=E2=80= =99m looking at.=20 In those cases I could reply saying so, but I refrain from doing that=20 because if such message comes from someone who doesn=E2=80=99t have much ex= perience=20 in the part of Guix that the patch touches (which is almost always the case= =20 for me when reviewing patches), then how much values does that really add? 2. Going through the guix-patches mailing list looking for submissions that= =20 touch the few areas of Guix where I have at least some experience. I don=E2= =80=99t=20 think I found an effective method yet (in part the problem is on my side=20 because the search function of the email client I use isn=E2=80=99t very re= liable). > There=E2=80=99s a balance to be found between no formal commitment on beh= alf of > committers, and a strict and codified commitment similar to what is > required for participation in the distros list=C2=B9. >=20 > A good middle ground may be to provide incentives for review. How? I=E2= =80=99m > not sure exactly, but first by making it clear that review is makes the > project move forward and is invaluable. You once proposed having > =E2=80=98Reviewed-By=E2=80=99 tags to acknowledge non-committer reviews, = and I think > that would be one step in that direction. I like the =E2=80=98Reviewed-by=E2=80=99 idea and I agree that it provides = a tangible=20 incentive. A =E2=80=98Tested-by:=E2=80=99 tag would have the same effect as= well, as=20 suggested by simon. > Perhaps there are other things we could do? One thing that would help me would be some way to =E2=80=9Csubscribe=E2=80= =9D to changes in=20 certain areas of Guix. That way, when a patch is submitted which touches=20 those areas I would be automatically copied on the emails that go to the=20 guix-patches mailing list. =E2=80=9Careas of Guix=E2=80=9D could be defined= by paths in the=20 repo, guile modules or regexps matching package names, for example. =2D-=20 Thanks, Thiago