From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2MgSLrANX2AnEgAAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 11:49:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oM7/J7ANX2AFRwAA1q6Kng (envelope-from ) for ; Sat, 27 Mar 2021 10:49:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4AB171AE7D for ; Sat, 27 Mar 2021 11:49:20 +0100 (CET) Received: from localhost ([::1]:60626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQ6VL-0005pP-5c for larch@yhetil.org; Sat, 27 Mar 2021 06:49:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQ6Up-0005pF-Ft for guix-devel@gnu.org; Sat, 27 Mar 2021 06:48:47 -0400 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:36074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQ6Un-0001PP-17 for guix-devel@gnu.org; Sat, 27 Mar 2021 06:48:47 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F6wXS72VPz1s2mZ; Sat, 27 Mar 2021 11:47:36 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F6wXS6pKMz1qrxY; Sat, 27 Mar 2021 11:47:36 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Kjrt8-Eeh_r9; Sat, 27 Mar 2021 11:47:35 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-54-236.dynamic.mnet-online.de [188.174.54.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sat, 27 Mar 2021 11:47:35 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 4E860600E6; Sat, 27 Mar 2021 11:52:38 +0100 (CET) Subject: Re: 03/163: build/python: Add a new guix-pythonpath procedure. From: Hartmut Goebel To: Maxim Cournoyer References: <20210125070022.22870.17321@vcs0.savannah.gnu.org> <20210125070114.03C0B20E1C@vcs0.savannah.gnu.org> <87czxs3d1i.fsf@gnu.org> <878s8g3bxa.fsf@gmail.com> <87lfcdm9jb.fsf@gnu.org> <87im7fyg5c.fsf@gmail.com> <871rd296yo.fsf@gmail.com> <3c1b9db7-e849-a863-b6e3-a40c12702389@crazy-compilers.com> <87lfaqtutw.fsf@gmail.com> Organization: crazy-compilers.com Message-ID: <23eed2e2-69ad-64e3-aa89-8102a9038369@crazy-compilers.com> Date: Sat, 27 Mar 2021 11:47:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <87lfaqtutw.fsf@gmail.com> Content-Type: multipart/alternative; boundary="------------E13CC7A9CB1599CFCC885719" Content-Language: en-US Received-SPF: none client-ip=2001:a60:0:28:0:1:25:1; envelope-from=h.goebel@crazy-compilers.com; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616842160; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=M5HKTRJ/wbldamjSk6vNVBciKODWo7sN0IRVVt2Quyg=; b=liItZ9urugWxVHbmOe9RE6LQb/QnOm1iG8gShtM2E+6yJnuTlUbqNJHupVYjRM45pRPfVp s4tpbCaDLOkay+j3Jd1Ek73e0+oUGKQ/1SveZvX9BBhI4k1M1gfgD/c1l788XMYzCj/IKC p/DG46iqXrzmKQ7ULpS/937B+eC6i6yO3yw6v3aPqInAKnus0WpzyMMdB6yvbe4I7e03hg ngkge4w+5o/oDsZUZ1BofpfoL+x0KQPObmz58uELA+NUyLsFYJ87jCF8zSJrSzduWZU10Y e6EjHyZZg1W2TC+nAkqktNrW7ZDpImewK0N+r7ZGfcWTXS+u/E/6hSD7LJZLug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616842160; a=rsa-sha256; cv=none; b=ZTiibMylYVuc/UokLYMZvZD2p9DeFXJ5HZSoQKTk9AlQGWlqQiZaLCTyC/kyq6evGmFBVj AfhV3OPCo7LJ58YdIq+cXgHVF+kLBjZPaGWbvvqUOAAKyFXIapiUjyuLeafkuqWySbS8eP 24H+h+i6HfWXCW6C4EBaWZZdIATNoHaOIl9Z6EirsSgBWprOjJT/hY4T5AXCuBVU2q7i7/ b0+gBRK0UGFQLbjfqkK1yEuQyEdBzzyiIiNbPsdyI+Y0BJn72Y5/5PWhIl2kJJHDkQ1Cn1 qXaofEa9lRIScBhXp2vXWOukwcLK7KWiSo72PFjasaP9VvyVrN+XnhBIBLMY5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 4AB171AE7D X-Spam-Score: -0.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: GHMAYsMA7df0 This is a multi-part message in MIME format. --------------E13CC7A9CB1599CFCC885719 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 14.03.21 um 01:58 schrieb Maxim Cournoyer: >>>> 6) Please add some more comments to the code explaining the idea. >>> I was under the impression the code was concise enough to forego with >>> verbose explanations; I'd rather keep it this way. >> Please add some comments. I had a hard time understanding it - and I was >> not even sure I understood, see my question (1). > I'm spread thin right now, so if you could prepare a patch addressing > the above for me to review, that'd be much appreciated. Otherwise I'll > get to it, but it won't be before some time. > Sorry, I'm too short in time ATM - and I'm afraid this will not change anytime soon. Just take my questions as a guidance what the comments should answer to make others (me :-) understand what is going on. Many thanks. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------E13CC7A9CB1599CFCC885719 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Am 14.03.21 um 01:58 schrieb Maxim Cournoyer:
6) Please add some more comments to the code explaining the idea.

I was under the impression the code was concise enough to forego with
verbose explanations; I'd rather keep it this way.

Please add some comments. I had a hard time understanding it - and I was
not even sure I understood, see my question (1).

I'm spread thin right now, so if you could prepare a patch addressing
the above for me to review, that'd be much appreciated.  Otherwise I'll
get to it, but it won't be before some time.

Sorry, I'm too short in time ATM - and I'm afraid this will not change anytime soon. Just take my questions as a guidance what the comments should answer to make others (me :-) understand what is going on.

Many thanks.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------E13CC7A9CB1599CFCC885719--