From: Jason Conroy <jconroy@tscripta.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: rust-team branch merged
Date: Thu, 18 Apr 2024 12:54:02 -0400 [thread overview]
Message-ID: <21GRCQ0Z0K9NXCO1IEDLT7V9RGQLRCVDMN1TT5B106HNS6E4S@tscripta.net> (raw)
In-Reply-To: <Zegx_RGmRAnJ3sHc@3900XT>
Efraim Flashner <efraim@flashner.co.il> writes:
> Currently if you were to pull in rust-rand-0.8 and rust-rand-0.7
> then
> you'd have both rand-0.*.crate files in the registry but only
> one of
> them would be listed in share/cargo/registry/index/ra/nd/rand. I
> need to
> adjust the generation of that file to combine multiple sources
> if they
> exist, and sort them (I'm not sure it's necessary, but wouldn't
> be
> surprised if we hit undefined behaviour if they were listed
> multiple
> times or out of order).
Hi Efraim,
I'm currently investigating this limitation of your proposed
patch.
Did you have a strategy in mind for how to fix it? I see that the
index files are currently generated during a phase of
cargo-build-system, rather than as a profile hook. So, to build an
index that properly reflects the contents of a profile, it would
seem that the two simplest options are: a) keep your existing
index-generation logic during the build, and merge these
per-package index files when building the profile; or b) move your
patch's index-generating code out of the build phase and into a
profile hook, so that we build each index file in a single pass
(for all versions of a package) rather than merging the files from
each package output.
On the surface option (b) seems cleaner, but maybe you had a
reason for generating the index contents during the build?
Jason
next prev parent reply other threads:[~2024-04-20 18:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 8:34 rust-team branch merged Efraim Flashner
2023-12-13 14:02 ` Maxim Cournoyer
2023-12-14 15:10 ` Efraim Flashner
2024-02-27 2:24 ` Jason Conroy
2024-03-06 9:06 ` Efraim Flashner
2024-03-06 17:53 ` Jason Conroy
2024-03-07 8:08 ` Efraim Flashner
2024-03-07 16:48 ` Jason Conroy
2024-03-12 15:12 ` Efraim Flashner
2024-03-13 15:06 ` Jason Conroy
2024-04-18 16:54 ` Jason Conroy [this message]
2024-04-24 15:39 ` Efraim Flashner
2024-04-24 15:58 ` Jason Conroy
2024-04-24 16:23 ` Efraim Flashner
2024-05-06 14:00 ` Jason Conroy
2023-12-14 23:09 ` Csepp
-- strict thread matches above, loose matches on Subject: below --
2023-05-09 7:32 Efraim Flashner
2023-05-09 8:33 ` Christopher Baines
2023-05-09 8:54 ` Efraim Flashner
2023-05-09 9:27 ` Andreas Enge
2023-05-09 9:28 ` Andreas Enge
2023-05-09 13:22 ` Christopher Baines
2023-05-09 14:04 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21GRCQ0Z0K9NXCO1IEDLT7V9RGQLRCVDMN1TT5B106HNS6E4S@tscripta.net \
--to=jconroy@tscripta.net \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).