* Guitarix FTBFS
@ 2023-04-26 21:57 Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-04-26 22:28 ` [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1 John Kehayias via Guix-patches via
0 siblings, 1 reply; 6+ messages in thread
From: Felix Lechner via Development of GNU Guix and the GNU System distribution. @ 2023-04-26 21:57 UTC (permalink / raw)
To: Guix Devel
Hi,
With a recent checkout of Guix, guitarix fails to build from source.
It may be a Python issue. A pertinent excerpt of the log is below.
Without a patch ready, I wasn't sure where and how to file this report. Thanks!
Kind regards
Felix
* * *
[ 477/1048] Compiling src/gx_head/engine/gx_resampler.cpp
In file included from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gi18n.h:21,
from
/gnu/store/cbjgz6f8nrb7804nnmmlvpd4y78p8zf3-glibmm-2.64.5/include/glibmm-2.4/glibmm/i18n.h:23,
from ../src/headers/engine.h:43,
from ../src/gx_head/engine/gx_resampler.cpp:27:
../src/headers/gx_system.h: In function ‘bool
gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
error: invalid conversion from ‘volatile void*’ to ‘void*’
[-fpermissive]
163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
(newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
| ^~~~~~~~~~~~~~
| |
| volatile void*
../src/headers/gx_system.h:115:12: note: in expansion of macro
‘g_atomic_int_compare_and_exchange’
115 | return g_atomic_int_compare_and_exchange(p, oldv, newv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
from ../src/headers/guitarix.h:35,
from ../src/gx_head/gui/gx_main_boxes.cpp:25:
../src/headers/gx_system.h: In function ‘bool
gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
error: invalid conversion from ‘volatile void*’ to ‘void*’
[-fpermissive]
163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
(newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
| ^~~~~~~~~~~~~~
| |
| volatile void*
../src/headers/gx_system.h:115:12: note: in expansion of macro
‘g_atomic_int_compare_and_exchange’
115 | return g_atomic_int_compare_and_exchange(p, oldv, newv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
from ../src/headers/guitarix.h:35,
from ../src/gx_head/gui/gx_main_midi.cpp:25:
../src/headers/gx_system.h: In function ‘bool
gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
error: invalid conversion from ‘volatile void*’ to ‘void*’
[-fpermissive]
163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
(newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
| ^~~~~~~~~~~~~~
| |
| volatile void*
../src/headers/gx_system.h:115:12: note: in expansion of macro
‘g_atomic_int_compare_and_exchange’
115 | return g_atomic_int_compare_and_exchange(p, oldv, newv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32,
from
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30,
from
/gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30,
from ../src/headers/guitarix.h:35,
from ../src/headers/avahi_discover.h:26,
from ../src/gx_head/gui/avahi_discover.cpp:21:
../src/headers/gx_system.h: In function ‘bool
gx_system::atomic_compare_and_exchange(volatile int*, int, int)’:
/gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44:
error: invalid conversion from ‘volatile void*’ to ‘void*’
[-fpermissive]
163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval,
(newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
| ^~~~~~~~~~~~~~
| |
| volatile void*
../src/headers/gx_system.h:115:12: note: in expansion of macro
‘g_atomic_int_compare_and_exchange’
115 | return g_atomic_int_compare_and_exchange(p, oldv, newv);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Waf: Leaving directory
`/tmp/guix-build-guitarix-0.43.1.drv-0/guitarix-0.43.1/build'
Build failed
-> task in 'guitarix' failed with exit status 1 (run with -v to
display more information)
-> task in 'guitarix' failed with exit status 1 (run with -v to
display more information)
-> task in 'guitarix' failed with exit status 1 (run with -v to
display more information)
-> task in 'guitarix' failed with exit status 1 (run with -v to
display more information)
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "python" arguments: ("waf"
"build") exit-status: 1 term-signal: #f stop-signal: #f>
phase `build' failed after 68.7 seconds
command "python" "waf" "build" failed with status 1
^ permalink raw reply [flat|nested] 6+ messages in thread* [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1. 2023-04-26 21:57 Guitarix FTBFS Felix Lechner via Development of GNU Guix and the GNU System distribution. @ 2023-04-26 22:28 ` John Kehayias via Guix-patches via 2023-04-27 14:42 ` Felix Lechner via Guix-patches via 2023-04-30 20:34 ` [bug#63098] " Ludovic Courtès 0 siblings, 2 replies; 6+ messages in thread From: John Kehayias via Guix-patches via @ 2023-04-26 22:28 UTC (permalink / raw) To: Felix Lechner; +Cc: guix-devel, 63098 [-- Attachment #1: Type: text/plain, Size: 8704 bytes --] Hi Felix, On Wed, Apr 26, 2023 at 02:57 PM, Felix Lechner via \"Development of GNU Guix and the GNU System distribution.\" wrote: > Hi, > > With a recent checkout of Guix, guitarix fails to build from source. > It may be a Python issue. A pertinent excerpt of the log is below. > > Without a patch ready, I wasn't sure where and how to file this report. Thanks! > The usual bug-guix@gnu.org list will do just fine I would say. In any event, I'm cc'ing the patch list with a quick patch that updates the package which builds fine for me locally; I didn't test running it though. I also updated to gexps and removed the native-inputs label. Since this was an update and the package currently doesn't build, I put it as one patch, but maybe it should be split up? I'm not sure (I think usually as separate commit, but here a fix/update for broken package seemed opportune), feel free to chime in anyone. I also did this super quickly, apologies for any silly mistakes. Thanks for the report! John > Kind regards > Felix > > * * * > > [ 477/1048] Compiling src/gx_head/engine/gx_resampler.cpp > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gi18n.h:21, > from > /gnu/store/cbjgz6f8nrb7804nnmmlvpd4y78p8zf3-glibmm-2.64.5/include/glibmm-2.4/glibmm/i18n.h:23, > from ../src/headers/engine.h:43, > from ../src/gx_head/engine/gx_resampler.cpp:27: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30, > from ../src/headers/guitarix.h:35, > from ../src/gx_head/gui/gx_main_boxes.cpp:25: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30, > from ../src/headers/guitarix.h:35, > from ../src/gx_head/gui/gx_main_midi.cpp:25: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30, > from ../src/headers/guitarix.h:35, > from ../src/headers/avahi_discover.h:26, > from ../src/gx_head/gui/avahi_discover.cpp:21: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Waf: Leaving directory > `/tmp/guix-build-guitarix-0.43.1.drv-0/guitarix-0.43.1/build' > Build failed > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > error: in phase 'build': uncaught exception: > %exception #<&invoke-error program: "python" arguments: ("waf" > "build") exit-status: 1 term-signal: #f stop-signal: #f> > phase `build' failed after 68.7 seconds > command "python" "waf" "build" failed with status 1 [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-gnu-guitarix-Update-to-0.44.1.patch --] [-- Type: text/x-patch; name=0001-gnu-guitarix-Update-to-0.44.1.patch, Size: 2270 bytes --] From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001 From: John Kehayias <john.kehayias@protonmail.com> Date: Wed, 26 Apr 2023 18:25:35 -0400 Subject: [PATCH] gnu: guitarix: Update to 0.44.1. * gnu/packages/audio.scm (guitarix): Update to 0.44.1. [arguments]: Use gexps. [native-inputs]: Remove labels --- gnu/packages/audio.scm | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index dca5e516a1..c369fe1bd4 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2314,7 +2314,7 @@ (define-public freepats-gm (define-public guitarix (package (name "guitarix") - (version "0.43.1") + (version "0.44.1") (source (origin (method url-fetch) (uri (string-append @@ -2322,14 +2322,14 @@ (define-public guitarix version ".tar.xz")) (sha256 (base32 - "1bsjlfd7x09p3iiljilyfbns6hpqn9cgp6psl4ccd6i1lwascfrm")))) + "063cdvrzrpnj08dm22z651hy5cz5bnsywf1z8b2kib2i9xskvs3p")))) (build-system waf-build-system) (arguments - `(#:tests? #f ; no "check" target - #:configure-flags - (list - ;; Add the output lib directory to the RUNPATH. - (string-append "--ldflags=-Wl,-rpath=" %output "/lib")))) + (list #:tests? #f ; no "check" target + #:configure-flags + #~(list + ;; Add the output lib directory to the RUNPATH. + (string-append "--ldflags=-Wl,-rpath=" #$output "/lib")))) (inputs (list libsndfile boost @@ -2347,12 +2347,12 @@ (define-public guitarix zita-resampler zita-convolver)) (native-inputs - `(("gperf" ,gperf) - ("faust" ,faust) - ("intltool" ,intltool) - ("gettext" ,gettext-minimal) - ("pkg-config" ,pkg-config) - ("sassc" ,sassc))) + (list gperf + faust + intltool + gettext-minimal + pkg-config + sassc)) (native-search-paths (list (search-path-specification (variable "LV2_PATH") -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1. 2023-04-26 22:28 ` [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1 John Kehayias via Guix-patches via @ 2023-04-27 14:42 ` Felix Lechner via Guix-patches via 2023-04-27 14:42 ` Felix Lechner via Development of GNU Guix and the GNU System distribution. 2023-04-30 20:34 ` [bug#63098] " Ludovic Courtès 1 sibling, 1 reply; 6+ messages in thread From: Felix Lechner via Guix-patches via @ 2023-04-27 14:42 UTC (permalink / raw) To: John Kehayias; +Cc: guix-devel, 63098 Hi John, On Wed, Apr 26, 2023 at 3:28 PM John Kehayias <john.kehayias@protonmail.com> wrote: > > a quick patch that > updates the package which builds fine for me locally; I didn't test > running it though. Thanks for looking into it! An untested executable strikes me as superior to one that does not build. I would commit the patch, regardless of form, at the earliest opportunity. Kind regards Felix P.S. You may find the X-Debbugs-CC header helpful. [1] [1] https://debbugs.gnu.org/Reporting.html#xcc ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: guitarix: Update to 0.44.1. 2023-04-27 14:42 ` Felix Lechner via Guix-patches via @ 2023-04-27 14:42 ` Felix Lechner via Development of GNU Guix and the GNU System distribution. 0 siblings, 0 replies; 6+ messages in thread From: Felix Lechner via Development of GNU Guix and the GNU System distribution. @ 2023-04-27 14:42 UTC (permalink / raw) To: John Kehayias; +Cc: guix-devel, 63098 Hi John, On Wed, Apr 26, 2023 at 3:28 PM John Kehayias <john.kehayias@protonmail.com> wrote: > > a quick patch that > updates the package which builds fine for me locally; I didn't test > running it though. Thanks for looking into it! An untested executable strikes me as superior to one that does not build. I would commit the patch, regardless of form, at the earliest opportunity. Kind regards Felix P.S. You may find the X-Debbugs-CC header helpful. [1] [1] https://debbugs.gnu.org/Reporting.html#xcc ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1. 2023-04-26 22:28 ` [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1 John Kehayias via Guix-patches via 2023-04-27 14:42 ` Felix Lechner via Guix-patches via @ 2023-04-30 20:34 ` Ludovic Courtès 2023-04-30 20:34 ` bug#63098: " Ludovic Courtès 1 sibling, 1 reply; 6+ messages in thread From: Ludovic Courtès @ 2023-04-30 20:34 UTC (permalink / raw) To: John Kehayias; +Cc: guix-devel, Felix Lechner, 63098 Hi John, John Kehayias <john.kehayias@protonmail.com> skribis: > From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001 > From: John Kehayias <john.kehayias@protonmail.com> > Date: Wed, 26 Apr 2023 18:25:35 -0400 > Subject: [PATCH] gnu: guitarix: Update to 0.44.1. > > * gnu/packages/audio.scm (guitarix): Update to 0.44.1. > [arguments]: Use gexps. > [native-inputs]: Remove labels LGTM, thanks! Ludo’. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bug#63098: [PATCH] gnu: guitarix: Update to 0.44.1. 2023-04-30 20:34 ` [bug#63098] " Ludovic Courtès @ 2023-04-30 20:34 ` Ludovic Courtès 0 siblings, 0 replies; 6+ messages in thread From: Ludovic Courtès @ 2023-04-30 20:34 UTC (permalink / raw) To: John Kehayias; +Cc: Felix Lechner, guix-devel, 63098 Hi John, John Kehayias <john.kehayias@protonmail.com> skribis: > From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001 > From: John Kehayias <john.kehayias@protonmail.com> > Date: Wed, 26 Apr 2023 18:25:35 -0400 > Subject: [PATCH] gnu: guitarix: Update to 0.44.1. > > * gnu/packages/audio.scm (guitarix): Update to 0.44.1. > [arguments]: Use gexps. > [native-inputs]: Remove labels LGTM, thanks! Ludo’. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-01 4:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-04-26 21:57 Guitarix FTBFS Felix Lechner via Development of GNU Guix and the GNU System distribution. 2023-04-26 22:28 ` [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1 John Kehayias via Guix-patches via 2023-04-27 14:42 ` Felix Lechner via Guix-patches via 2023-04-27 14:42 ` Felix Lechner via Development of GNU Guix and the GNU System distribution. 2023-04-30 20:34 ` [bug#63098] " Ludovic Courtès 2023-04-30 20:34 ` bug#63098: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).