From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YIq8DfIMfWOSQgAAbAwnHQ (envelope-from ) for ; Tue, 22 Nov 2022 18:54:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UPv8DPIMfWMSXgEAG6o9tA (envelope-from ) for ; Tue, 22 Nov 2022 18:54:58 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB3C49119 for ; Tue, 22 Nov 2022 18:54:57 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxXTo-0003ks-0v; Tue, 22 Nov 2022 12:54:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxXQp-0002Ed-DY for guix-devel@gnu.org; Tue, 22 Nov 2022 12:51:39 -0500 Received: from koszko.org ([93.95.227.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxXQn-0008L1-EE for guix-devel@gnu.org; Tue, 22 Nov 2022 12:51:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=koszko.org; s=mail; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RieATne4alXIOXqX2qxzwBodFExaZ9KvZswQYcyl5gc=; b=HGqcQRr6nGh3tKt5aOL77xk/4P 1o7Bfvb4EKEGpvMKzFIghd/VKPFA2eNyy5Gef57fN8SwriJQVKC1qnqcsYuFXTNZmZ+cBzqQNOYNV eCMXwzixAWAKuv5jqZMCHrRrMpdRuVbhIZ4UOc1001eYBdKvKns4yRJI5N1v4CCyRVkJtIzYmvNC8 jnkO+at21HWTfEt+2OwGfOvczhT9hI4+ntpvp6VaZIs5PWmM0vzyUPzuF9cb7gl0ngqerYTkGOVxl nLqbXQjuDedh4jLy05ViaTlmuLde4xIaPpEPyrCK9hf8wVb9S/RoVvOoACcdZ3MGCpsgdvzB6aT+n hq9p2TqYO8/Pp8JEtGNkYkv7WzFBTef8b+zEToaRXhzC6LlQ81gMuVTu0MkMymVHLmI01CuqXcbWU Yz2RVHhcOTttcHIEa3apGi2OjDZF7m+Zaws6X3zo37KrkDIKwrG9SGcKjSM+s6wERtCZVljG+qHyR 1CcBEB7x3BWfyZAAnsSaP7+ogsktRB6ILf3tdcYKnmgybNmjw/a/3paqK5i4FbThxcvZMTBSAkcdd E1EN/wbZgLnHTfgzklULcZryo7mlHP2F/SeBCQWQsNVhk6Qrhhr2qqvDWGppBR3hTsQ5T+oukkuQh 01NO6+rmObPLVMSGrhhMpbOv8B8YGrnyrskCUXisA=; Received: from [77.252.47.230] (helo=koszkonutek-tmp.pl.eu.org) by koszko.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxXQd-00089D-Rh; Tue, 22 Nov 2022 18:51:27 +0100 Date: Tue, 22 Nov 2022 18:51:25 +0100 To: "Philip McGrath" Cc: "Brian Cully" Subject: Re: RFC: libgit2 is slow/inefficient; switch to git command? Message-ID: <20221122185125.7a1528f9@koszkonutek-tmp.pl.eu.org> In-Reply-To: <49015314-2158-466b-a8ac-41abed84c5f1@app.fastmail.com> References: <87cz9fpw4x.fsf@gmail.com> <86leo3c81x.fsf@gmail.com> <49015314-2158-466b-a8ac-41abed84c5f1@app.fastmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/FynCmU1QZ_jcHijOndd3bAy"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=93.95.227.159; envelope-from=koszko@koszko.org; helo=koszko.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 22 Nov 2022 12:54:41 -0500 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Wojtek Kosior From: Wojtek Kosior via "Development of GNU Guix and the GNU System distribution." Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669139697; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RieATne4alXIOXqX2qxzwBodFExaZ9KvZswQYcyl5gc=; b=ZpHOkmb0EY2pSAHaFEliYaupKKxmxyeS9TzjXRjvOha23YEHKo5pxEUmOZYBZ1tkrLr0IR hVogR1elRJsToz3O4QRz5IUpsX05Wum5ES9XFHH6U0hJ1zB5gVX7HzRWdAZx9vrq9TOYfG wzeheAc8UGMmJPCFqLxXvlX//VFXkvC7d6Dh2G7gawhr8lUFqB9Rg8H3xD5uPh5FdfP2Oa edLAv9Ooutrj27tEDe0+bWCWxvk383Wv9OnIpcIxlzLllc8C4bBU4Fl2OMLpMINgWBTscP LUNpcHUuW81S/bpBk25LvWdt4n1KDXpxU9VUygbcoFwqcVVLW8A2kWX/7ie7IQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669139697; a=rsa-sha256; cv=none; b=YqBu8jKqEBp3uS3I3fIq/r/VQ0lQ6PjXCCzbcbLVBrfF7AiGbpiO3+KOwtKN8Ma2g8HsiE 2ReaviIUH9ifUeX0LzGhXu/coEl56cVwHVAae5e7pwaD5sEK7/m8RTJSWNX02r7BdOTNeG NEj1nXGAT+B7bwHnmtmm2tY4rMx1BKCmGESzrXE1PAKGeqW5PyUwBxBAq99Z60d+kEbGmD tiqSYfFeeTa4alP9BewbfyPQUvXgMNkN/AuxsiqeqIguMblIEWkPUqkFb6vLYFA5wxsFxR 9pQMjcEkZlxXfWe/B47gbzj9lkk82dmw0Nv0V0p11hp/TwXrJu76M36pRoBIDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=koszko.org header.s=mail header.b=HGqcQRr6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.61 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=koszko.org header.s=mail header.b=HGqcQRr6; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DB3C49119 X-Spam-Score: -3.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: VFIvub68qACQ --Sig_/FynCmU1QZ_jcHijOndd3bAy Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I just want to add my 2 cents :) Another issue with libgit2 is that is gives a very misleading error report when trying to http-clone a repo that only support the old "dumb" git protocol (as opposed to the newer "smart" one). More details here[1]. Missing support for that dumb protocol is probably not that big issue in practice. The misleading error Guix presents to the users trying to access some poor git repo is :/ Wojtek [1] https://issues.guix.gnu.org/58555 -- (sig_start) website: https://koszko.org/koszko.html PGP: https://koszko.org/key.gpg fingerprint: E972 7060 E3C5 637C 8A4F 4B42 4BC5 221C 5A79 FD1A Meet Krak=C3=B3w saints! #18: blessed J=C3=B3zef Kowalski Poznaj =C5=9Bwi=C4=99tych krakowskich! #18: b=C5=82ogos=C5=82awiony J=C3= =B3zef Kowalski https://pl.wikipedia.org/wiki/J=C3=B3zef_Kowalski_(duchowny) -- (sig_end) On Tue, 22 Nov 2022 11:49:26 -0500 "Philip McGrath" wrote: > Hi, >=20 > On Tue, Nov 22, 2022, at 10:39 AM, zimoun wrote: > > Hi, > > > > On Mon, 21 Nov 2022 at 21:21, Maxim Cournoyer wrote: > > =20 > >> Given that: > >> > >> * the git CLI doesn't suffer from such poor performance; > >> * This kind of performance problem has been known for years in libgit2 > >> [0] with no fix in sight; > >> * other projects such as Cargo support using the git CLI and that > >> projects are using it for that reason [1]; =20 > > > > And I would add the lack of =C2=ABSupport for shallow repositories=C2= =BB [1]. > > > > 1: > > =20 >=20 > > > > PS: For the record, Software Heritage, which ingests *a lot* of Git > > repositories, relies on Dulwhich [2] (pure Python implementation), IIUC. > > > > 2: =20 >=20 > Along those lines, there=E2=80=99s an implementation of clone/checkout in= pure Racket (for the package manager) that could probably be ported to Gui= le relatively easily. I=E2=80=99d expect libgit2 to be faster for the thing= s that it supports, but the Racket implementation does support shallow chec= kout, so it might pay off if that skips a lot of work. >=20 > Code: https://github.com/racket/racket/blob/master/racket/collects/net/gi= t-checkout.rkt > Docs: https://docs.racket-lang.org/net/git-checkout.html >=20 > (More broadly, I haven=E2=80=99t investigated performance issues, but my = basic inclination would be toward improving libgit2 over running the git ex= ecutable.) >=20 > -Philip >=20 --Sig_/FynCmU1QZ_jcHijOndd3bAy Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTpcnBg48VjfIpPS0JLxSIcWnn9GgUCY30MHQAKCRBLxSIcWnn9 Gk01AP48O3HQzeOAFSYQ/pILlNGCnlCWn3/Ap1Ns48S6hmATZwD5AUm54Iqp705r SZ/175t6uxEerliyflmMDI43X5RscQ8= =tO4p -----END PGP SIGNATURE----- --Sig_/FynCmU1QZ_jcHijOndd3bAy--