emacs-importmagic help python <3 elisp

emacs-importmagic help python <3 elisp

[jgart]

Hi Guixers,

I'm working on this package and I could use some guidance:

```
(define-public emacs-importmagic
  (let ((commit "701dfcca5f3ab42be0f26a8d381d7116c79be850")
        (revision "0"))
    (package
      (name "emacs-importmagic")
      (version (git-version "1.0" revision commit))
      (source
       (origin
         (method git-fetch)
         (uri
          (git-reference
           (url "https://github.com/anachronic/importmagic.el")
           (commit commit)))
         (file-name (git-file-name name version))
         (sha256
          (base32 "035830aizamh4c8hpnmfrbz9v9gy23d3nx0dv366l3q8mrh36l44"))))
      (build-system emacs-build-system)
      (arguments
       (list
        #:imported-modules `(,@%emacs-build-system-modules
                             (guix build python-build-system))
        #:modules '((guix build emacs-build-system)
                    ((guix build python-build-system) #:prefix python:)
                    (guix build emacs-utils)
                    (guix build utils))
        #:phases
        #~(modify-phases %standard-phases
            (add-after 'python:install 'python:wrap
              (assoc-ref python:%standard-phases 'wrap)))))
```

https://github.com/anachronic/importmagic.el

importmagic.el has python files but the current package I have above
doesn't copy them to the store.

How should I achieve this in this context? Write a phase and manually copy them?

all best,

jgart

Re: emacs-importmagic help python <3 elisp

[Liliana Marie Prikler]

Am Samstag, dem 09.07.2022 um 01:50 -0500 schrieb jgart:
>         #:phases
>         #~(modify-phases %standard-phases
>             (add-after 'python:install 'python:wrap
>               (assoc-ref python:%standard-phases 'wrap)))))
And when exactly do you run python:install?

Re: emacs-importmagic help python <3 elisp

[jgart]

On Sat, 09 Jul 2022 10:47:12 +0200 Liliana Marie Prikler <liliana.prikler@gmail.com> wrote:
> Am Samstag, dem 09.07.2022 um 01:50 -0500 schrieb jgart:
> >         #:phases
> >         #~(modify-phases %standard-phases
> >             (add-after 'python:install 'python:wrap
> >               (assoc-ref python:%standard-phases 'wrap)))))
> And when exactly do you run python:install?

Hi Liliana,

That was a section I copy pasta'ed from Maxim (emacs-jedi). I think I need to re-evaluate what I going to do with this package.

Any thoughts?

From the "Without MELPA" section https://github.com/anachronic/importmagic.el#without-melpa

> Download both importmagic.el and importmagicserver.py. Place them on a load-path of your emacs directory. For instance: ~/.emacs.d/site-lisp

Some open questions I currently have about this package:

1. Will the following warning section cause any errors/bugs in Guix shell environments:

https://github.com/anachronic/importmagic.el#warning

2. Do I need to patch this path? https://github.com/anachronic/importmagic.el/blob/master/importmagic.el#L106 

all best,

jgart

Re: emacs-importmagic help python <3 elisp

[Liliana Marie Prikler]

Am Samstag, dem 09.07.2022 um 11:57 -0500 schrieb jgart:
> On Sat, 09 Jul 2022 10:47:12 +0200 Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
> > Am Samstag, dem 09.07.2022 um 01:50 -0500 schrieb jgart:
> > >         #:phases
> > >         #~(modify-phases %standard-phases
> > >             (add-after 'python:install 'python:wrap
> > >               (assoc-ref python:%standard-phases 'wrap)))))
> > And when exactly do you run python:install?
> 
> Hi Liliana,
> 
> That was a section I copy pasta'ed from Maxim (emacs-jedi). I think I
> need to re-evaluate what I going to do with this package.
Note that emacs-jedi has more phases to copy.

> From the "Without MELPA" section
> https://github.com/anachronic/importmagic.el#without-melpa
> 
> > Download both importmagic.el and importmagicserver.py. Place them
> > on a load-path of your emacs directory. For instance:
> > ~/.emacs.d/site-lisp
See above.

> Some open questions I currently have about this package:
> 
> 1. Will the following warning section cause any errors/bugs in Guix
> shell environments:
> 
> https://github.com/anachronic/importmagic.el#warning
No, the expectation is to place it inside a correct shell, containing
(at least) emacs, emacs-importmagic, and all the python packages you
need.

> 2. Do I need to patch this path?
> https://github.com/anachronic/importmagic.el/blob/master/importmagic.el#L106
>  
Maybe?  It should resolve to the same thing, but patching it might make
more sense.

Cheers