From: raingloom <raingloom@riseup.net>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guix-devel@gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: Re: The case for moving raw binaries
Date: Fri, 29 Apr 2022 00:52:49 +0200 [thread overview]
Message-ID: <20220429005247.4af8b0a4@riseup.net> (raw)
In-Reply-To: <b6125207848d0fdc3df1c09b76f299a53600db90.camel@telenet.be>
On Thu, 28 Apr 2022 21:57:04 +0200
Maxime Devos <maximedevos@telenet.be> wrote:
> Liliana Marie Prikler schreef op do 28-04-2022 om 19:27 [+0200]:
> > > How does this help with double wrapping? Whether the wrappers /
> > > originals are put in /bin or $RAWBIN_DIR, it's still wrapped
> > > twice.
> > Because $RAWBIN_DIR can be ignored when wrapping. This means that
> > stuff that's already in it won't be added again.
> > [...]
> > Constructing the wrapper is not so much the problem, it's not
> > wrapping the already wrapped binaries.
>
> Why can $RAWBIN_DIR be ignored when wrapping? If the build system
> just sets $X during its wrappers, but the application needs $Y as well
> (wrapped in a build phase), then if the extra wrapping is cancelled,
> then the application won't get its $Y variable, which seems like a bug
> to me.
>
> Greetings,
> Maxime.
It should be pretty easy to detect a wrapped binary without moving it.
We could just include a magic string in it and scan for that, the exact
same way we scan for store references. If it contains the "wrapped"
magic UUID, it's wrapped.
next prev parent reply other threads:[~2022-04-28 23:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 16:37 The case for moving raw binaries Liliana Marie Prikler
2022-04-28 16:50 ` Maxime Devos
2022-04-28 16:55 ` Maxime Devos
2022-04-28 17:27 ` Liliana Marie Prikler
2022-04-28 19:57 ` Maxime Devos
2022-04-28 22:52 ` raingloom [this message]
2022-04-29 9:39 ` Maxime Devos
2022-04-29 4:13 ` Liliana Marie Prikler
2022-04-29 9:27 ` Maxime Devos
2022-04-29 16:59 ` Liliana Marie Prikler
2022-07-29 21:20 ` Philip McGrath
2022-07-30 6:11 ` Liliana Marie Prikler
2022-08-04 8:54 ` Ludovic Courtès
2022-08-04 16:53 ` Liliana Marie Prikler
2022-04-29 9:18 ` zimoun
2022-05-23 15:10 ` Ludovic Courtès
2022-05-23 16:03 ` Maxime Devos
2022-05-23 16:37 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429005247.4af8b0a4@riseup.net \
--to=raingloom@riseup.net \
--cc=guix-devel@gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).