From: Bengt Richter <bokr@bokr.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Assisting reviewing & committing with tags?
Date: Tue, 15 Feb 2022 13:23:13 +0100 [thread overview]
Message-ID: <20220215122313.GA12713@LionPure> (raw)
In-Reply-To: <87fsp1z7yd.fsf@gmail.com>
Hi guix,
It sounds like a good idea, but ISTM we don't need yet another markup syntax
if emacs org mode already defines a useful standard that can be adopted.
The advantage to org mode style [0] -- in commit commentary as well as tags
would be its scrapability -- i.e., ease of writing an extractor/formatter
for handy report snippets/pages and web stuff etc., whether implemented
using foreign shell or within guix.
[0] http://xahlee.info/emacs/emacs/emacs_org_markup.html
On +2022-02-02 08:58:18 -0500, Maxim Cournoyer wrote:
> Hi,
>
> Leo Famulari <leo@famulari.name> writes:
>
> > On Sun, Jan 09, 2022 at 11:54:25AM +0100, Maxime Devos wrote:
> >> Hi guix reviewers and committers,
> >>
> >> WDYT of tagging reviewed patches that look good with a usertag,
> >> e.g. 'reviewed-looks-good':
> >>
> >> https://debbugs.gnu.org/cgi/pkgreport.cgi?tag=reviewed-looks-good&users=guix
> >>
> >> then if a committer doesn't have much time to review and hence doesn't
> >> subscribe to guix-patches@, but they do trust the reviewer, they can visit
> >> that URL to look for reviewed patches that can be applied.
> >>
> >> There could also be a tag 'reviewed-looks-good2' if the patch appears ok
> >> to two reviewers, or a 'reviewed-needs-work', etc.
> >
> > This is a great idea. I guess we will need to adjust the software that
> > runs issues.guix.gnu.org to make use of it, but in the meantime you
> > should keep using this tag. Thanks!
>
> I like it as well.
>
> Maxim
>
--
Regards,
Bengt Richter
next prev parent reply other threads:[~2022-02-15 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 10:54 Assisting reviewing & committing with tags? Maxime Devos
2022-01-11 19:10 ` Leo Famulari
2022-02-02 13:58 ` Maxim Cournoyer
2022-02-15 12:23 ` Bengt Richter [this message]
2022-02-15 16:23 ` Maxime Devos
2022-03-21 8:47 ` Bengt Richter
2022-05-03 11:03 ` Debbugs usertags with Mumi or Emacs (was: Assisting reviewing & committing with tags?) zimoun
2022-05-03 16:10 ` Maxime Devos
2022-05-03 17:39 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215122313.GA12713@LionPure \
--to=bokr@bokr.com \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).