From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sAXlMlae5WA18wAAgWs5BA (envelope-from ) for ; Wed, 07 Jul 2021 14:30:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WMuZLlae5WCFXAAAbx9fmQ (envelope-from ) for ; Wed, 07 Jul 2021 12:30:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 076461443E for ; Wed, 7 Jul 2021 14:30:14 +0200 (CEST) Received: from localhost ([::1]:53158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m16gv-0004Nu-0j for larch@yhetil.org; Wed, 07 Jul 2021 08:30:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m16gU-0004NY-KW for guix-devel@gnu.org; Wed, 07 Jul 2021 08:29:46 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:37557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m16gR-0004nj-Fi; Wed, 07 Jul 2021 08:29:46 -0400 Received: from knurd (212-51-128-111.fiber7.init7.net [212.51.128.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id 8C37640061; Wed, 7 Jul 2021 14:29:33 +0200 (CEST) Date: Wed, 7 Jul 2021 14:29:28 +0200 From: Gabriel Wicki To: guix-devel@gnu.org Subject: Re: Removing package input labels: last call! Message-ID: <20210707122928.6s34jblnx5zhvd5f@knurd> References: <87h7hgssb2.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7hgssb2.fsf@inria.fr> Received-SPF: none client-ip=129.132.2.15; envelope-from=gabriel@erlikon.ch; helo=chimborazo.ee.ethz.ch X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625661014; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=qUVvdUBXhIEi/mrLmHewUyaL8SLJLjnWXzdJC8a+ajY=; b=dsBywwC0zhmc8Eg35t+ZjjFhFfnckVs8EfROTBBnp/Tdip+GMiARQUtKnpr8txG7lGRy69 LbblVwLkzBmJrXNBRsZqAtOtDQZxn0XTkHSxt8u3u8v4v6TT605FBqVtKMwPvTxxCjA8YV zmotFXtVts7qGqnU+DAAwe/FvOYymBI8gysRPDFU/p8LOSxGNZqAeVIqlFNuyBdSkhzJ/+ xMeRibSG6J8KlwOigty5PtpKf6JAbR0GH80B39zSWjQOctVxkVMT3/5nMZGdZmfv85cL84 Y/DM3uYVtLYrO1jC/Jxl3xJFmB85xXb3qAvrdnyMIQ+UMDZV4hD0DR+PX38wqg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625661014; a=rsa-sha256; cv=none; b=EoB8uVjbvzOrhiZ4qyoosY7GE/NB5gEtfz86/c58R4GL7zO54Ic+BR1S+JHjZAt7Q+79or fL+KMfO1RpHSrFJt0wxVcaTTpiD3Fol5gfkvKfiLlYws1Aso2qZJeLHogaGc5O51HhyBC4 2debYIUTf95SsWZtLIl4qVgj2oPucaO/+Ad+J1HgMSqe8gq2uAuFpmZ0rOgiBD/t4jseIc FBzXbqmYvMJR7sWYxyFlLKgjwPceReYyfrGm56/4/LVoMTX8snW6HKFlAsJtPu0k7phbWk /D5oRtc0Od67UCc8cdnJ994gqe1zhh0jT63M90M4N2b4H49bLdG7h89klEA3eA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 076461443E X-Spam-Score: -0.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6o+g+C756QIw Hi! I hope I'm not too late! I've given the patch a try and have a couple of questions: - Since not all the inputs *have* to be converted to the new format: is this more some kind of syntactic sugar and less of a "we really want this to be the new standard" kind of improvement? Or is the goal to replace *all* input lists with the new style? - Regarding the speed of the transition: do I understand correctly that the script should be able to convert the vast majority of packages and that afterwards maybe other definitions will/might/could be translated by hand? - Follow up: is your intention to adjust the script to work with more and more package definitions or are you leaning into a more "let's have a sound script which is useful for many cases but leaves a biggish bunch of manual labor but at least it won't break a thing" kind of solution? - Is there a way to check the integrity of a package definition *without* building the whole thing? I had some ideas (see below) for adding special cases to your `guix style` script but was unable to test whether they actually work (because compiling tonnes of codes unsurprisingly takes quite some time). What I found: - Small things like libX11 vs libx11. If I understood correctly the new patch series takes care of this case. - I think there's a whole class of cases where version-names and other package-definition specifics make the "does-the-package-name- match-the-label-exactly" algo fail: - ,python-wrapper vs. "python" - ,python-minimal-wrapper vs. "python" - ,python2 vs. "python" - ,python-cython vs. "cython" - ,iproute2 vs. "iproute" - etc I've written some code and tested it with some specific package definitions but since I was unable to test whether these substitutions actually work for *all* package definitions I'll just leave these remarks here :) I hope this is somewhat help- or useful. Gabriel