From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id fpGeA/JAj2DDZAAAgWs5BA (envelope-from ) for ; Mon, 03 May 2021 02:16:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WBdvOvFAj2BacAAA1q6Kng (envelope-from ) for ; Mon, 03 May 2021 00:16:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F7A9D71B for ; Mon, 3 May 2021 02:16:49 +0200 (CEST) Received: from localhost ([::1]:45268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldMGW-0002wy-3M for larch@yhetil.org; Sun, 02 May 2021 20:16:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldMFm-0002Hx-8q for guix-patches@gnu.org; Sun, 02 May 2021 20:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldMFm-0002A4-0K for guix-patches@gnu.org; Sun, 02 May 2021 20:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldMFl-0000St-Ox for guix-patches@gnu.org; Sun, 02 May 2021 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48173] [PATCH] maint: Do not xz-compress ISO images. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 May 2021 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48173 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org, maxim.cournoyer@gmail.com, 48173@debbugs.gnu.org X-Debbugs-Original-Cc: guix-devel@gnu.org, Maxim Cournoyer , guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16200009421778 (code B ref -1); Mon, 03 May 2021 00:16:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 May 2021 00:15:42 +0000 Received: from localhost ([127.0.0.1]:45584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldMFS-0000Sc-24 for submit@debbugs.gnu.org; Sun, 02 May 2021 20:15:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:44722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldMFP-0000SV-7G for submit@debbugs.gnu.org; Sun, 02 May 2021 20:15:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldMFO-0001w5-I1; Sun, 02 May 2021 20:15:38 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:53494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldMFL-0001oM-Pc; Sun, 02 May 2021 20:15:38 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 833ce343; Mon, 3 May 2021 00:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=F1UTtCmDj+O9 r7j1Xf9qz+Jv59wX9dthFj26MS4Mh34=; b=e+6/C3X7RX9rhTfg+GL1y6s0XvHn gETtPJXNfh4Edzhr1K+1qvU4Cj9nT32Dr2/qX9VE6phGjwb9Ov4V2LuKqHst0qcC pvdAsdt5Wh235awTCAC3gyJev9w7C+8rrM42qkphAjeV/RQXNDbc+OTNR6GH+WSE Rdq935/kzQx97KXdpKJlb6I8ImwDguP8dgLSW/wTuUYMY383N9CWuKi1ZsqUN/7a w8AqkvF5nVfBHlS948HuBLrXIz/jU4EXc958HqJfFXLHZROAjvQrJBKoZqMgdcFZ L+l1NVViCOakXJvUI4Znu1fR7ppi18CpesGB3rX2kMN1KJvWef0VBTtBIA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id c913e3c9 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 3 May 2021 00:15:28 +0000 (UTC) Date: Mon, 3 May 2021 02:15:22 +0200 From: Julien Lepiller Message-ID: <20210503021522.2e33ac49@tachikoma.lepiller.eu> In-Reply-To: <20210502211648.5830-1-ludo@gnu.org> References: <87im462lc9.fsf@latte.josefsson.org> <20210502211648.5830-1-ludo@gnu.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620001009; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aM0tntR3um9Y5zNLeL1XiDchcml8s52TrgT4gJOJ/KY=; b=ZmKw0GMKEt1plGkjjNq3Nb+g2lCGydRVTRkXtrP+w1+/ur/rI1APIuROgypNI08VhYtguI piV2+Orzy2t41WByqFka/+QUby/AIW59orJHKwRm6LiV3uKCApKwfeyN+sSrm3wH3Wm2Eo gn1cq609heYecgcx/RRy40mCoctI/xl+9nTh+s7e2loGRGYAIP34Oj+QhyCRZy+c716U7R GXW1erqKO5SKcqCFhXM1oo8Xidl/r/GPfLxhLB3UeT/lxY0+0IbQY+lv4LN9g0Pgaj8seO 22wsaJ5D+McJY2pb3bP1Qqg0lkdeWvCfbP7aBi+72GxaWPyB3fH70mI+R/AaZg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620001009; a=rsa-sha256; cv=none; b=KjT6YtjBPKHWUlv5sMkDoGq3MCFUpo7fPBzoIi0Qa5ja+aMCo7IS5sgm63VZLqDJQS+3En j5gOGI1psjq9ji3u7HsVWFEwGABF6DikEJCVU1qM3tE5X0HW4/UN0mTiG/oi86AJ7PF9qG 4Al3WHKZtdMeutQy6EYEWhYT0GCOeMfiQrhyedceu+jFtcX8Ih19tMI11mHGsdLTp1G1yI 4DFX1xnPjv5Vmxm2JLIgFSM1Q2laizowcsgwUIq0AyO28oSQhbm3ZuTlvzcMwQ14UyMFxK 26O4s7v/A81qR6Wftw0VcpPn2IyKLRkU66jV635FsDreKJWztptVgTFz9AHySQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="e+6/C3X7"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="e+6/C3X7"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4F7A9D71B X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: kwR73ll6zLA0 Le Sun, 2 May 2021 23:16:48 +0200, Ludovic Court=C3=A8s a =C3=A9crit : > The xz-compressed image is 23% smaller than the original ISO image > (with built-in zlib compression), but the extra decompression step is > unconventional and often a hindrance for users. See discussion at > . >=20 > * Makefile.am (release): Do not compress ISO images. > * doc/guix.texi (USB Stick and DVD Installation): Remove ".xz" suffix > from URL and file name. > (Copying to a USB Stick, Burning on a DVD): Remove introductory words, > @enumerate, and first item. I have to ask about the patch title: what does "maint" mean? > --- > Makefile.am | 6 +++--- > doc/guix.texi | 30 +++--------------------------- > 2 files changed, 6 insertions(+), 30 deletions(-) >=20 > Hi! >=20 > This takes the simple step of providing plain ISOs only (rather than > .iso + .iso.xz as some suggested). >=20 > One advantage is that, unless I=E2=80=99m mistaken, this can be done with= out > breaking string freeze. >=20 > We=E2=80=99ll also have to update on t= he > release day. >=20 > Thoughts? >=20 > Ludo=E2=80=99. >=20 > diff --git a/Makefile.am b/Makefile.am > index 8d059eb033..623b1c497f 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -886,9 +886,9 @@ release: dist-with-updated-version all > echo "failed to produced Guix installation image for > $$system" >&2 ; \ exit 1 ; > \ fi ; > \ > - xz < "$$image" > > "$(releasedir)/$(GUIX_SYSTEM_IMAGE_BASE).$$system.iso.xz.tmp" > ; \ > - mv > "$(releasedir)/$(GUIX_SYSTEM_IMAGE_BASE).$$system.iso.xz.tmp" > \ > - > "$(releasedir)/$(GUIX_SYSTEM_IMAGE_BASE).$$system.iso.xz" ; > \ > + cp "$$image" > "$(releasedir)/$(GUIX_SYSTEM_IMAGE_BASE).$$system.iso.tmp" ; \ > + mv > "$(releasedir)/$(GUIX_SYSTEM_IMAGE_BASE).$$system.iso.tmp" > \ > + "$(releasedir)/$(GUIX_SYSTEM_IMAGE_BASE).$$system.iso" > ; \ done > # Generate the VM images. > for system in $(GUIX_SYSTEM_VM_SYSTEMS) ; do > \ diff --git a/doc/guix.texi b/doc/guix.texi > index 2fe7ad3a2a..3460c58cbc 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -2099,7 +2099,7 @@ about their support in GNU/Linux. > =20 > An ISO-9660 installation image that can be written to a USB stick or > burnt to a DVD can be downloaded from > -@indicateurl{@value{BASE-URL}/guix-system-install-@value{VERSION}.x86_64= -linux.iso.xz}, > +@indicateurl{@value{BASE-URL}/guix-system-install-@value{VERSION}.x86_64= -linux.iso}, > where you can replace @code{x86_64-linux} with one of: Sorry, this actually breaks string freeze. Now for something like this, we could grant an exception? It's not like it's too hard to fix, even manually and even if you don't know the language :) > =20 > @table @code > @@ -2115,8 +2115,8 @@ Make sure to download the associated > @file{.sig} file and to verify the authenticity of the image against > it, along these lines:=20 > @example > -$ wget > @value{BASE-URL}/guix-system-install-@value{VERSION}.x86_64-linux.iso.xz.= sig > -$ gpg --verify > guix-system-install-@value{VERSION}.x86_64-linux.iso.xz.sig +$ wget > @value{BASE-URL}/guix-system-install-@value{VERSION}.x86_64-linux.iso.sig > +$ gpg --verify > guix-system-install-@value{VERSION}.x86_64-linux.iso.sig @end example Even that example actually breaks it: examples can contain comments that should be translated, so po4a lets translators do whatever they want with them. Again, it's easy to fix. > If that command fails because you do not have the required public > key, @@ -2140,17 +2140,6 @@ It is meant to be copied @emph{as is} to > a large-enough USB stick or DVD. @unnumberedsubsec Copying to a USB > Stick=20 > -To copy the image to a USB stick, follow these steps: > - > -@enumerate > -@item > -Decompress the image using the @command{xz} command: > - > -@example > -xz -d guix-system-install-@value{VERSION}.x86_64-linux.iso.xz > -@end example > - > -@item Now removing text is fine :) LGTM, but what should we do about the strings?