From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uK+cGW/kgWCdcAEAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 23:02:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cJ8SFW/kgWAwXQAAbx9fmQ (envelope-from ) for ; Thu, 22 Apr 2021 21:02:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DDAD1A2FF for ; Thu, 22 Apr 2021 23:02:39 +0200 (CEST) Received: from localhost ([::1]:56938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZgT8-0001VQ-BB for larch@yhetil.org; Thu, 22 Apr 2021 17:02:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZgSy-0001V4-SP for guix-devel@gnu.org; Thu, 22 Apr 2021 17:02:28 -0400 Received: from mout01.posteo.de ([185.67.36.65]:40461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZgSw-0003ft-DQ for guix-devel@gnu.org; Thu, 22 Apr 2021 17:02:28 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 0952A240029 for ; Thu, 22 Apr 2021 23:02:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1619125344; bh=0+wI5/OdAXU/Z8CgUznuixPInmkqQxLMJlD1r83osxQ=; h=Date:From:To:Cc:Subject:From; b=cL5EjYdzfbZzqk1900pk/8RsLDXSw3Q06ad3GDGVCk/66urDY4upKkWiU5v3nsPxQ apm0INyFn59JoCiP8j9d4qx0W7RD+RLzDY51nPca1RItcuvAHUT8Ppd2lSiKTnARwD FPbYk0AoJvdRXnJ6ig+KjRFlvunh6Da2cddsmL+WC3zpIhPjwTq+62IRGur85s/x96 baSwq2IQmQg4EoOnyHPkGvw3CmwYbpa/oURgQM1YDQsTTB4moznPeRLRFmXPsHIbCY H57gu9ypnCnyI7+lD8rmYLxhX1GJs4A4gUqsYMItEKLaKFbmE1Bh1mkMYf+2kTFFXv /7Qi/UF9PRR2A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FR8xk5qkQz6tmV; Thu, 22 Apr 2021 23:02:18 +0200 (CEST) Date: Thu, 22 Apr 2021 21:02:08 +0000 From: Luciana Lima Brito To: Christopher Baines Subject: Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons. Message-ID: <20210422180208.28473e41@lubrito> In-Reply-To: <875z0ehyl3.fsf@cbaines.net> References: <20210421152914.461bbdbb@lubrito> <87bla6iwli.fsf@cbaines.net> <20210422170040.37941083@lubrito> <875z0ehyl3.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=lubrito@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619125359; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=stroIBI1kunNuX+Am0R5FXoN6YLpyli6kICJybwfCcQ=; b=D3jYUTS50dLuPba1UiQ4gDNv7lzBi3tIB0W3CAgP3n8thuFhPx4Br/cHJkOFcyEbfQ2a0D 1vI6eVC7lym61DODBmd+Xl887WWh1V9f8LP71nXSuVDp+AUi/NvCIIhfyP6qJ5ZVKg0TY4 XK/g5VWEGJsqqCF9+b80wcWWXatQYIPhqHvNx3aNIOGeOnsDMw03MJCmo5shrG+lMG9xXT edI4NCi1+p9HQMxe0suXb1dRhbYTuqQK5bCEvxANeXjm7RIGNE6THslV79KLSiZ3FjEaD4 G2/tUfd9+PGB7ZC6oEIjIrATuLF3r6yctgJtt3P8ldg1RPs7gYwTp3bEA4+nkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619125359; a=rsa-sha256; cv=none; b=OpTj1Iq/EP9Na6CgzXS9MDv7dhHg4FcOXA+ozjcxZCGRO8hVWn/OjuoN0irBoSy6y7Nm/7 +vCdomOjwuDr9yoWSWnPgh7+IQrqfr3ltG+sThBpOkd3IeGrYJi7G/MQeVhx3b6sry3VD3 1djYMQWfu2K+h3zj+w+QnO+9BhvbrJ8UWQ4EELhd7Uc8a7NVlt0AsaYxEaIUzMXQ0Hay6r WvIBNy47EmfXotK8ThLRRa0qQ2+MiQwomTFGgEt3OOhByuKO3jEFwHpryX5OpzJ9XnYvEo 2KMdxn7ZYmCqiU0p6Hx/rHC+5PwCRfKmxpvBoO9gChTbPLVwcOU/u0z2QPkvRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=cL5EjYdz; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.65 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=cL5EjYdz; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 1DDAD1A2FF X-Spam-Score: -2.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: KzmWAEoNp+yf On Thu, 22 Apr 2021 21:08:08 +0100 Christopher Baines wrote: > I'm not quite sure what you mean by empty fields in the JSON here? I mean now it appears like this in the json hash-alg: {} Before, it was entirely omitted. > It sounds like you're roughly on the right track, do share what > changes you're making and then I can have a look. This is the part I've changed on comparison.scm in the function derivation-outputs-differences-data: (map (match-lambda ((output-name path hash-algorithm hash recursive derivation_ids) (let ((parsed-derivation-ids (map string->number (parse-postgresql-array-string derivation_ids)))) (list output-name path (if (string? hash-algorithm) hash-algorithm '()) (if (string? hash) hash '()) (string=? recursive "t") (append (if (memq base-derivation-id parsed-derivation-ids) '(base) '()) (if (memq target-derivation-id parsed-derivation-ids) '(target) '())))))) (exec-query conn query)) Basically, I moved the hash-algorithm, hash, and recursive tests from controller.scm here. I spent more time familiarizing with this part of the code and the dataset. I don't have anything ready for the idea I told you in the last email because I'm not so sure if that is the way to go, but I can make some experiments in this regard. -- Best Regards, Luciana Lima Brito MSc. in Computer Science