From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MKepGozWgWAWLgEAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 22:03:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mFNdFozWgWAcegAA1q6Kng (envelope-from ) for ; Thu, 22 Apr 2021 20:03:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E79819C84 for ; Thu, 22 Apr 2021 22:03:23 +0200 (CEST) Received: from localhost ([::1]:59746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZfXm-00019d-04 for larch@yhetil.org; Thu, 22 Apr 2021 16:03:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZfVW-0000C7-2T for guix-devel@gnu.org; Thu, 22 Apr 2021 16:01:02 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZfVO-0008U9-NW for guix-devel@gnu.org; Thu, 22 Apr 2021 16:01:01 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 8185E240027 for ; Thu, 22 Apr 2021 22:00:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1619121650; bh=NkYWNStQkxqhbGqXzBKOdloTjkrQLMjAqY3w8ONRbJA=; h=Date:From:To:Cc:Subject:From; b=R9RK0KIpWkm7Z/izqVYgJ/rrFrHNPWf1YDyiXnI2PapkHMM5nOlEvLtbGgi8K31aA 8Es1bSgEaCqNI/d8OGAsTmTLMm/qE+fsj9aoyq8hyoXzzVlQjeF5UxylnANy+xwEdh r7sQPsVQG2P1jmnXa1r8+jqZiODWKEJy4bsd5aH6cqIPqFiARqw1fYOWIDdrnGrKTD TD1nDCgaeZPfyrK8dl/nm/ZkSr75yaI26UfmOa9A5RxuUsGM4Tig01UtuD9aDMu1OQ DVo4CBXue6IKCBtlB5cS7E2PkVTOWpU6hM5DYpccIho5vzruR+TJhYRNTlLHag+xfZ Pg3Jisv2aFWSg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FR7Zm6khVz9rxT; Thu, 22 Apr 2021 22:00:48 +0200 (CEST) Date: Thu, 22 Apr 2021 20:00:40 +0000 From: Luciana Lima Brito To: Christopher Baines Subject: Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons. Message-ID: <20210422170040.37941083@lubrito> In-Reply-To: <87bla6iwli.fsf@cbaines.net> References: <20210421152914.461bbdbb@lubrito> <87bla6iwli.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=lubrito@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619121803; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=dtFaDfIriiEI9hvmUZA7F+ISKRFxr3LACQd9cGr1CKg=; b=qzZzo2Gtynnlg50lSsSluNRqvgE3nr/LwUQAcMRfmPLFJ9SvOhEP+LQ4iw4jTXQAv/PWLH yGC0v730vaezn3KDbG3GTUZzSQaJD2TJFLIW/ckUtW2ldgBUop2kgQNWlZ8Ini+GOUBJAS Nvt7GiBm+Zye3JclYk0tw730lzfBw/O4jxNNkHpljClZ7/9FyS3DDwXYjXdde/63SEK/V9 NN0dVwhWur8o/+jxnTvG3w1lcTt5FfOyHub3KENN88ce82jKKa5HncwBk5Ui4HX8ra/pSS 8ZXCujarcvNS2cky22tXhy+84kuQECM0Q0oLeKi4RsYkGIorP82J06h79Kj+Vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619121803; a=rsa-sha256; cv=none; b=EEjQoVmOxKo3Sd2dP5Vw5R0Hgwk/9I8PF4XSCHBexLUOoD9poBIYCx/ibl4nW2+fTCruIs JrBMtfrt4XV+upff/XgC1lXxtbCMzhkPi2Vy24/zz1XFem+Wo1/IoPaYDxc18QMvDnVutF NKN4znoYZ3ao+ZNZbKQG3RAPOSK8kBm/PQ4eKDJsSZpzs8LDrJa2W/hrbd52x4XZByE8CA wFAxQof7/S8xckx5rtdKggv++KmUCSmizw4gVbO4cbYTBHtyFYIsEZ9VbD3wqbmiYfAmNF jAACEA8nApd0GIfaKLcM133Bsi/n+f42492FvC/psjwn/iqSpxiZb7dMpBgmxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=R9RK0KIp; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.64 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=R9RK0KIp; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 2E79819C84 X-Spam-Score: -2.64 X-Migadu-Scanner: scn0.migadu.com X-TUID: dTsca9SUetdX Hi, > Small intentional changes are better, so I'd start just with looking > at some of the data coming out of the query. But yes, I think you're > in the right place. The hard part here is probably to look at how > those values are used in the JSON and HTML rendering code, and adjust > that accordingly. I made some modifications(moved the tests from controller.scm to comparison.scm) in order to remove the value "#f" from the outputs "hash-algorithm" and "hash" when rendering the html, for derivations that don't have these values set, but doing that now I'm showing them as empty fields on the json (instead of omitting them entirely). This simplified a bit the processing on render-compare/derivations, and I think the html output is also better. For inputs, sources, etc, there are no processing being done on controller.scm other than the map. I can't see now what else could be done in this regard. An idea I had was to remove the entire map functions from the controller.scm to comparison.scm, but this would impact the html, so I would also have to modify the html, because the data format for json and html are slightly different. I'm not sure if this is what you want. -- Best Regards, Luciana Lima Brito MSc. in Computer Science