unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: Vagrant Cascadian <vagrant@debian.org>,
	guix-devel@gnu.org, bug-mes@gnu.org
Subject: Re: Update on wip-arm-bootstrap
Date: Mon, 22 Feb 2021 02:03:30 +0100	[thread overview]
Message-ID: <20210222020330.74832a2b@scratchpost.org> (raw)
In-Reply-To: <87v9als2ag.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Hi Janneke,

Nice!

Patch review:

>+#if __ARM_EABI__
>+#define CLEAR_CACHE(BEG,END)						\
>+{									\
>+  register unsigned long _beg __asm ("a1") = (unsigned long)(BEG);	\
>+  register unsigned long _end __asm ("a2") = (unsigned long)(END);	\
>+  register unsigned long _flg __asm ("a3") = 0;				\
>+  __asm __volatile ("mov r7, 0x9f0002\n\t"				\

should be mov r7, 0xf0002 in EABI.
(SWI #(0x900000 + syscallnr) is for OABI syscalls only)

>* sysdeps/unix/sysv/linux/arm/brk.c (__brk): Likewise.Likewise.

Duplicate "Likewise".

Otherwise LGTM!

>But something like puts or printf segfaults "Illegal
>instruction" in strlen:

>--8<---------------cut here---------------start------------->8---
>(gdb) disas /r
>Dump of assembler code for function strlen:
>   0x0000d160 <+0>:	03 10 c0 e3	bic	r1, r0, #3
>=> 0x0000d164 <+4>:	04 20 91 e4	ldr	r2, [r1], #4  
>--8<---------------cut here---------------end--------------->8---

Hmm... looks good to me?  Weird.

I'm building it right now and will have a look.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-02-22  1:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13  9:25 Update on wip-arm-bootstrap Jan Nieuwenhuizen
2021-02-18 17:26 ` Ludovic Courtès
2021-02-21 18:17   ` Jan Nieuwenhuizen
2021-02-22  1:03     ` Danny Milosavljevic
2021-02-18 17:48 ` Vagrant Cascadian
2021-02-18 21:52   ` Jan Nieuwenhuizen
2021-02-19  4:23     ` Danny Milosavljevic
2021-02-19  6:17       ` Jan Nieuwenhuizen
2021-02-21 18:28         ` Jan Nieuwenhuizen
2021-02-22  1:03           ` Danny Milosavljevic [this message]
2021-02-22  1:50             ` Danny Milosavljevic
2021-02-22  6:01               ` Jan Nieuwenhuizen
2021-02-22 17:09                 ` Danny Milosavljevic
2021-02-22 17:34                   ` Danny Milosavljevic
2021-02-22  6:14             ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210222020330.74832a2b@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=bug-mes@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=janneke@gnu.org \
    --cc=vagrant@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).