From: Leo Famulari <leo@famulari.name>
To: "Simon Josefsson via Development of GNU Guix and the GNU System
distribution." <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: oath-toolkit: Update to 2.6.3.
Date: Mon, 9 Nov 2020 13:55:28 -0500 [thread overview]
Message-ID: <20201109185528.GA9563@jasmine.lan> (raw)
In-Reply-To: <874klyu0rm.fsf@latte.josefsson.org>
On Mon, Nov 09, 2020 at 02:18:21PM +0100, Simon Josefsson via Development of GNU Guix and the GNU System distribution. wrote:
> * gnu/packages/authentication.scm (oath-toolkit): Update to 2.6.3. Drop patch.
Thanks!
> - (patches
> - (append (search-patches "oath-toolkit-glibc-compat.patch")
> - (list (origin
> - ;; This huge commit updates gnulib for GCC 7 compatibility.
> - (method url-fetch)
> - (uri (string-append
> - "https://gitlab.com/oath-toolkit/oath-toolkit/commit/"
> - "2fffce2a471f74a585939c84cce16ef3015e5d3d.diff"))
> - (file-name "oath-toolkit-update-gnulib.patch")
> - (sha256
> - (base32
> - "088c9s4ay1b54bjqc4mwfs5l3f6357zj5vpw771zlq5g4addd4s0"))))))
I notice that the commit message says "Drop patch", but that this change
actually removes two patches from the oath-toolkit.
It removes the application of both "oath-toolkit-glibc-compat.patch" and
also the "oath-toolkit-update-gnulib.patch". Is that intended?
If so, we should also delete the former's patch file and remove it from
'gnu/local.mk'.
next prev parent reply other threads:[~2020-11-09 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 13:18 [PATCH] gnu: oath-toolkit: Update to 2.6.3 Simon Josefsson via Development of GNU Guix and the GNU System distribution.
2020-11-09 18:55 ` Leo Famulari [this message]
2020-11-10 15:11 ` Simon Josefsson via Development of GNU Guix and the GNU System distribution.
2020-11-11 2:22 ` Leo Famulari
2020-11-11 16:05 ` Simon Josefsson via Development of GNU Guix and the GNU System distribution.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109185528.GA9563@jasmine.lan \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).