From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AE4bI279XF92XwAA0tVLHw (envelope-from ) for ; Sat, 12 Sep 2020 16:55:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yA1nHW79XF8veAAAbx9fmQ (envelope-from ) for ; Sat, 12 Sep 2020 16:55:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ECD6D9408DC for ; Sat, 12 Sep 2020 16:55:09 +0000 (UTC) Received: from localhost ([::1]:47532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH8V3-0001zl-WC for larch@yhetil.org; Sat, 12 Sep 2020 12:35:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH8Uw-0001za-4Z for guix-devel@gnu.org; Sat, 12 Sep 2020 12:35:34 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH8Ut-0000Zt-Q6 for guix-devel@gnu.org; Sat, 12 Sep 2020 12:35:33 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C72875C004E; Sat, 12 Sep 2020 12:35:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 12 Sep 2020 12:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=kFJBJA9L1WsR4hMwh3ke9Cnm V3lzXFbzsMYzWMf20Go=; b=Z4LbB9MjXlkA/wmQPlUCpVU2fMfbqCef9Qcw4jlC HgkutdOAnIbmhuHoEmuxUvPtHiS155FwHQRpUxLXzBcLpBtJkEgouugFNlRrS+JY 934OGGiaWRyQ7UycsZzQ9Kn6qfn7o82JmQTV2EuQqrT1CZrlY2KNDD64axHgNeiI vzQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kFJBJA 9L1WsR4hMwh3ke9CnmV3lzXFbzsMYzWMf20Go=; b=HaNmpUpyo5USKgTKLS3y/r zWI7+CCgtQNGdIlJ/z1ewPFTErjz9IiynGnup5DdGHHmrjgDpLfalGD5Unm/3O3+ hBUd8etTxwM21yKoTT2xcJ+hvjmYtvO9zFwLYQRkgQYkWMMOCR/jvALnQFKJ9GEi EnlSaziqG3nRBrfrtjVx+dFXY83/a/YPXjAfAb9ME6Kt0PSi2/GAT/+7WJmwgnfl 1m2/KZ0hgo8I5X1g0K37OOJV4SqMTYSS7c+kWE4ZaAtMuF7Ec5m9rgTLMIkMOrBA ZSR4qOv4AiNvO9Pp4OxHvizNoR+tMJ93lp4KmL1Vrj8+3zqcTpDyQ77fi4d2nqLg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeiuddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeejieekffelgfegfeffgfelvefgle dtheelkeekfeelkefggeetudeuveethfehjeenucffohhmrghinhepughighhikhgrmhdr ohhrghdpghhithhhuhgsrdgtohhmnecukfhppedujedvrdehkedrvddtfedrvddtvdenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehf rghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (unknown [172.58.203.202]) by mail.messagingengine.com (Postfix) with ESMTPA id BC4DD306467D; Sat, 12 Sep 2020 12:35:28 -0400 (EDT) Date: Sat, 12 Sep 2020 12:35:10 -0400 From: Leo Famulari To: Zhu Zihao Subject: Re: Packaging question: Backport patch or use newer commit? Message-ID: <20200912163510.GB27649@jasmine.lan> References: <7877f6bd.36fa.174830f49cf.Coremail.all_but_last@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7877f6bd.36fa.174830f49cf.Coremail.all_but_last@163.com> Received-SPF: pass client-ip=66.111.4.26; envelope-from=leo@famulari.name; helo=out2-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 12:35:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=famulari.name header.s=mesmtp header.b=Z4LbB9Mj; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=HaNmpUpy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: 4.29 X-TUID: KhsY8FU2E8MP On Sun, Sep 13, 2020 at 12:04:11AM +0800, Zhu Zihao wrote: > Hi everybody. I' m packaging digikam(https://digikam.org). A free photo management software from KDE project. There're 2 dependecies missing from current Guix(qtav & libksane) > > > I tried to package qtav(https://github.com/wang-bin/QtAV/) first, but it's latest release(v1.13.0) failed to build with Qt 5.14. And it was fixed in https://github.com/wang-bin/QtAV/commit/5abba7f0505e75fc. The question is: "Should I backport this fix to v1.13.0 or just use this commit to build qtav?" > > > If there're some guidelines on this, please tell me, thanks a lot! In general, we try to only package what upstream considers the "latest release". If the latest release doesn't work, we try to fix it in the smallest way that we can. So, in this case, that would mean trying to apply the patch you mentioned to the 1.13.0 release. If that works, great. Otherwise, we have to also consider the value of our own time, and it might be best to build the software based on the commit itself. Does that help?