unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Zhu Zihao <all_but_last@163.com>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Packaging question: Backport patch or use newer commit?
Date: Sat, 12 Sep 2020 12:35:10 -0400	[thread overview]
Message-ID: <20200912163510.GB27649@jasmine.lan> (raw)
In-Reply-To: <7877f6bd.36fa.174830f49cf.Coremail.all_but_last@163.com>

On Sun, Sep 13, 2020 at 12:04:11AM +0800, Zhu Zihao wrote:
> Hi everybody. I' m packaging digikam(https://digikam.org). A free photo management software from KDE project. There're 2 dependecies missing from current Guix(qtav & libksane)
> 
> 
> I tried to package qtav(https://github.com/wang-bin/QtAV/) first, but it's latest release(v1.13.0) failed to build with Qt 5.14. And it was fixed in https://github.com/wang-bin/QtAV/commit/5abba7f0505e75fc. The question is: "Should I backport this fix to v1.13.0 or just use this commit to build qtav?"
> 
> 
> If there're some guidelines on this, please tell me, thanks a lot!

In general, we try to only package what upstream considers the "latest
release".

If the latest release doesn't work, we try to fix it in the smallest way
that we can.

So, in this case, that would mean trying to apply the patch you
mentioned to the 1.13.0 release. If that works, great.

Otherwise, we have to also consider the value of our own time, and it
might be best to build the software based on the commit itself.

Does that help?


  reply	other threads:[~2020-09-12 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 16:04 Packaging question: Backport patch or use newer commit? Zhu Zihao
2020-09-12 16:35 ` Leo Famulari [this message]
2020-09-13  4:20   ` Zhu Zihao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200912163510.GB27649@jasmine.lan \
    --to=leo@famulari.name \
    --cc=all_but_last@163.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).